[Mellanox] Fix select timeout in sfp event#9795
Merged
liat-grozovik merged 2 commits intosonic-net:masterfrom Jan 27, 2022
Merged
[Mellanox] Fix select timeout in sfp event#9795liat-grozovik merged 2 commits intosonic-net:masterfrom
liat-grozovik merged 2 commits intosonic-net:masterfrom
Conversation
keboliu
previously approved these changes
Jan 19, 2022
|
This pull request introduces 1 alert when merging b85af1e into d5b0261 - view on LGTM.com new alerts:
|
Collaborator
|
@Junchao-Mellanox could you please clarify if this is required for 202111? |
Junchao-Mellanox
added
the
Request for 202111 Branch
Junchao-Mellanox
dismissed stale reviews from liat-grozovik and keboliu
via
a64e14f
keboliu
previously approved these changes
Jan 20, 2022
Collaborator
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
This change shall not affect sonic-xcvrd unit test at all. So I did a rebase to see if it could fix the unit test issue for sonic-xcvrd. |
Junchao-Mellanox
force-pushed
the
fix-select-timeout
branch
from
a64e14f to
8aafeea
Compare
Collaborator
Author
|
Hi @sujinmkang , could you please help review? |
sujinmkang
approved these changes
Jan 27, 2022
judyjoseph
pushed a commit
that referenced
this pull request
Jan 31, 2022
- Why I did it Python select.select accept a optional timeout value in seconds, however, the value passes to it is a value in millisecond. - How I did it Transfer the value to millisecond. - How to verify it Manual test
5 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
Jan 19, 2023
- Why I did it Backport #9795 Python select.select accept a optional timeout value in seconds, however, the value passes to it is a value in millisecond. - How I did it Transfer the value to millisecond. - How to verify it Manual test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Python select.select accept a optional timeout value in seconds, however, the value passes to it is a value in millisecond.
How I did it
Transfer the value to millisecond.
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)