[202012][Mellanox] Fix select timeout in sfp event#13347
Merged
liat-grozovik merged 1 commit intosonic-net:202012from Jan 19, 2023
Merged
[202012][Mellanox] Fix select timeout in sfp event#13347liat-grozovik merged 1 commit intosonic-net:202012from
liat-grozovik merged 1 commit intosonic-net:202012from
Conversation
Collaborator
Author
|
Hi @qiluo-msft , could you please help review? It is a backport of PR #9795 |
keboliu
approved these changes
Jan 13, 2023
prgeor
approved these changes
Jan 13, 2023
liat-grozovik
approved these changes
Jan 19, 2023
liat-grozovik
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Backport #9795
Python select.select accept a optional timeout value in seconds, however, the value passes to it is a value in millisecond.
How I did it
Transfer the value to millisecond.
How to verify it
Manual test
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)