[Arista] Remove duplicate logrotate configuration for arista.log#9731
Merged
sujinmkang merged 1 commit intosonic-net:masterfrom Mar 11, 2022
Merged
[Arista] Remove duplicate logrotate configuration for arista.log#9731sujinmkang merged 1 commit intosonic-net:masterfrom
sujinmkang merged 1 commit intosonic-net:masterfrom
Conversation
OleksandrKozodoi
previously approved these changes
Jan 12, 2022
Staphylo
dismissed stale reviews from OleksandrKozodoi and arlakshm
via
8f78870
Staphylo
force-pushed
the
master-logrotate
branch
from
30d12f5 to
8f78870
Compare
OleksandrKozodoi
previously approved these changes
Feb 2, 2022
Staphylo
force-pushed
the
master-logrotate
branch
from
8f78870 to
d0fb8e7
Compare
Staphylo
force-pushed
the
master-logrotate
branch
from
d0fb8e7 to
8fb7034
Compare
Contributor
|
@lguohan, please review and merge |
sujinmkang
approved these changes
Mar 11, 2022
Contributor
|
@lguohan @sujinmkang please cherry-pick into 202111 branch |
qiluo-msft
pushed a commit
that referenced
this pull request
Apr 28, 2022
Why I did it In parallel of this change Arista added a custom logrotate configuration as part of its driver library. Having 2 logrotate configuration for the same log file triggers an issue. Fixes aristanetworks/sonic#38 How I did it Arista merged a few changes in sonic-buildimage which added a logrotate configuration aristanetworks/sonic@e43c797 It is therefore the right path to remove the arista.log line from the logrotate.d/rsyslog configuration. How to verify it Logrotate works without any error message, arista log rotation happens and arista daemons still append logs once file was truncated.
bratashX
pushed a commit
to bratashX/sonic-buildimage
that referenced
this pull request
Jun 6, 2022
…9731) Why I did it In parallel of this change Arista added a custom logrotate configuration as part of its driver library. Having 2 logrotate configuration for the same log file triggers an issue. Fixes aristanetworks/sonic#38 How I did it Arista merged a few changes in sonic-buildimage which added a logrotate configuration aristanetworks/sonic@e43c797 It is therefore the right path to remove the arista.log line from the logrotate.d/rsyslog configuration. How to verify it Logrotate works without any error message, arista log rotation happens and arista daemons still append logs once file was truncated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
In parallel of this change Arista added a custom logrotate configuration as part of its driver library.
Having 2 logrotate configuration for the same log file triggers an issue.
Fixes aristanetworks/sonic#38
How I did it
Arista merged a few changes in sonic-buildimage which added a logrotate configuration aristanetworks/sonic@e43c797
It is therefore the right path to remove the
arista.logline from thelogrotate.d/rsyslogconfiguration.How to verify it
Logrotate works without any error message, arista log rotation happens and arista daemons still append logs once file was truncated.
Which release branch to backport (provide reason below if selected)
Issue also present on 202111
Description for the changelog
Remove duplicate arista.log logrotate from logrotate.d/rsyslog