[Arista] Remove arista.log from rsyslog default logrotate #10833
Closed
bratashX wants to merge 3 commits intosonic-net:202111from
Closed
[Arista] Remove arista.log from rsyslog default logrotate #10833bratashX wants to merge 3 commits intosonic-net:202111from
bratashX wants to merge 3 commits intosonic-net:202111from
Conversation
bratashX
force-pushed
the
202111_fix_logrotate
branch
from
60b5d41 to
499d8ef
Compare
bratashX
force-pushed
the
202111_fix_logrotate
branch
from
499d8ef to
7f1fd18
Compare
…9731) Why I did it In parallel of this change Arista added a custom logrotate configuration as part of its driver library. Having 2 logrotate configuration for the same log file triggers an issue. Fixes aristanetworks/sonic#38 How I did it Arista merged a few changes in sonic-buildimage which added a logrotate configuration aristanetworks/sonic@e43c797 It is therefore the right path to remove the arista.log line from the logrotate.d/rsyslog configuration. How to verify it Logrotate works without any error message, arista log rotation happens and arista daemons still append logs once file was truncated.
Staphylo
approved these changes
Jun 8, 2022
Contributor
Author
Contributor
Author
bratashX
force-pushed
the
202111_fix_logrotate
branch
from
8a5368b to
2bde0d4
Compare
Contributor
Author
|
@Staphylo could you please sign EasyCLA? |
Collaborator
|
/easycla |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's cherry-pick from master branch: #9731
Why I did it
In parallel of this change Arista added a custom logrotate configuration as part of its driver library.
Having 2 logrotate configuration for the same log file triggers an issue.
Fixes aristanetworks/sonic#38
How I did it
Arista merged a few changes in sonic-buildimage which added a logrotate configuration aristanetworks/sonic@e43c797
It is therefore the right path to remove the arista.log line from the logrotate.d/rsyslog configuration.
How to verify it
Logrotate works without any error message, arista log rotation happens and arista daemons still append logs once file was truncated.