Updated Internal BGP Templates for chassis packet#9674
Merged
abdosi merged 26 commits intosonic-net:masterfrom Feb 8, 2022
Merged
Updated Internal BGP Templates for chassis packet#9674abdosi merged 26 commits intosonic-net:masterfrom
abdosi merged 26 commits intosonic-net:masterfrom
Conversation
df46ed418e661a9bccdb2639d8873def356f8ba0 (HEAD -> master, origin/master, origin/HEAD) Fix the LLDP_LOC_CHASSIS not getting populated if no remote neighbors are present (sonic-net#39) e487532e11cc0e97cfce573b6b997fdd0beeb660 [CI] Set up CI&PR with Azure Pipelines (sonic-net#38) 3c9f488490a1dbded20dbf2d8a88a5ab4dbda8df Replace swsssdk's SonicV2Connector with swsscommon's implementation (sonic-net#35) Signed-off-by: Abhishek Dosi <[email protected]>
• Internal BGP Peering between LCx-ASICy is done using Loopback4096 • Internal BGP Peer will be classified as BGP_INTERNAL_NEIGHBOR with source updated as Loopback4096 • DEVICE_METADATA will have “switch_type” define as “chassis-packet”. We already have “voq” define. This will be used in BGP template. • Static Routes are define using SONiC schema. * Fixed Vlan Sub Interface Parsing in Graph when configured on Port-Channel. * Added Unit test cases of graph and BGP template changes. Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Also address review comments for PR:sonic-net#8966 Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
Signed-off-by: Abhishek Dosi <[email protected]>
1. For Packet Chassis do not advertise Loopback4096 address into BGP as there is Static Route for same. 2. Advertise only P2P Connected IP's into BGP Signed-off-by: Abhishek Dosi <[email protected]>
This reverts commit 9a2b3d0.
By default FRR will be in Graceful Helper mode Signed-off-by: Abhishek Dosi <[email protected]>
correctly because of timing issue where DB might not be poupulated. So Instead of using IP Address using Interface name. Fixes: sonic-net#9610 Signed-off-by: Abhishek Dosi <[email protected]>
abdosi
added
Chassis 🤖
Contributor
Author
|
@anamehra Can you please check if this fixes the issue. |
Contributor
anamehra
approved these changes
Jan 10, 2022
Contributor
Author
|
@arlakshm can you please help review/approve this. |
Contributor
|
@abdosi, as discussed offline can you verify the race condition where the Loopback4096 ip address is configuration after the bgp configuration is applied in FRR |
Contributor
Author
arlakshm
approved these changes
Feb 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why I did:
How I verify:
Unit Test.