[chassis-packet] minigraph parsing and BGP template changes#8966
Merged
abdosi merged 12 commits intosonic-net:masterfrom Oct 19, 2021
Merged
[chassis-packet] minigraph parsing and BGP template changes#8966abdosi merged 12 commits intosonic-net:masterfrom
abdosi merged 12 commits intosonic-net:masterfrom
Conversation
df46ed418e661a9bccdb2639d8873def356f8ba0 (HEAD -> master, origin/master, origin/HEAD) Fix the LLDP_LOC_CHASSIS not getting populated if no remote neighbors are present (sonic-net#39) e487532e11cc0e97cfce573b6b997fdd0beeb660 [CI] Set up CI&PR with Azure Pipelines (sonic-net#38) 3c9f488490a1dbded20dbf2d8a88a5ab4dbda8df Replace swsssdk's SonicV2Connector with swsscommon's implementation (sonic-net#35) Signed-off-by: Abhishek Dosi <[email protected]>
• Internal BGP Peering between LCx-ASICy is done using Loopback4096 • Internal BGP Peer will be classified as BGP_INTERNAL_NEIGHBOR with source updated as Loopback4096 • DEVICE_METADATA will have “switch_type” define as “chassis-packet”. We already have “voq” define. This will be used in BGP template. • Static Routes are define using SONiC schema. * Fixed Vlan Sub Interface Parsing in Graph when configured on Port-Channel. * Added Unit test cases of graph and BGP template changes. Signed-off-by: Abhishek Dosi <[email protected]>
abdosi
force-pushed
the
chassis-packet
branch
from
d6eb589 to
3e74182
Compare
abdosi
changed the title
Contributor
Author
|
@anamehra Please review from your side also. |
Signed-off-by: Abhishek Dosi <[email protected]>
arlakshm
reviewed
Oct 15, 2021
Comment on lines
+48
to
+49
| address-family ipv6 | ||
| network fc01::1/64 |
Contributor
There was a problem hiding this comment.
These two lines are present in lines 40 and 41, seems repeated here
Contributor
Author
There was a problem hiding this comment.
working on another PR.. will fix it there.
Comment on lines
+1411
to
1414
| elif intf[0][0:11] == 'PortChannel': | ||
| pc_intfs[intf] = {} | ||
| pc_intfs[intf[0]] = {} | ||
| else: |
Contributor
There was a problem hiding this comment.
Is this to allow the vlan sub interface table to pick up the portchannel subinterfaces? If so, where is the portchannel subinterface parsed?
Contributor
Author
There was a problem hiding this comment.
yes for PortChannel Vlan SubInterface. Parsing is done by existing code: https://github.com/Azure/sonic-buildimage/blob/6e2fecfa6b8be3cf2605c6673438339d20902a32/src/sonic-config-engine/minigraph.py#L448
| @@ -0,0 +1,60 @@ | |||
| # name lanes alias index speed asic_port_name role source_npu target_npu | |||
Contributor
There was a problem hiding this comment.
Fix the file formatting as well
Contributor
Author
There was a problem hiding this comment.
working on another PR.. will fix it there.
| utils.to_dict("{'rrclient': 0, 'name': 'str2-8808-lc0-ASIC1', 'local_addr': '8.0.0.3', 'nhopself': 0, 'admin_status': 'up', 'holdtime': '0', 'asn': '65100', 'keepalive': '0'}") | ||
| ) | ||
|
|
||
| def test_minigraph_bgp_packet_chassis_static_route(self): |
Contributor
There was a problem hiding this comment.
add a tests for the single asic linecard?
Contributor
Author
There was a problem hiding this comment.
working on another PR.. will fix it there.
Contributor
Author
|
@arlakshm i will take care of this comment as part of next pr as these are not blocking. Would like to merge this PR |
arlakshm
approved these changes
Oct 19, 2021
abdosi
added a commit
to abdosi/sonic-buildimage
that referenced
this pull request
Oct 28, 2021
Also address review comments for PR:sonic-net#8966 Signed-off-by: Abhishek Dosi <[email protected]>
abdosi
added a commit
that referenced
this pull request
Oct 29, 2021
What I did: Fix the typo in Internal Peer Group template for Packet-based Chassis. Address Review comments of PR: [chassis-packet] minigraph parsing and BGP template changes #8966 - Static Route Parsing for Host - Formatting of chassis port_config.ini
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Dec 13, 2021
…ernal branch Related work items: sonic-net#525, sonic-net#534, sonic-net#909, sonic-net#927, sonic-net#930, sonic-net#934, sonic-net#935, sonic-net#937, sonic-net#938, sonic-net#939, sonic-net#940, sonic-net#943, sonic-net#944, sonic-net#945, sonic-net#946, sonic-net#948, sonic-net#1702, sonic-net#1923, sonic-net#1936, sonic-net#1942, sonic-net#2315, sonic-net#7281, sonic-net#7375, sonic-net#8659, sonic-net#8799, sonic-net#8868, sonic-net#8875, sonic-net#8935, sonic-net#8942, sonic-net#8956, sonic-net#8961, sonic-net#8966, sonic-net#8969, sonic-net#8971, sonic-net#8978, sonic-net#8991, sonic-net#8996, sonic-net#9001, sonic-net#9008, #3146150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did:
How I Verify: