[dhcp_relay] Fix import for dhcp_counters on clear_dhcp6relay_counter.py#8991
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Oct 19, 2021
shlomibitton:shlomi_clear_arp_dhcp
Merged
[dhcp_relay] Fix import for dhcp_counters on clear_dhcp6relay_counter.py#8991qiluo-msft merged 1 commit intosonic-net:masterfrom shlomibitton:shlomi_clear_arp_dhcp
qiluo-msft merged 1 commit intosonic-net:masterfrom
shlomibitton:shlomi_clear_arp_dhcp
Conversation
Signed-off-by: Shlomi Bitton <[email protected]>
Contributor
Author
|
@kellyyeh can you please review? |
Collaborator
|
@tahmed-dev could you please help to review? |
|
This pull request introduces 1 alert when merging 0b5391a into e6e6f41 - view on LGTM.com new alerts:
|
kellyyeh
approved these changes
Oct 17, 2021
Contributor
|
@dgsudharsan @shlomibitton, Please raise a separate PR and merge directly in 202106 - as there are merge conflicts |
liushilongbuaa
pushed a commit
to liushilongbuaa/sonic-buildimage
that referenced
this pull request
Dec 13, 2021
…ernal branch Related work items: sonic-net#525, sonic-net#534, sonic-net#909, sonic-net#927, sonic-net#930, sonic-net#934, sonic-net#935, sonic-net#937, sonic-net#938, sonic-net#939, sonic-net#940, sonic-net#943, sonic-net#944, sonic-net#945, sonic-net#946, sonic-net#948, sonic-net#1702, sonic-net#1923, sonic-net#1936, sonic-net#1942, sonic-net#2315, sonic-net#7281, sonic-net#7375, sonic-net#8659, sonic-net#8799, sonic-net#8868, sonic-net#8875, sonic-net#8935, sonic-net#8942, sonic-net#8956, sonic-net#8961, sonic-net#8966, sonic-net#8969, sonic-net#8971, sonic-net#8978, sonic-net#8991, sonic-net#8996, sonic-net#9001, sonic-net#9008, #3146150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shlomi Bitton [email protected]
Why I did it
Import issue will cause:
root@sonic:/# sudo sonic-clear arp
failed to import plugin clear.plugins.dhcprelay: No module named 'show_dhcp_relay'
How I did it
Fix the import.
How to verify it
run sudo sonic-clear arp
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)