Skip to content

Dell S6100: Modify transceiver change event from interrupt to poll mode#7309

Merged
jleveque merged 2 commits intosonic-net:masterfrom
aravindmani-1:Dell_S6100_OIR
Apr 14, 2021
Merged

Dell S6100: Modify transceiver change event from interrupt to poll mode#7309
jleveque merged 2 commits intosonic-net:masterfrom
aravindmani-1:Dell_S6100_OIR

Conversation

@aravindmani-1
Copy link
Contributor

@aravindmani-1 aravindmani-1 commented Apr 13, 2021

Why I did it

  • xcvrd crash was seen in latest 201811 images.
  • For Dell S6100,API 2.0 uses poll mode while 1.0 was still using interrupt mode.

How I did it

  • Modified get_transceiver_change_event in 1.0 to poll mode.

How to verify it

  • Do OIR testing, check xcvrd status and syslogs.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

[UT:]
s6100_xcvr_UT.txt

A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Apr 13, 2021

This pull request introduces 1 alert and fixes 2 when merging 8ed1d29 into 75c29cb - view on LGTM.com

new alerts:

  • 1 for Unused import

fixed alerts:

  • 1 for Except block handles 'BaseException'
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Apr 13, 2021

This pull request fixes 2 alerts when merging c487952 into 75c29cb - view on LGTM.com

fixed alerts:

  • 1 for Except block handles 'BaseException'
  • 1 for Unreachable code

@jleveque
Copy link
Contributor

xcvrd crash was seen in latest 201811 images.

@aravindmani-1: This PR is raised against the master branch with no indication that it should be backported to other branches. Is this expected?

@aravindmani-1
Copy link
Contributor Author

xcvrd crash was seen in latest 201811 images.

@aravindmani-1: This PR is raised against the master branch with no indication that it should be backported to other branches. Is this expected?

Cherry pick to 201811 may not work. I'll raise a separate PR for 201811 branch.

@jleveque
Copy link
Contributor

Cherry pick to 201811 may not work. I'll raise a separate PR for 201811 branch.

@aravindmani-1: What about 202012 and 201911 branches?

@aravindmani-1
Copy link
Contributor Author

Cherry pick to 201811 may not work. I'll raise a separate PR for 201811 branch.

@aravindmani-1: What about 202012 and 201911 branches?
Added the cherry pick request for 202012. For 201911, i'll have to raise a separate PR. sfputil changes will be merged properly but platform init script varies across branches. so, cherry pick might not work.

@jleveque jleveque merged commit 95fecaf into sonic-net:master Apr 14, 2021
@aravindmani-1 aravindmani-1 deleted the Dell_S6100_OIR branch April 15, 2021 03:50
lguohan pushed a commit that referenced this pull request Apr 16, 2021
dell_ich driver was removed as part of #7309 and it is needed for watchdog tickle in S6100 platform.
jleveque pushed a commit that referenced this pull request Apr 20, 2021
…o poll mode (#7334)

#### Why I did it

- xcvrd crash was seen in latest 201811 images.
- For Dell S6100,API 2.0 uses poll mode while 1.0 was still using interrupt mode.

#### How I did it

- Modified get_transceiver_change_event in 1.0 to poll mode in all the related branches.

Backport of #7309 to the 201911 branch
daall pushed a commit that referenced this pull request Apr 21, 2021
…de (#7309)

#### Why I did it

- xcvrd crash was seen in latest 201811 images.
- For Dell S6100,API 2.0 uses poll mode while 1.0 was still using interrupt mode.

#### How I did it

- Modified get_transceiver_change_event in 1.0 to poll mode.
daall pushed a commit that referenced this pull request Apr 21, 2021
dell_ich driver was removed as part of #7309 and it is needed for watchdog tickle in S6100 platform.
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
…de (sonic-net#7309)

#### Why I did it

- xcvrd crash was seen in latest 201811 images.
- For Dell S6100,API 2.0 uses poll mode while 1.0 was still using interrupt mode.

#### How I did it

- Modified get_transceiver_change_event in 1.0 to poll mode.
raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-buildimage that referenced this pull request May 23, 2021
dell_ich driver was removed as part of sonic-net#7309 and it is needed for watchdog tickle in S6100 platform.
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
…de (sonic-net#7309)

#### Why I did it

- xcvrd crash was seen in latest 201811 images.
- For Dell S6100,API 2.0 uses poll mode while 1.0 was still using interrupt mode.

#### How I did it

- Modified get_transceiver_change_event in 1.0 to poll mode.
carl-nokia pushed a commit to carl-nokia/sonic-buildimage that referenced this pull request Aug 7, 2021
dell_ich driver was removed as part of sonic-net#7309 and it is needed for watchdog tickle in S6100 platform.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants