Skip to content

[201911] Dell S6100: Modify transceiver change event from interrupt to poll mode#7334

Merged
jleveque merged 2 commits intosonic-net:201911from
aravindmani-1:201911_change_xcvr_poll_mode
Apr 20, 2021
Merged

[201911] Dell S6100: Modify transceiver change event from interrupt to poll mode#7334
jleveque merged 2 commits intosonic-net:201911from
aravindmani-1:201911_change_xcvr_poll_mode

Conversation

@aravindmani-1
Copy link
Contributor

Why I did it

  • xcvrd crash was seen in latest 201811 images.
  • For Dell S6100,API 2.0 uses poll mode while 1.0 was still using interrupt mode.

How I did it

  • Modified get_transceiver_change_event in 1.0 to poll mode in all the related branches.

How to verify it

  • Do OIR testing, check xcvrd status and syslogs.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012

Description for the changelog

UT:
201911_change_event_UT.txt

A picture of a cute animal (not mandatory but encouraged)

@lgtm-com
Copy link

lgtm-com bot commented Apr 15, 2021

This pull request fixes 2 alerts when merging 1bc8d90 into b375053 - view on LGTM.com

fixed alerts:

  • 1 for Except block handles 'BaseException'
  • 1 for Unreachable code

@lgtm-com
Copy link

lgtm-com bot commented Apr 15, 2021

This pull request fixes 2 alerts when merging 4cfe474 into b375053 - view on LGTM.com

fixed alerts:

  • 1 for Except block handles 'BaseException'
  • 1 for Unreachable code

@jleveque jleveque changed the title <201911> Dell S6100: Modify transceiver change event from interrupt to poll mode [201911] Dell S6100: Modify transceiver change event from interrupt to poll mode Apr 16, 2021
@jleveque
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jleveque jleveque merged commit 89adef3 into sonic-net:201911 Apr 20, 2021
@aravindmani-1 aravindmani-1 deleted the 201911_change_xcvr_poll_mode branch April 26, 2021 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants