Making PDDF 2.0 base classes python3 compliant#6924
Merged
jleveque merged 2 commits intosonic-net:masterfrom Mar 1, 2021
Merged
Making PDDF 2.0 base classes python3 compliant#6924jleveque merged 2 commits intosonic-net:masterfrom
jleveque merged 2 commits intosonic-net:masterfrom
Conversation
4 tasks
Collaborator
|
@lguohan and review team - please look at this at the earliest - we are working with Accton on a platform contribution that has a dependency upon this PR - thanks. |
jleveque
approved these changes
Mar 1, 2021
Collaborator
|
Thanks Joe! |
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
- Made python2 to python3 changes - Removed ord() func as python3 return int instead of str - Had to change chr(..) to bytes([..]) function while using ctypes class methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
We need to make the PDDF 2.0 base API implementation python3 compliant
How I did it
How to verify it
Verified it with a sample AS9716 (TH3) platform which is being using PDDF as in PR (#6902).
Without these changes we were not able to load the PAI 2.0 and getting the following errors.
After the fix,
Which release branch to backport (provide reason below if selected)
Description for the changelog
Related to the PR (#6902)
A picture of a cute animal (not mandatory but encouraged)