[as9716-32d] Add to support PDDF#6902
Merged
jleveque merged 29 commits intosonic-net:masterfrom Apr 14, 2021
Merged
Conversation
3 tasks
|
This pull request introduces 6 alerts when merging 89f7bbaf7cc0ecc5627fc15d734b6a92da9037aa into 21f5e12 - view on LGTM.com new alerts:
|
4 tasks
Contributor
|
Depends on the PR #6924 |
Contributor
|
retest this please |
1 similar comment
Contributor
|
retest this please |
Contributor
Author
|
retest please |
|
This pull request introduces 2 alerts when merging 6f94788486fe8fcb7eb4797ad6d2cca2b7542f3f into 653bd08 - view on LGTM.com new alerts:
|
Contributor
|
The LGTM warnings can be ignored as per the comments in Please ignore the new lgtm alerts |
FuzailBrcm
reviewed
Mar 21, 2021
Contributor
FuzailBrcm
left a comment
FuzailBrcm
left a comment
There was a problem hiding this comment.
Can you change get_change_event() to use presence bit instead of interrupt_status bit?
Contributor
Author
OK. |
FuzailBrcm
previously approved these changes
Mar 22, 2021
Contributor
FuzailBrcm
left a comment
FuzailBrcm
left a comment
There was a problem hiding this comment.
Changes look good to me
Contributor
|
retest please |
added 8 commits
April 8, 2021 16:33
Signed-off-by: Jostar Yang <[email protected]>
jostar-yang
force-pushed
the
as9716_20210225_pddf
branch
from
5b94856 to
1bb73f3
Compare
jostar-yang
force-pushed
the
as9716_20210225_pddf
branch
from
1c9552b to
48659a6
Compare
jostar-yang
force-pushed
the
as9716_20210225_pddf
branch
from
07561ae to
e1887b7
Compare
FuzailBrcm
approved these changes
Apr 9, 2021
jleveque
approved these changes
Apr 14, 2021
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-buildimage
that referenced
this pull request
May 23, 2021
Add PDDF support for Accton as9716-32d platform Co-authored-by: Jostar Yang <[email protected]>
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Add PDDF support for Accton as9716-32d platform Co-authored-by: Jostar Yang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jostar Yang [email protected]
Why I did it
Add as9716-32d to support BRCM PDDF platform
How I did it
Implement code and do testing.
How to verify it
Test via pddf cmd,
pddf_fanutil getspeed
FAN SPEED (RPM)
FAN1_1 11600
FAN1_2 11700
FAN2_1 11800
FAN2_2 11900
FAN3_1 11500
FAN3_2 11600
FAN4_1 11800
FAN4_2 12000
FAN5_1 12200
FAN5_2 12200
FAN6_1 11900
FAN6_2 12000
pddf_thermalutil gettemp
Temp Sensor Label Value
TEMP1 lm75-i2c-49-48 temp1 +31.5 C (high = +80.0 C, hyst = +75.0 C)
TEMP2 lm75-i2c-49-49 temp1 +30.0 C (high = +80.0 C, hyst = +75.0 C)
TEMP3 lm75-i2c-49-4a temp1 +30.5 C (high = +80.0 C, hyst = +75.0 C)
TEMP4 lm75-i2c-49-4b temp1 +26.0 C (high = +80.0 C, hyst = +75.0 C)
TEMP5 lm75-i2c-49-4c temp1 +31.0 C (high = +80.0 C, hyst = +75.0 C)
TEMP6 lm75-i2c-49-4e temp1 +29.0 C (high = +80.0 C, hyst = +75.0 C)
TEMP7 lm75-i2c-49-4f temp1 +33.5 C (high = +80.0 C, hyst = +75.0 C)
pddf_psuutil mfrinfo
PSU1 is OK
Manufacture Id: ACBEL
Model: FSH082
Serial Number: 000817
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)