Updated BBR to use peer group name as prefix.#6515
Merged
abdosi merged 2 commits intosonic-net:masterfrom Jan 22, 2021
Merged
Conversation
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
lguohan
previously approved these changes
Jan 21, 2021
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
lguohan
approved these changes
Jan 22, 2021
daall
pushed a commit
that referenced
this pull request
Jan 22, 2021
To make BBR configured for peer-group if it's name starts with (prefixed) with the string define in constants.yml instead of exact string match.
abdosi
added a commit
that referenced
this pull request
Jan 22, 2021
To make BBR configured for peer-group if it's name starts with (prefixed) with the string define in constants.yml instead of exact string match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why/What I did:
Currently BBR Manager looks for peer-group name to start with value define in constants.yml (https://github.com/Azure/sonic-buildimage/blob/master/files/image_config/constants/constants.yml#L40). Peer-name need to be exact string match.
The change in this PR is to make BBR configured for peer-group if it's name starts with (prefixed) with the string define in constants.yml.
This is needed because Peer name can have deployment id at the end with the string "DEPLOYMENT_ID_NUM".
Eg: TIER0_V4_DEPLOYMENT_ID_0
How I verify: