[201911] Updated BBR to use peer group name as prefix.#6497
Closed
abdosi wants to merge 2 commits intosonic-net:201911from
Closed
[201911] Updated BBR to use peer group name as prefix.#6497abdosi wants to merge 2 commits intosonic-net:201911from
abdosi wants to merge 2 commits intosonic-net:201911from
Conversation
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Collaborator
|
do we need this for master branch? |
Collaborator
|
also, can you check how to add the unit test for this feature? @lguohan Added unit test cases. |
Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Contributor
Author
@lguohan Yes will be creating separate PR for master |
Collaborator
|
let's merge the master image pr and then cherry-pick. |
Contributor
Author
|
cherry-pick from master PR. Closing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why I did:
Same change as in master (PR #6515) for 201911.
In 201911 BBR is configured for each peer instead of peer-group.
How I verify:
neighbor 10.0.0.33 peer-group TIER0_V4_DEPLOYMENT_ID_0
neighbor 10.0.0.63 peer-group TIER0_V4_DEPLOYMENT_ID_2
neighbor 10.0.0.33 allowas-in 1
neighbor 10.0.0.63 allowas-in 1
neighbor fc00::7a peer-group TIER0_V6_DEPLOYMENT_ID_0
neighbor fc00::7e peer-group TIER0_V6_DEPLOYMENT_ID_2
neighbor fc00::7a allowas-in 1
neighbor fc00::7e allowas-in 1