Skip to content

[sonic-py-common] Added an API to get file path containing SONiC version #6309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smaheshm merged 2 commits into from
Jan 3, 2021
Merged

[sonic-py-common] Added an API to get file path containing SONiC version #6309

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
452b431
add api to get file patch containing SONiC version
smaheshm Dec 28, 2020
60924b9
use macro instead of recreating the path
smaheshm Dec 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/sonic-py-common/sonic_py_common/device_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,11 @@ def get_sonic_version_info():

return data

def get_sonic_version_file():
if not os.path.isfile(SONIC_VERSION_YAML_PATH):
return None
Copy link
Contributor

@judyjoseph judyjoseph Dec 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does all the current callers of this API, handle a return value of "None" ? If this is a mandatory file, we could raise an exception.

Copy link
Contributor Author

@smaheshm smaheshm Dec 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one caller (sonic-net/sonic-utilities#1266). I'd say let's leave it to the caller to decide. Python will raise exception anyway.


return SONIC_VERSION_YAML_PATH

#
# Multi-NPU functionality
Expand Down