[pytest][qos][config] Added pytests for "config qos reload" commands by smaheshm · Pull Request #1266 · sonic-net/sonic-utilities

smaheshm · 2020-11-24T00:39:34Z

- What I did
Added pytests for "config qos reload" commands for single and multi ASIC platforms.

- How I did it
Since 'config qos reload' command invokdes'sonic-cfggen' process, add a "--dry-run" option to 'config qos reload' command so that it passes the right parameters to 'sonic-cfggen' to not 'read and write' to config DB in unit test env. Also added '--json-data' option that gives flexibility to test variable parameters like tiers and switch roles.

- How to verify it

Unit test.

======================================
samaddik@83f02bcc27aa:/sonic/src/sonic-utilities/tests$ pytest-3  -s -k reload
============================= test session starts ==============================
platform linux -- Python 3.7.3, pytest-3.10.1, py-1.7.0, pluggy-0.8.0
rootdir: /sonic/src/sonic-utilities/tests, inifile: pytest.ini
plugins: cov-2.6.0
collected 337 items / 335 deselected

config_test.py SETUP
Saving output in /tmp/qos_config_output.json
0
Running command: /usr/local/bin/sonic-cfggen  --additional-data '{"DEVICE_METADATA": {"localhost": {}}}' -t /sonic/src/sonic-utilities/tests/qos_config_input/buffers.json.j2,/tmp/qos_config_output.json -t /sonic/src/sonic-utilities/tests/qos_config_input/qos.json.j2,/tmp/qos_config_output.json -y /sonic/src/sonic-utilities/tests/qos_config_input/sonic_version.yml

.TEARDOWN
SETUP
Saving output in /tmp/qos_config_output.json<0,1,2..>
0
Running command: /usr/local/bin/sonic-cfggen -n asic0 --additional-data '{"DEVICE_METADATA": {"localhost": {}}}' -t /sonic/src/sonic-utilities/tests/qos_config_input/0/buffers.json.j2,/tmp/qos_config_output.json0 -t /sonic/src/sonic-utilities/tests/qos_config_input/0/qos.json.j2,/tmp/qos_config_output.json0 -y /sonic/src/sonic-utilities/tests/qos_config_input/sonic_version.yml
Running command: /usr/local/bin/sonic-cfggen -n asic1 --additional-data '{"DEVICE_METADATA": {"localhost": {}}}' -t /sonic/src/sonic-utilities/tests/qos_config_input/1/buffers.json.j2,/tmp/qos_config_output.json1 -t /sonic/src/sonic-utilities/tests/qos_config_input/1/qos.json.j2,/tmp/qos_config_output.json1 -y /sonic/src/sonic-utilities/tests/qos_config_input/sonic_version.yml

.TEARDOWN


=================== 2 passed, 335 deselected in 1.51 seconds ===================

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

smaheshm · 2020-11-24T01:41:23Z

retest this please

smaheshm · 2020-12-08T17:32:52Z

👋

smaheshm · 2020-12-09T21:14:45Z

retest this please

smaheshm · 2020-12-10T01:00:53Z

retest this please

smaheshm · 2020-12-11T19:50:15Z

Gentle reminder @neethajohn @abdosi

tests/conftest.py

tests/mock_tables/mock_multi_asic.py

tests/config_test.py

smaheshm · 2020-12-18T23:16:01Z

retest this please

smaheshm · 2020-12-19T19:57:59Z

retest this please

smaheshm · 2020-12-19T19:58:39Z

retest this please

smaheshm · 2020-12-22T19:32:22Z

retest this please

smaheshm · 2020-12-22T22:00:42Z

retest this please

…ommands (#1266)" This reverts commit 6202a81.

lguohan · 2020-12-27T20:11:38Z

this commit caused vkm test failure https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/8207/

it is reverted, can you resubmit the pr?

smaheshm · 2020-12-28T16:35:56Z

this commit caused vkm test failure https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/8207/

it is reverted, can you resubmit the pr?

taking a look, will resubmit.

smaheshm · 2021-01-04T21:16:38Z

this commit caused vkm test failure https://sonic-jenkins.westus2.cloudapp.azure.com/job/vs/job/buildimage-vs-image-pr/8207/
it is reverted, can you resubmit the pr?

taking a look, will resubmit.

Added the offending API
sonic-net/sonic-buildimage#6309

…eload" commands (sonic-net#1266)"" This reverts commit de14939. The commit was reverted due to a failure in sonic-buildimage unit tests, which was due to an un-implemented API. This is now fixed in PR #6309 (sonic-buildimage)

…onic-net#1266) Added pytests for "config qos reload" commands.

…ommands (sonic-net#1266)" This reverts commit 6202a81.

smaheshm added 4 commits November 21, 2020 00:13

qos config reload tests

b355db5

config qos pytests

c1edcd6

fix the env variable

77db4f6

reset mock.get_num_npus to return 1

93e4cbd

smaheshm added 4 commits December 2, 2020 23:25

minor update

363e419

merge

83fd79b

reload module

afe482a

reload module

23f816b

smaheshm requested review from abdosi and neethajohn December 3, 2020 18:45

smaheshm marked this pull request as ready for review December 3, 2020 18:47

Update and Merge

50664fd

neethajohn reviewed Dec 18, 2020

View reviewed changes

tests/conftest.py Show resolved Hide resolved

tests/mock_tables/mock_multi_asic.py Show resolved Hide resolved

tests/config_test.py Show resolved Hide resolved

tests/config_test.py Show resolved Hide resolved

smaheshm added 2 commits December 18, 2020 19:56

separate out qos mock API changes

5afab66

undefined variable fix

aebb665

neethajohn approved these changes Dec 18, 2020

View reviewed changes

neethajohn added the Unit Tests label Dec 18, 2020

Merge remote-tracking branch 'upstream/master' into config_qos

58ba851

smaheshm merged commit 6202a81 into sonic-net:master Dec 23, 2020

lguohan added a commit that referenced this pull request Dec 27, 2020

Revert "[pytest][qos][config] Added pytests for "config qos reload" c…

de14939

…ommands (#1266)" This reverts commit 6202a81.

smaheshm mentioned this pull request Dec 28, 2020

[sonic-py-common] Added an API to get file path containing SONiC version sonic-net/sonic-buildimage#6309

Merged

3 tasks

smaheshm mentioned this pull request Jan 4, 2021

[pytest][qos][config] Added pytests for "config qos reload" commands #1346

Merged

smaheshm deleted the config_qos branch February 26, 2021 22:33

anand-kumar-subramanian pushed a commit to anand-kumar-subramanian/sonic-utilities that referenced this pull request Mar 2, 2021

[pytest][qos][config] Added pytests for "config qos reload" commands (s…

c6fdf3a

…onic-net#1266) Added pytests for "config qos reload" commands.

anand-kumar-subramanian pushed a commit to anand-kumar-subramanian/sonic-utilities that referenced this pull request Mar 2, 2021

Revert "[pytest][qos][config] Added pytests for "config qos reload" c…

1ecad10

…ommands (sonic-net#1266)" This reverts commit 6202a81.

Conversation

smaheshm commented Nov 24, 2020

Uh oh!

smaheshm commented Nov 24, 2020

Uh oh!

smaheshm commented Dec 8, 2020

Uh oh!

smaheshm commented Dec 9, 2020

Uh oh!

smaheshm commented Dec 10, 2020

Uh oh!

smaheshm commented Dec 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smaheshm commented Dec 18, 2020

Uh oh!

smaheshm commented Dec 19, 2020

Uh oh!

smaheshm commented Dec 19, 2020

Uh oh!

smaheshm commented Dec 22, 2020

Uh oh!

smaheshm commented Dec 22, 2020

Uh oh!

lguohan commented Dec 27, 2020

Uh oh!

smaheshm commented Dec 28, 2020

Uh oh!

smaheshm commented Jan 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants