[files/build]: Support reproduceable build for docker image#5895
Closed
liushilongbuaa wants to merge 2 commits intosonic-net:masterfrom
liushilongbuaa:version-control-docker
Closed
[files/build]: Support reproduceable build for docker image#5895liushilongbuaa wants to merge 2 commits intosonic-net:masterfrom liushilongbuaa:version-control-docker
liushilongbuaa wants to merge 2 commits intosonic-net:masterfrom
liushilongbuaa:version-control-docker
Conversation
Contributor
Author
|
retest broadcom please #Closed |
Contributor
Author
|
retest mellanox please #Closed |
Contributor
Author
|
retest this please #Closed |
qiluo-msft
reviewed
Dec 2, 2020
qiluo-msft
reviewed
Dec 2, 2020
qiluo-msft
reviewed
Dec 2, 2020
qiluo-msft
reviewed
Dec 2, 2020
Contributor
Author
|
retest this please #ByDesign |
2 similar comments
Contributor
Author
|
retest this please #ByDesign |
Contributor
Author
|
retest this please #ByDesign |
xumia
reviewed
Jan 11, 2021
src/sonic-build-hooks/hooks/j2
Outdated
Collaborator
There was a problem hiding this comment.
We may not need to hook the j2 script, we only want to change the Dockerfile file. I suggest change Makefile only, not to hook the j2 script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
Some component's make process uses thirdparty docker image by "FROM" in Dockerfile. They use image and tag to specify a docker image. When the image with the same tag changed, build process may fail.
- How I did it
But when you want to use latest docker image, set parameter 'SONIC_VERSION_CONTROL_COMPONENTS ' and build. At last replace the hash value in 'files/build/versions/versions-docker' by 'files/build/versions/versions-docker-latest'.
- How to verify it
'files/build/versions/versions-docker.log' will record some infomation.
- Which release branch to backport (provide reason below if selected)
- Description for the changelog
support version control of the docker image
- A picture of a cute animal (not mandatory but encouraged)