Add SONiC Reproduceable Build design doc#684
Merged
xumia merged 9 commits intosonic-net:masterfrom Oct 18, 2022
Merged
Conversation
3 tasks
3 tasks
qiluo-msft
reviewed
Nov 25, 2020
Contributor
|
Searching on "make freeze" support, deb/py/web(sonic-net/sonic-buildimage#6255) and git(sonic-net/sonic-buildimage#6562) have been submitted, any plan to support the rest? Looks like the docker hook is the one missing now. |
Contributor
Author
|
@baxia-lan , docker hook is in progress, we have already submitted a PR sonic-net/sonic-buildimage#5895, but it closed for conflict with another native dockerd PR sonic-net/sonic-buildimage#6086. |
yxieca
force-pushed
the
master
branch
2 times, most recently
from
8498931 to
8837dc2
Compare
Contributor
Author
|
@qiluo-msft , can you please review again, thanks. |
qiluo-msft
previously approved these changes
Oct 10, 2022
Contributor
Author
|
Converted to the file to Unix format. |
Contributor
Author
|
@globaltrouble, could you please review again, thanks. |
qiluo-msft
approved these changes
Oct 17, 2022
Contributor
qiluo-msft
left a comment
qiluo-msft
left a comment
There was a problem hiding this comment.
LGTM. Please check with other reviewers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.