Skip to content

Add TELEMETRY_WRITABLE build option to enable telemetry write mode (default read-only) #4209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
renukamanavalan merged 16 commits into from
Jun 25, 2020
Merged

Add TELEMETRY_WRITABLE build option to enable telemetry write mode (default read-only) #4209

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
fb9036d
Add build option to make telemetry read-only
seiferteric Feb 28, 2020
2a1e736
Fix indent
seiferteric Feb 29, 2020
8603815
Change TELEMETRY_REAONLY to TELEMETRY_READWRITE since default will be…
seiferteric Mar 10, 2020
762a5b8
Updated supported parameters and config/rules to include TELMETRY_REA…
seiferteric Mar 10, 2020
3cafe6d
Merge remote-tracking branch 'azure/master' into azure_ro_mode
seiferteric Mar 22, 2020
5a6d462
Merge remote-tracking branch 'azure/master' into azure_ro_mode
seiferteric Mar 23, 2020
57c591b
Add SONIC preix to telemetry readonly flag
seiferteric Mar 23, 2020
f514d09
Update rules/config with correct flag name
seiferteric Mar 23, 2020
42ff12c
Merge remote-tracking branch 'azure/master' into azure_ro_mode
seiferteric Mar 23, 2020
4d70acd
Merge remote-tracking branch 'origin/master' into azure_ro_mode
seiferteric Jun 2, 2020
2c35081
Change SONIC_TELEMETRY_READWRITE flag to SONIC_TELEMETRY_WRITABLE
seiferteric Jun 4, 2020
82a0255
Merge remote-tracking branch 'origin/master' into azure_ro_mode
seiferteric Jun 9, 2020
c47035e
Merge remote-tracking branch 'origin/master' into azure_ro_mode
seiferteric Jun 12, 2020
07e9265
Merge remote-tracking branch 'origin/master' into azure_ro_mode
seiferteric Jun 17, 2020
b18cbd6
Remove line readded during merge
seiferteric Jun 17, 2020
6aa7ea1
Change SONIC_TELEMETRY_WRITABLE to TELEMETRY_WRITABLE
seiferteric Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile.work
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,7 @@ SONIC_BUILD_INSTRUCTION := make \
SONIC_ENABLE_SYSTEM_TELEMETRY=$(ENABLE_SYSTEM_TELEMETRY) \
SONIC_ENABLE_RESTAPI=$(ENABLE_RESTAPI) \
EXTRA_JESSIE_TARGETS=$(EXTRA_JESSIE_TARGETS) \
TELEMETRY_READONLY=$(TELEMETRY_READONLY) \
$(SONIC_OVERRIDE_BUILD_VARS)

.PHONY: sonic-slave-build sonic-slave-bash init reset
Expand Down
5 changes: 5 additions & 0 deletions build_debian.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,11 @@ if [ -f sonic_debian_extension.sh ]; then
./sonic_debian_extension.sh $FILESYSTEM_ROOT $PLATFORM_DIR
fi

## Enable read-only mode for telemetry if TELEMETRY_READONLY is set
if [ "${TELEMETRY_READONLY}" = "y" ]; then
sudo touch $FILESYSTEM_ROOT/etc/sonic/telemetry_readonly
fi

## Organization specific extensions such as Configuration & Scripts for features like AAA, ZTP...
if [ "${enable_organization_extensions}" = "y" ]; then
if [ -f files/build_templates/organization_extensions.sh ]; then
Expand Down
2 changes: 2 additions & 0 deletions slave.mk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ $(info "BLDENV" : "$(BLDENV)")
$(info "VS_PREPARE_MEM" : "$(VS_PREPARE_MEM)")
$(info "ENABLE_SFLOW" : "$(ENABLE_SFLOW)")
$(info "ENABLE_NAT" : "$(ENABLE_NAT)")
$(info "TELEMETRY_READONLY" : "$(TELEMETRY_READONLY)")
$(info )

ifeq ($(SONIC_USE_DOCKER_BUILDKIT),y)
Expand Down Expand Up @@ -726,6 +727,7 @@ $(addprefix $(TARGET_PATH)/, $(SONIC_INSTALLERS)) : $(TARGET_PATH)/% : \
DEBUG_SRC_ARCHIVE_FILE="$(DBG_SRC_ARCHIVE_FILE)" \
USERNAME="$(USERNAME)" \
PASSWORD="$(PASSWORD)" \
TELEMETRY_READONLY="$(TELEMETRY_READONLY)" \
./build_debian.sh $(LOG)

USERNAME="$(USERNAME)" \
Expand Down