Add TELEMETRY_WRITABLE build option to enable telemetry write mode (default read-only) by seiferteric · Pull Request #4209 · sonic-net/sonic-buildimage

seiferteric · 2020-02-28T23:26:47Z

Add build flag TELEMETRY_WRITABLE. When set to "y" it will add a go build flag in the telemetry build that will enable telemetry write mode to allow configuration via gNMI Set RPC as well as operations via the gNOI RPC's. The default for TELEMETRY_WRITABLE is unset in which case telemetry is read-only. In read-only mode the Set RPC and all gNOI RPC's are disabled and will return an "Unsupported" error when called.

msftclas · 2020-02-28T23:26:59Z

All CLA requirements met.

Makefile.work

renukamanavalan · 2020-03-04T17:26:14Z

As per comment in PR #27, please plan to configure rw mode of a path mounted into this docker, instead of a separate file.

Or you might play with some config file entry that is local to telemetry.

… read-only. Change mode to use go build flag instead of creating a file

seiferteric · 2020-03-10T20:45:41Z

The method has been changed to using a go build flag /constraint to set a constant in the telemetry binary.

Makefile.work

slave.mk

…DWRITE

renukamanavalan

Thank you!

lguohan · 2020-03-22T06:42:05Z

can you resolve the conflict?

seiferteric · 2020-03-22T15:27:40Z

can you resolve the conflict?

Okay, done.

Makefile.work

renukamanavalan · 2020-06-09T14:51:18Z

retest vsimage please

renukamanavalan · 2020-06-09T16:40:00Z

retest mellanox please

renukamanavalan · 2020-06-12T20:43:56Z

retest vsimage please

ben-gale · 2020-06-17T13:53:42Z

Can this one be merged now?

Makefile.work

renukamanavalan · 2020-06-18T14:35:10Z

The PR has changed a lot, that the original message in the PR "Add build flag TELEMETRY_READONLY ..." is no longer relevant. Can you please update ?

As part of that please add, who/how this flag is consumed, to toggle gNMI i/f between RO/RW during build time.

seiferteric · 2020-06-19T18:09:55Z

@renukamanavalan Okay I have updated the comment and title.

rules/config

renukamanavalan · 2020-06-23T23:02:16Z

retest mellanox please

seiferteric · 2020-06-24T16:14:16Z

retest mellanox please

@renukamanavalan What do you mean by retest mellanox?

renukamanavalan · 2020-06-24T16:26:57Z

retest xyz please -- will restart the xyz test.

mellanox failed previously, due to some unreachability issue. So I restarted it.

renukamanavalan · 2020-06-24T18:42:16Z

Aborted by Danny Allen; restarting vs test.

renukamanavalan · 2020-06-24T18:42:30Z

retest vsimage please.

renukamanavalan · 2020-06-24T18:42:44Z

retest vsimage please

Flag name changed to match buildimage change (sonic-net/sonic-buildimage#4209)

…atically (#25254) #### Why I did it src/sonic-utilities ``` * 20a7131b - (HEAD -> master, origin/master, origin/HEAD) clear: make --namespace optional for arp and ndp commands (#4355) (5 minutes ago) [Oleksandr Ivantsiv] * f56e4a78 - show version: replace --verbose with --brief flag (#4350) (20 hours ago) [Ashwin Srinivasan] * 5e50cf3d - Wait for monit monitor <service> operation to complete during config (#4295) (23 hours ago) [Hemanth Kumar Tirupati] * 0306ea20 - Change sensorshow conn to use TCP socket (#4343) (2 days ago) [Chenyang Wang] * cb5b3e82 - Fix route_check.py redis client memory usage (#4217) (2 days ago) [Roee Bar] * e93a5c3c - config: allow golden config to override mac, platform, asic_id (#4348) (2 days ago) [securely1g] * 0024c8d4 - Add non -B- hwsku names as well (#4331) (2 days ago) [dakotac-arista] * eb7301cc - Fix unit tests (#4345) (3 days ago) [william8545] * 052199c0 - [Arista] Add Arista-7050CX3-32C-C28S4 to generic_config_updater (#4257) (4 days ago) [byu343] * ed68290a - Add multi-ASIC namespace support for show/config subinterface(s) command (#4298) (4 days ago) [william8545] * 9c9f099d - New CLI proposal for PHY diagnostics (#4214) (4 days ago) [Prince George] * 9e3373df - Fix generate_dump to preserve per-ASIC subdirectory structure for sdk_dbg collection (#4334) (4 days ago) [william8545] * 3fe8972f - Add multi-ASIC namespace support for ARP/NDP show and clear commands (#4231) (4 days ago) [Oleksandr Ivantsiv] * be5fe2aa - Add multi-ASIC namespace support for VLAN and FDB operations (#4230) (4 days ago) [Oleksandr Ivantsiv] * e74fca78 - Add multi-ASIC namespace support for static route commands (#4269) (4 days ago) [Oleksandr Ivantsiv] * 599e7c71 - Add multi-ASIC namespace support for ACL table add/remove commands (#4270) (4 days ago) [Oleksandr Ivantsiv] * d09d6cd6 - Add CLI support for "show interfaces <intf> <phy-signal/phy-serdes>" commands (#4312) (4 days ago) [prajjwal-arista] * 345f5686 - Add multi-asic namespace support for IPv6 link-local commands (#4289) (4 days ago) [william8545] * edd4b190 - Add multi-asic namespace support for crm show resources command (#4290) (4 days ago) [william8545] * 2b52a051 - [multi-asic] Add namespace support for vxlan and vnet show/config commands (#4299) (4 days ago) [william8545] * 03160905 - [fast-reboot][cosmetic] Fixed debug/error prints with the correct reboot type (#4285) (4 days ago) [Yair Raviv] * 6eedf8a7 - [warm-reboot][multi-asic] Added error-handling for faulty ASIC/s after orchagent freeze (#4297) (4 days ago) [Yair Raviv] * 2330bab5 - [BMC] Add new BMC CLIs for manual session management and reset root password (#4238) (4 days ago) [Ben Levi] * 4d0cc933 - Fix issue: pmon services's restart count is not cleared during config reload (#4314) (4 days ago) [Stephen Sun] * 0a1bbc55 - Fix the generate_dump for BCM Asic Q3D (#4326) (6 days ago) [saksarav-nokia] * 1580ccce - GCU generates suboptimal plan for CreateOnly paths (#4335) (6 days ago) [Brad House - Nexthop] * 369e703e - GCU: Add path tracing support (#4317) (7 days ago) [Brad House - Nexthop] * bc05e1a4 - [GCU]: Restart telemetry container on port speed change via GCU to handle OID update (#4248) (7 days ago) [Xincun Li] * 73f1ea51 - Fix warning messages due to nose test deprecation (#4322) (8 days ago) [Brad House - Nexthop] * ebfefbd8 - [Arista] Add TH5 HWSKU to list for pfcwd support (#4329) (8 days ago) [dakotac-arista] * 0d969b85 - [DPU] Add support for HA Set Counters (#4283) (8 days ago) [Connor Roos] * 44f8c37b - [DPU] Add CLI to trigger and dump flows (#4278) (8 days ago) [Vivek] * 76bf567e - [show interfaces] "show interfaces flap" command does not support multi-ASIC platforms (#4316) (9 days ago) [pnakka28] * 2ec21e19 - Limit PFC WD Detection time to maximum value of 1000ms (#4306) (9 days ago) [Hemanth Kumar Tirupati] * 99b1b76a - Modified dualtor_neighbor_check to use mux neighbor_mode (#4227) (10 days ago) [manamand2020] * 5dfd11ed - Fix 'show version' KeyError when sonic_version.yml has missing fields (#4324) (10 days ago) [securely1g] * 4c77f9d4 - fix: skip PORT_INGRESS/EGRESS_MIRROR_CAPABLE check for ERSPAN mirror sessions (#4323) (11 days ago) [bingwang-ms] * d8d2a39e - fix scapy delayed import when we have large routes (#4315) (11 days ago) [Hemanth Kumar Tirupati] * c6601cda - [LACP retry-count] Syntax Fix for Trixie (#4274) (11 days ago) [Yair Raviv] * f54d0a7c - Add fsync to config save to persist config across power cycle (#4313) (11 days ago) [Jianyue Wu] * e5f77f61 - Fix unit test assertions broken by spelling typo PRs (#4321) (13 days ago) [rustiqly] * 7660b19f - Fix spelling typos in muxcable modules (#4259) (2 weeks ago) [rustiqly] * f7d820f3 - Fix spelling typos in config/main.py (#4261) (2 weeks ago) [rustiqly] * 244942bd - Fix spelling typos in scripts/ (#4262) (2 weeks ago) [rustiqly] * 89001b10 - Fix spelling typos in show/ and clear/ modules (#4263) (2 weeks ago) [rustiqly] * d6e646c2 - Fix spelling typos in config/config_mgmt.py (#4260) (2 weeks ago) [rustiqly] * e244129c - Fix spelling typos in config/nat.py (#4258) (2 weeks ago) [rustiqly] * 5a0c48f0 - In route_check.py, Convey the IJSON Backend using an env variable (#4294) (2 weeks ago) [venkit-nexthop] * e2712fc1 - Fix spelling typos across utilities_common, config plugins, and misc modules (#4264) (2 weeks ago) [rustiqly] * 4211edee - Fixed show vxlan remotemac ambiguity (#4121) (2 weeks ago) [Gnanapriya [Marvell]] * cfd23f97 - Add FEC histograms to generate_dump output (#4244) (2 weeks ago) [Fraser Gordon] * 8882a633 - [storm-control] Fixed show storm-control interface command display (#4122) (2 weeks ago) [Gnanapriya [Marvell]] * 7a1e656e - [fibshow]: Fix exception when blackhole routes are present (#4189) (2 weeks ago) [Ravi Minnikanti(Marvell)] * 2b3f14de - [marvell-teralynx] Enhance techsupport to include HWSKU configs (#4161) (3 weeks ago) [Naveen-Rampuram] * 9cb7b3e6 - Merge pull request #4275 from tirupatihemanth/fix_scapy_lagkeepalive (3 weeks ago) [Ying Xie] |\ | failure_prs.log skip_prs.log 7e54ddff - Fix delayed scapy import when we have a lot of routes (3 weeks ago) [Hemanth Kumar Tirupati] * | cbb31f0d - [multi-asic] fix utilities_common Db helper (#4273) (3 weeks ago) [Yakiv Huryk] * | f65ddfa2 - Prevent early exit of reboot status (#4282) (3 weeks ago) [Gagan Punathil Ellath] * | 14840074 - [fast-reboot] Remove teamsyncd timer override by fast-boot (#4233) (3 weeks ago) [Yair Raviv] * | a3085380 - [lag_keepalive] add `--namespace` option (#4194) (4 weeks ago) [Yair Raviv] * | abc8bba1 - [teamd_retry_count] Add support for --namespace parameter (#4195) (4 weeks ago) [Yair Raviv] * | c05d995c - [warm/fast-reboot] check per-ASIC FW upgrade status (#4196) (4 weeks ago) [Yair Raviv] * | 433d01c1 - [check_db_integrity] Add NETNS environment (#4197) (4 weeks ago) [Yair Raviv] * | 441595c7 - [centralize_database] Add --namespace option (#4198) (4 weeks ago) [Yair Raviv] * | 0f3b5291 - [multi-asic][warm-reboot] Support warm-reboot on Multi-ASIC systems (#4199) (4 weeks ago) [Yair Raviv] * | 28623ca9 - [multi-asic][warm_restart] add Multi-ASIC support for warm_restart commands (#4200) (4 weeks ago) [Yair Raviv] * | 3cd228af - Add filesystem sync after plugin installation (#4251) (4 weeks ago) [Jianyue Wu] * | 1d78c210 - Add .github/copilot-instructions.md for AI-assisted development (#4271) (4 weeks ago) [rustiqly] * | 7895da57 - Fix dump port state CLI command crash on multi-asic platforms (#4229) (4 weeks ago) [Setu Patel] |/ * bcb1d4bb - Clearing /tmp/tmp* is unsafe with parallel builds (#4268) (4 weeks ago) [Brad House - NextHop] * 8103627e - Fix sonic-utilities submodule update failure due to ijson library (#4256) (4 weeks ago) [venkit-nexthop] * 85becedc - [Mellanox] Add restricted sysfs to fw control list (#4240) (4 weeks ago) [Noa Or] * 275bdc6c - Add multi-asic support for sonic-clear queue wredcounters and counter poll , --nonzero support for show queue wredcounters (#4152) (5 weeks ago) [saksarav-nokia] * fbc85ee4 - Fix j2 files not getting packaged (#4250) (5 weeks ago) [Saikrishna Arcot] * a9543cba - Fix route_check.py to not hog a lot of memory (#4205) (5 weeks ago) [venkit-nexthop] * 40260d5b - Fix JsonMove._get_value to Support Both String and Integer List Indices (#4237) (5 weeks ago) [Xincun Li] * 0a3ef184 - refactor: enhance show bfd summary command (#4242) (5 weeks ago) [Chenyang Wang] * 7c6dfdc2 - Update the error message for sfputil debug loopback command (#4224) (5 weeks ago) [Ariz Zubair] * f246da25 - [Fast-linkup] Added CLIs for config/show (#4182) (6 weeks ago) [Yair Raviv] * 87703c1 - Use Singleton PlatformDataProvider to reduce module import time (#4183) (6 weeks ago) [Hemanth Kumar Tirupati] * 0dae5f2 - [sfputil] Fix issue: should not do low power mode or reset for non-present ports (#4206) (6 weeks ago) [Junchao-Mellanox] * 5f56518 - generate_dump: add interface FEC stats (#4093) (6 weeks ago) [Fraser Gordon] * 2e9e81c - [GCU] Update WRED_PROFILE and BUFFER_POOL validators for GCU (#4219) (6 weeks ago) [Dev Ojha] * 2350203 - Update bash completions for sonic-utilities commands (#4163) (6 weeks ago) [Saikrishna Arcot] * 5052e02 - Fix the PSU show command error message on platform without psu at all (#4151) (6 weeks ago) [Yuanzhe] * 7d9ec5d - Fix issue that namespace is not correctly fetched in Multi ASIC environment for mirror capability checking (#4159) (6 weeks ago) [Stephen Sun] * f473b4f - Fix multi asic initialization for dump command (#4108) (6 weeks ago) [Gagan Punathil Ellath] * 0f45e43 - Add current and configured frequency to DOM CLI (#4209) (7 weeks ago) [Ariz Zubair] * 6f0b181 - Added counterpoll CLI support (#4106) (7 weeks ago) [Dhanasekar Rathinavel] * 3d5bef9 - [multi-asic][Mellanox] Add multi-ASIC support for generate_dump and update FW upgrade script (#4192) (7 weeks ago) [Oleksandr Ivantsiv] * 8451f01 - sonic-utilities: Support for clearing aggregate VOQ counters(#2001) (#4044) (8 weeks ago) [manish1-arista] * 21f013f - Add q3d SKUs to gcu_field_operation_validators.conf.json (#4201) (8 weeks ago) [HP] * 1a15091 - Fix multi asic connection creation (#4109) (8 weeks ago) [Gagan Punathil Ellath] ``` #### How I did it #### How to verify it #### Description for the changelog

Add build option to make telemetry read-only

fb9036d

jeff-yin reviewed Feb 29, 2020

View reviewed changes

Makefile.work Outdated Show resolved Hide resolved

Fix indent

2a1e736

Change TELEMETRY_REAONLY to TELEMETRY_READWRITE since default will be…

8603815

… read-only. Change mode to use go build flag instead of creating a file

renukamanavalan reviewed Mar 10, 2020

View reviewed changes

Makefile.work Outdated Show resolved Hide resolved

renukamanavalan reviewed Mar 10, 2020

View reviewed changes

slave.mk Outdated Show resolved Hide resolved

Updated supported parameters and config/rules to include TELMETRY_REA…

762a5b8

…DWRITE

renukamanavalan previously approved these changes Mar 11, 2020

View reviewed changes

Merge remote-tracking branch 'azure/master' into azure_ro_mode

3cafe6d

seiferteric dismissed renukamanavalan’s stale review via 3cafe6d March 22, 2020 15:26

lguohan reviewed Mar 22, 2020

View reviewed changes

Makefile.work Outdated Show resolved Hide resolved

lguohan reviewed Mar 22, 2020

View reviewed changes

Makefile.work Outdated Show resolved Hide resolved

seiferteric added 4 commits March 23, 2020 09:14

Merge remote-tracking branch 'azure/master' into azure_ro_mode

5a6d462

Add SONIC preix to telemetry readonly flag

57c591b

Update rules/config with correct flag name

f514d09

Merge remote-tracking branch 'azure/master' into azure_ro_mode

42ff12c

jleveque suggested changes May 5, 2020

View reviewed changes

Makefile.work Outdated Show resolved Hide resolved

seiferteric added 2 commits June 2, 2020 14:32

Merge remote-tracking branch 'origin/master' into azure_ro_mode

4d70acd

Change SONIC_TELEMETRY_READWRITE flag to SONIC_TELEMETRY_WRITABLE

2c35081

seiferteric mentioned this pull request Jun 4, 2020

Azure ro mode sonic-net/sonic-telemetry#34

Merged

Merge remote-tracking branch 'origin/master' into azure_ro_mode

82a0255

Merge remote-tracking branch 'origin/master' into azure_ro_mode

c47035e

renukamanavalan reviewed Jun 17, 2020

View reviewed changes

Makefile.work Outdated Show resolved Hide resolved

seiferteric added 2 commits June 17, 2020 07:37

Merge remote-tracking branch 'origin/master' into azure_ro_mode

07e9265

Remove line readded during merge

b18cbd6

renukamanavalan self-assigned this Jun 17, 2020

seiferteric changed the title ~~Add build option to make telemetry read-only~~ Add SONIC_TELEMETRY_WRITABLE build option to enable telemetry write mode (default read-only) Jun 18, 2020

renukamanavalan requested a review from jleveque June 19, 2020 18:21

renukamanavalan previously approved these changes Jun 19, 2020

View reviewed changes

jleveque reviewed Jun 19, 2020

View reviewed changes

rules/config Outdated Show resolved Hide resolved

Change SONIC_TELEMETRY_WRITABLE to TELEMETRY_WRITABLE

6aa7ea1

seiferteric dismissed renukamanavalan’s stale review via 6aa7ea1 June 23, 2020 17:14

jleveque approved these changes Jun 23, 2020

View reviewed changes

jleveque changed the title ~~Add SONIC_TELEMETRY_WRITABLE build option to enable telemetry write mode (default read-only)~~ Add TELEMETRY_WRITABLE build option to enable telemetry write mode (default read-only) Jun 23, 2020

renukamanavalan approved these changes Jun 25, 2020

View reviewed changes

renukamanavalan merged commit de07029 into sonic-net:master Jun 25, 2020

renukamanavalan pushed a commit to sonic-net/sonic-telemetry that referenced this pull request Jun 29, 2020

Azure ro mode (#34)

e46cf04

Flag name changed to match buildimage change (sonic-net/sonic-buildimage#4209)

Conversation

seiferteric commented Feb 28, 2020 • edited by renukamanavalan Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

msftclas commented Feb 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

renukamanavalan commented Mar 4, 2020

Uh oh!

seiferteric commented Mar 10, 2020

Uh oh!

Uh oh!

Uh oh!

renukamanavalan left a comment

Choose a reason for hiding this comment

Uh oh!

lguohan commented Mar 22, 2020

Uh oh!

seiferteric commented Mar 22, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

renukamanavalan commented Jun 9, 2020

Uh oh!

renukamanavalan commented Jun 9, 2020

Uh oh!

renukamanavalan commented Jun 12, 2020

Uh oh!

ben-gale commented Jun 17, 2020

Uh oh!

Uh oh!

renukamanavalan commented Jun 18, 2020

Uh oh!

seiferteric commented Jun 19, 2020

Uh oh!

Uh oh!

renukamanavalan commented Jun 23, 2020

Uh oh!

seiferteric commented Jun 24, 2020

Uh oh!

renukamanavalan commented Jun 24, 2020

Uh oh!

renukamanavalan commented Jun 24, 2020

Uh oh!

renukamanavalan commented Jun 24, 2020

Uh oh!

renukamanavalan commented Jun 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

seiferteric commented Feb 28, 2020 •

edited by renukamanavalan

Loading

msftclas commented Feb 28, 2020 •

edited

Loading