[Services] Restart LLDP service upon unexpected critical process exit.#3713
Merged
jleveque merged 5 commits intosonic-net:masterfrom Nov 6, 2019
yozhao101:Restart_LLDP
Merged
[Services] Restart LLDP service upon unexpected critical process exit.#3713jleveque merged 5 commits intosonic-net:masterfrom yozhao101:Restart_LLDP
jleveque merged 5 commits intosonic-net:masterfrom
yozhao101:Restart_LLDP
Conversation
Signed-off-by: Yong Zhao <yozhao@microsoft.com>
supervisored conf file. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
processes file into dockerfile.j2. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
wants to restart this container more than 3 times in 20 minutes. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
shared Makefile docker-lldp-sv2.mk. Signed-off-by: Yong Zhao <yozhao@microsoft.com>
Contributor
|
Retest vs please |
lguohan
approved these changes
Nov 6, 2019
jleveque
approved these changes
Nov 6, 2019
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
sonic-net#3713) Signed-off-by: Yong Zhao <yozhao@microsoft.com>
praveen-li
pushed a commit
to praveen-li/sonic-buildimage
that referenced
this pull request
Feb 9, 2021
sonic-net#3713) Signed-off-by: Yong Zhao <yozhao@microsoft.com> RB=2124908 G=lnos-reviewers R=pchaudha,pmao,vapatil,zxu A=zxu
mssonicbld
added a commit
that referenced
this pull request
Mar 2, 2025
…atically (#21343) #### Why I did it src/sonic-utilities ``` * 899ed9b - (HEAD -> master, origin/master, origin/HEAD) Remove Multi ASIC namespace Check. (#3783) (3 days ago) [Xincun Li] * 9f1eab4 - Memory Statistics Config and Show Commands (#3575) (3 days ago) [Kanza Latif] * 595c2aa - Utilities Changes for DHCP DoS Mitigation Feature (#3301) (3 days ago) [Asad Raza] * a3d15bc - Add multi-asic support for dropconfig (#3735) (3 days ago) [HP] * 5ce06b2 - Add golden config check (#3770) (4 days ago) [Xincun Li] * 3c50dee - Fix `vnet_route_check` for active and inactive routes, add `--all` option (#3763) (9 days ago) [mramezani95] * 40ba225 - Revert "enable pfcwd for backplane ports (#3759)" (#3767) (13 days ago) [Dashuai Zhang] * 2866ccd - enable pfcwd for backplane ports (#3759) (2 weeks ago) [Dashuai Zhang] * 3abd19e - [FC] remove FC delay field (#3577) (3 weeks ago) [Stepan Blyshchak] * 11c2716 - Improve SONiC disk checker to handle disk full case and mount overlay fs to allow remote user login. (#3700) (3 weeks ago) [Hua Liu] * 13619aa - [QOS] Skip showing unnecessary warning message (#3708) (3 weeks ago) [Vivek] * f4e6e5b - Fixing 'show ip bgp neighbor <ip>' in frr unified config mode (#3738) (3 weeks ago) [kalash-nexthop] * 9a18155 - Optimize lag_keepalive by crafting the LACPDU packet ourselves (#3170) (3 weeks ago) [Saikrishna Arcot] * a7deb8c - display proper message with proper errno for kvm. (#3750) (3 weeks ago) [Dawei Huang] * 865f196 - [Mellanox] Add new SN5640 platform and HwSKU (#3742) (4 weeks ago) [Noa Or] * 5fa8502 - [show_techsupport][pstore] Archive /var/lib/systemd/pstore info to techsupport (#3745) (4 weeks ago) [Marty Y. Lok] * 8f69d5a - sonic-utilities: WRED stats feature changes on sonic-utilities (#2807) (4 weeks ago) [Rajesh Perumal R] * 9d273f1 - Fix call for spanning-tree commands in dump script (#3723) (4 weeks ago) [DavidZagury] * 6d95d9b - Make 'show ip bgp summary' work even when we don't have any peer groups (#3739) (4 weeks ago) [kalash-nexthop] * 7f3957c - Fix ssdhealth failure on VS platform (#3743) (4 weeks ago) [Vivek] * 97b4e4b - Fix show interface counters for Chassis Packet Supervisor (#3734) (4 weeks ago) [anamehra] * 414935b - Add recover asic_id config if load golden config. (#3711) (5 weeks ago) [Xincun Li] * 973cfdc - Remove partially installer image when image install failed. (#3712) (5 weeks ago) [Hua Liu] * 97c20cc - CLI support for SmartSwitch PMON (#3271) (5 weeks ago) [rameshraghupathy] * 752c3d4 - [ACL] Display rule and table info written to APP DB (#3713) (5 weeks ago) [Vivek] * fbd0c3b - [show][interface] Add changes for show interface flap command (#3724) (5 weeks ago) [vdahiya12] * ddccabe - [show][interface] Add changes for show interface errors command (#3721) (5 weeks ago) [vdahiya12] * be870a6 - [config] Exit with non-zero when qos reload fail (#3710) (6 weeks ago) [Jianyue Wu] * ffa66e9 - Remove debug dump import by default (#3715) (6 weeks ago) [Vivek] * fc3a3cb - [ssdhealth] Check for default device before falling back to discovery (#3693) (6 weeks ago) [Vivek] * 782c33a - [yang] Enforce yang full support in full config command (#3716) (6 weeks ago) [jingwenxie] * a5b7a90 - [show][interfaces] Add proposal for show interfaces flap (#3627) (6 weeks ago) [vdahiya12] * 0083a12 - sonic-utilities: add th5 hwskus to gcu conf file (#3714) (7 weeks ago) [Chris] * 81cf04f - [Mellanox] Add Mellanox-SN5610N-C256S2, Mellanox-SN5610N-C224O8 to GCU validators (#3658) (7 weeks ago) [noaOrMlnx] * 349a101 - [db_migrator] Migrate tunnel table (#3704) (7 weeks ago) [Longxiang Lyu] * 0e327c5 - show ip interfaces: fix exception with BGP unnumbered (#3695) (8 weeks ago) [Brad House] * 7100f73 - [show_tech] modify generate_dump to includes BERT data and also the platform specified hw-mgmt info (#3676) (8 weeks ago) [Marty Y. Lok] * 80d4698 - Delete TRSNCEIVER tables while config reload (#3680) (8 weeks ago) [noaOrMlnx] * bf6ff9f - Enable multi asic golden config YANG validation. (#3685) (8 weeks ago) [Xincun Li] ``` #### How I did it #### How to verify it #### Description for the changelog
miatttao
pushed a commit
to miatttao/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
…atically (sonic-net#21343) #### Why I did it src/sonic-utilities ``` * 899ed9b - (HEAD -> master, origin/master, origin/HEAD) Remove Multi ASIC namespace Check. (sonic-net#3783) (3 days ago) [Xincun Li] * 9f1eab4 - Memory Statistics Config and Show Commands (sonic-net#3575) (3 days ago) [Kanza Latif] * 595c2aa - Utilities Changes for DHCP DoS Mitigation Feature (sonic-net#3301) (3 days ago) [Asad Raza] * a3d15bc - Add multi-asic support for dropconfig (sonic-net#3735) (3 days ago) [HP] * 5ce06b2 - Add golden config check (sonic-net#3770) (4 days ago) [Xincun Li] * 3c50dee - Fix `vnet_route_check` for active and inactive routes, add `--all` option (sonic-net#3763) (9 days ago) [mramezani95] * 40ba225 - Revert "enable pfcwd for backplane ports (sonic-net#3759)" (sonic-net#3767) (13 days ago) [Dashuai Zhang] * 2866ccd - enable pfcwd for backplane ports (sonic-net#3759) (2 weeks ago) [Dashuai Zhang] * 3abd19e - [FC] remove FC delay field (sonic-net#3577) (3 weeks ago) [Stepan Blyshchak] * 11c2716 - Improve SONiC disk checker to handle disk full case and mount overlay fs to allow remote user login. (sonic-net#3700) (3 weeks ago) [Hua Liu] * 13619aa - [QOS] Skip showing unnecessary warning message (sonic-net#3708) (3 weeks ago) [Vivek] * f4e6e5b - Fixing 'show ip bgp neighbor <ip>' in frr unified config mode (sonic-net#3738) (3 weeks ago) [kalash-nexthop] * 9a18155 - Optimize lag_keepalive by crafting the LACPDU packet ourselves (sonic-net#3170) (3 weeks ago) [Saikrishna Arcot] * a7deb8c - display proper message with proper errno for kvm. (sonic-net#3750) (3 weeks ago) [Dawei Huang] * 865f196 - [Mellanox] Add new SN5640 platform and HwSKU (sonic-net#3742) (4 weeks ago) [Noa Or] * 5fa8502 - [show_techsupport][pstore] Archive /var/lib/systemd/pstore info to techsupport (sonic-net#3745) (4 weeks ago) [Marty Y. Lok] * 8f69d5a - sonic-utilities: WRED stats feature changes on sonic-utilities (sonic-net#2807) (4 weeks ago) [Rajesh Perumal R] * 9d273f1 - Fix call for spanning-tree commands in dump script (sonic-net#3723) (4 weeks ago) [DavidZagury] * 6d95d9b - Make 'show ip bgp summary' work even when we don't have any peer groups (sonic-net#3739) (4 weeks ago) [kalash-nexthop] * 7f3957c - Fix ssdhealth failure on VS platform (sonic-net#3743) (4 weeks ago) [Vivek] * 97b4e4b - Fix show interface counters for Chassis Packet Supervisor (sonic-net#3734) (4 weeks ago) [anamehra] * 414935b - Add recover asic_id config if load golden config. (sonic-net#3711) (5 weeks ago) [Xincun Li] * 973cfdc - Remove partially installer image when image install failed. (sonic-net#3712) (5 weeks ago) [Hua Liu] * 97c20cc - CLI support for SmartSwitch PMON (sonic-net#3271) (5 weeks ago) [rameshraghupathy] * 752c3d4 - [ACL] Display rule and table info written to APP DB (sonic-net#3713) (5 weeks ago) [Vivek] * fbd0c3b - [show][interface] Add changes for show interface flap command (sonic-net#3724) (5 weeks ago) [vdahiya12] * ddccabe - [show][interface] Add changes for show interface errors command (sonic-net#3721) (5 weeks ago) [vdahiya12] * be870a6 - [config] Exit with non-zero when qos reload fail (sonic-net#3710) (6 weeks ago) [Jianyue Wu] * ffa66e9 - Remove debug dump import by default (sonic-net#3715) (6 weeks ago) [Vivek] * fc3a3cb - [ssdhealth] Check for default device before falling back to discovery (sonic-net#3693) (6 weeks ago) [Vivek] * 782c33a - [yang] Enforce yang full support in full config command (sonic-net#3716) (6 weeks ago) [jingwenxie] * a5b7a90 - [show][interfaces] Add proposal for show interfaces flap (sonic-net#3627) (6 weeks ago) [vdahiya12] * 0083a12 - sonic-utilities: add th5 hwskus to gcu conf file (sonic-net#3714) (7 weeks ago) [Chris] * 81cf04f - [Mellanox] Add Mellanox-SN5610N-C256S2, Mellanox-SN5610N-C224O8 to GCU validators (sonic-net#3658) (7 weeks ago) [noaOrMlnx] * 349a101 - [db_migrator] Migrate tunnel table (sonic-net#3704) (7 weeks ago) [Longxiang Lyu] * 0e327c5 - show ip interfaces: fix exception with BGP unnumbered (sonic-net#3695) (8 weeks ago) [Brad House] * 7100f73 - [show_tech] modify generate_dump to includes BERT data and also the platform specified hw-mgmt info (sonic-net#3676) (8 weeks ago) [Marty Y. Lok] * 80d4698 - Delete TRSNCEIVER tables while config reload (sonic-net#3680) (8 weeks ago) [noaOrMlnx] * bf6ff9f - Enable multi asic golden config YANG validation. (sonic-net#3685) (8 weeks ago) [Xincun Li] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Jul 16, 2025
…lly (#23068) #### Why I did it src/sonic-swss ``` * 9d74a49 - (HEAD -> master, origin/master, origin/HEAD) [orchagent] CoPP neighbor miss trap and enhancements (#3624) (8 hours ago) [Ravi Minnikanti(Marvell)] * 41dc0cb - Improve route performance 20% by changing NextHopGroupTable from std::map to std::unordered_map. (#3742) (8 hours ago) [Hua Liu] * 27391fc - Publish oper_status time to STATE_DB (#3756) (29 hours ago) [Bobby McGonigle] * ad80fa5 - [trim]: Add Packet Trimming Asym DSCP to OA (#3705) (29 hours ago) [Nazarii Hnydyn] * dc520a7 - [ssw][ha] fix dpu_state_db connection issue and zmq not supporting dpu_appl_db (31 hours ago) [Jing Zhang] * 035e1c7 - Added MAX pre-FEC BER for link health monitoring (#3757) (33 hours ago) [Prince George] * 0c5a6e4 - Skip ref counting standby mux neighbor NHs when added to NH group (#3753) (33 hours ago) [manamand2020] * f53cc8c - [DASH] Implement PL Redirect Map (#3731) (35 hours ago) [Lawrence Lee] * c5c360e - Fix counter issue #22775 and #22478 (#3681) (4 days ago) [Stephen Sun] * bd73705 - [DASH] Support trusted VNIs for appliance and ENI objects (#3728) (4 days ago) [Lawrence Lee] * cea81b2 - stpd crashes due to wrong no.of stp instance passed from stpmgrd (#3752) (5 days ago) [Divya Kumaran Chandralekha] * af56a61 - Fix fpmsyncd crash during pfcwd/test_pfcwd_warm_reboot.py worm reboot issue (#3746) (5 days ago) [Hua Liu] * 80932db - use the exact strings from hld (#3735) (13 days ago) [Jing Zhang] * f44f6ab - [vs][mirror]: Update test to use the max TC number provided by VS lib (#3712) (2 weeks ago) [Nazarii Hnydyn] * 55e9bba - remove the logic that skip system neigh task for ASICs that share common hostname (#3718) (2 weeks ago) [Changrong Wu] * 3356753 - LC buffer errors for local port (#3719) (2 weeks ago) [Vineet Mittal] * bad2141 - Update INIT_VIEW timeout for marvell-prestera platforms (#3729) (2 weeks ago) [Pavan Prakash] * eebaf97 - [routeorch] Wait for the VRF to be created (#3652) (2 weeks ago) [Manoharan Sundaramoorthy] * 7dd3be9 - [fpmsyncd]Fixing the blackhole route removal during warmboot (#3726) (2 weeks ago) [Sudharsan Dhamal Gopalarathnam] * 575c342 - [routeorch] Handle SAI_STATUS_ITEM_NOT_FOUND when setting route entries (#3713) (3 weeks ago) [Nikola Dancejic] * 1ae6787 - [portsorch] postpone non-critical port init part in warm/fast-reboot (#3562) (3 weeks ago) [Stepan Blyshchak] * 889aff6 - add support for local endpoints in vnet_route_tunnel (#3651) (3 weeks ago) [Jing Zhang] * 1f97afb - [trim]: Add Packet Trimming to OA (#3594) (3 weeks ago) [Nazarii Hnydyn] * 8c2b337 - Gracefully handle errors when accessing dpu app_state DB on NPU from DPU (#3716) (3 weeks ago) [prabhataravind] * a0e1953 - Harden module build script by specifying the source version to get (#3723) (3 weeks ago) [Saikrishna Arcot] * 0081e3a - Improve route orch performance by enable ZMQ (#3632) (3 weeks ago) [Hua Liu] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Restart LLDP service if one of critical processes running in LLDP container exited or crashed abnormally.
How I did it
Generally I follow the framework created by Joe to implement this feature in LLDP container.
First, add supervisor-proc-exit-listener event listener option in Supervisord configuration file in LLDP docker container. Supervisord will read a list of critical processes for which to monitor the unexpected crashed and exited.
Second, configure LLDP.service to always auto-restart the service if it stops, with a delay of 30 seconds. Also set a rate limit of 3 restarts within 20 minutes (1200 seconds).
How to verify it
On your switch device, please use docker ps command to list all running docker containers.
Then use docker exec -it container_id bash to login target container. Typing top command
on the shell will display all the processes dynamically and you will spot the process id of one
of the critical processes. Finally type the command kill -9 process_id to terminate one process.
After exiting the container, you can use watch -n 1 docker ps to dynamically see the restart
of LLDP container.