[lldpd]: LLDP changing the tx-interval parameter is not reflected on the peer device immediately#3705
Merged
lguohan merged 1 commit intosonic-net:masterfrom Nov 9, 2019
Merged
Conversation
on the peer device immediately
lguohan
reviewed
Nov 5, 2019
| index 8382d02..38cf3f3 100644 | ||
| --- a/src/daemon/client.c | ||
| +++ b/src/daemon/client.c | ||
| @@ -71,7 +71,6 @@ client_handle_set_configuration(struct lldpd *cfg, enum hmsg_type *type, |
Collaborator
There was a problem hiding this comment.
can you add description in the patch itself?
lguohan
reviewed
Nov 5, 2019
| # This series applies on GIT commit 396961a038a38675d46f96eaa7b430b2a1f8701b | ||
| 0001-return-error-when-port-does-not-exist.patch | ||
| 0002-Let-linux-kernel-to-find-appropriate-nl_pid-automa.patch | ||
| 0003-update-tx-interval-immediately.patch |
Collaborator
There was a problem hiding this comment.
can you upstream this patch?
Contributor
Author
There was a problem hiding this comment.
You mean upstream to https://github.com/vincentbernat/lldpd ?
sandeep-kulambi
changed the title
Contributor
Author
|
Thanks, I see this is fixed in LLDP community - sandeep-kulambi/lldpd@d43d79d#diff-85dc6955b820c3aa562b66089fe99d29
Would like to know how to move forward - will SONiC move to the latest LLDP code base or we want to proceed with this PR ?
Thanks,
Sandeep
|
Collaborator
|
@pavel-shirshov , what is your suggestion? |
Contributor
|
@lguohan I'd merge this patch for now. |
pavel-shirshov
approved these changes
Nov 7, 2019
zhenggen-xu
pushed a commit
to zhenggen-xu/sonic-buildimage
that referenced
this pull request
Jan 10, 2020
…is modified. (sonic-net#3705) When LLDP parameter tx-interval value is modified, there was no immediate PDU sent to peer to update the peer with the latest values. Due to this the update on peer happened only after the next PDU is sent which can cause a delay of upto 30 secs (default value).
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Feb 27, 2025
…atically (sonic-net#515) #### Why I did it src/sonic-utilities ``` * 30f6255e - (HEAD -> 202405, origin/202405) Merge pull request sonic-net#104 from mssonicbld/sonicbld/202405-merge (23 hours ago) [mssonicbld] * bfb8c946 - Merge branch '202405' of https://github.com/sonic-net/sonic-utilities into 202405 (23 hours ago) [Sonic Automation] * 6a959e68 - [202405][db_migrator] Migrate tunnel table (sonic-net#3705) (32 hours ago) [Longxiang Lyu] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Jul 16, 2025
…lly (#23068) #### Why I did it src/sonic-swss ``` * 9d74a494 - (HEAD -> master, origin/master, origin/HEAD) [orchagent] CoPP neighbor miss trap and enhancements (#3624) (8 hours ago) [Ravi Minnikanti(Marvell)] * 41dc0cbc - Improve route performance 20% by changing NextHopGroupTable from std::map to std::unordered_map. (#3742) (8 hours ago) [Hua Liu] * 27391fcf - Publish oper_status time to STATE_DB (#3756) (29 hours ago) [Bobby McGonigle] * ad80fa5c - [trim]: Add Packet Trimming Asym DSCP to OA (#3705) (29 hours ago) [Nazarii Hnydyn] * dc520a78 - [ssw][ha] fix dpu_state_db connection issue and zmq not supporting dpu_appl_db (31 hours ago) [Jing Zhang] * 035e1c7a - Added MAX pre-FEC BER for link health monitoring (#3757) (33 hours ago) [Prince George] * 0c5a6e43 - Skip ref counting standby mux neighbor NHs when added to NH group (#3753) (33 hours ago) [manamand2020] * f53cc8cd - [DASH] Implement PL Redirect Map (#3731) (35 hours ago) [Lawrence Lee] * c5c360e9 - Fix counter issue #22775 and #22478 (#3681) (4 days ago) [Stephen Sun] * bd737056 - [DASH] Support trusted VNIs for appliance and ENI objects (#3728) (4 days ago) [Lawrence Lee] * cea81b2e - stpd crashes due to wrong no.of stp instance passed from stpmgrd (#3752) (5 days ago) [Divya Kumaran Chandralekha] * af56a611 - Fix fpmsyncd crash during pfcwd/test_pfcwd_warm_reboot.py worm reboot issue (#3746) (5 days ago) [Hua Liu] * 80932db9 - use the exact strings from hld (#3735) (13 days ago) [Jing Zhang] * f44f6ab6 - [vs][mirror]: Update test to use the max TC number provided by VS lib (#3712) (2 weeks ago) [Nazarii Hnydyn] * 55e9bba7 - remove the logic that skip system neigh task for ASICs that share common hostname (#3718) (2 weeks ago) [Changrong Wu] * 33567531 - LC buffer errors for local port (#3719) (2 weeks ago) [Vineet Mittal] * bad21415 - Update INIT_VIEW timeout for marvell-prestera platforms (#3729) (2 weeks ago) [Pavan Prakash] * eebaf97e - [routeorch] Wait for the VRF to be created (#3652) (2 weeks ago) [Manoharan Sundaramoorthy] * 7dd3be98 - [fpmsyncd]Fixing the blackhole route removal during warmboot (#3726) (2 weeks ago) [Sudharsan Dhamal Gopalarathnam] * 575c3427 - [routeorch] Handle SAI_STATUS_ITEM_NOT_FOUND when setting route entries (#3713) (3 weeks ago) [Nikola Dancejic] * 1ae67874 - [portsorch] postpone non-critical port init part in warm/fast-reboot (#3562) (3 weeks ago) [Stepan Blyshchak] * 889aff63 - add support for local endpoints in vnet_route_tunnel (#3651) (3 weeks ago) [Jing Zhang] * 1f97afb3 - [trim]: Add Packet Trimming to OA (#3594) (3 weeks ago) [Nazarii Hnydyn] * 8c2b3379 - Gracefully handle errors when accessing dpu app_state DB on NPU from DPU (#3716) (3 weeks ago) [prabhataravind] * a0e19532 - Harden module build script by specifying the source version to get (#3723) (3 weeks ago) [Saikrishna Arcot] * 0081e3ae - Improve route orch performance by enable ZMQ (#3632) (3 weeks ago) [Hua Liu] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
When LLDP parameter tx-interval value is modified, there was no immediate PDU sent to peer to update the peer with the latest values. Due to this the update on peer happened only after the next PDU is sent which can cause a delay of upto 30 secs (default value).
- How I did it
The fix is to ensure the LLDP PDU is sent immediately when the tx-interval configuration is modified.
- How to verify it
Modify LLDP tx-interval on one side and check the "show lldp neighbor" output on the peer device to see if its updated immediately
- Description for the changelog