Automatic fw upgrade for mlnx platform (#18)#31
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Oct 18, 2016
marian-pritsak:master
Merged
Automatic fw upgrade for mlnx platform (#18)#31qiluo-msft merged 2 commits intosonic-net:masterfrom marian-pritsak:master
qiluo-msft merged 2 commits intosonic-net:masterfrom
marian-pritsak:master
Conversation
Implement script for firmware upgrade to required version Add firmware binary and script to ops-syncd-mlnx container Add pciutils and usbutils to sonic-generic.bin Signed-off-by: marian-pritsak <marianp@mellanox.com>
Collaborator
|
Why including firmware upgrade into syncd docker? Is it one-time thing? |
lguohan
reviewed
Oct 13, 2016
| i2c-tools \ | ||
| efibootmgr | ||
| efibootmgr \ | ||
| usbutils \ |
Collaborator
There was a problem hiding this comment.
which component requires this usbutils?
Collaborator
Author
There was a problem hiding this comment.
mst utility uses usbutils and pciutils to talk to detect ASIC device
|
|
||
| # fw-upgrade will exit if firmware was actually upgraded or if some error | ||
| # occures | ||
| . mlnx-fw-upgrade.sh |
Collaborator
There was a problem hiding this comment.
after upgrading the fw, do we need to restart the sxd kernel driver?
Collaborator
Author
There was a problem hiding this comment.
Yes, we need to restart sxd kernel in order to run newly burned firmware
Contributor
There was a problem hiding this comment.
Then it is needed to add restart sxdkernel driver logic?
Collaborator
Author
There was a problem hiding this comment.
Yes, correct
If firmware is actually updated, mlnx-fw-upgrade.sh will exit, causing syncd service to restart
Collaborator
There was a problem hiding this comment.
It is actually a trick to exit directly from mlnx-fw-upgrade.sh. Please add your comment as code comment.
BTW, syncd service to restart == restart sxdkernel driver?
Contributor
There was a problem hiding this comment.
@qiluo-msft yes. restart syncd service will restart sxdkernel driver
Collaborator
Author
There was a problem hiding this comment.
It is actually a trick to exit directly from mlnx-fw-upgrade.sh. Please add your comment as code comment.
There is a comment in start.sh line 11 and mlnx-fw-upgrade.sh line 51 regarding restart logic. Anything else needed?
Collaborator
Author
|
As MLNX SDK is shipped with syncd docker, firmware upgrade utility is also going to be a part of it, so that in case of rolling out a new version of SDK, a compatible version of firmware will be installed. During syncd start firmware version is verified to be compatible with SDK shipped with current syncd, and if not - upgrade procedure is initiated. Its a one time action, which happens only when new SDK is available in syncd. |
qiluo-msft
requested changes
Oct 17, 2016
|
|
||
| # fw-upgrade will exit if firmware was actually upgraded or if some error | ||
| # occures | ||
| . mlnx-fw-upgrade.sh |
Collaborator
There was a problem hiding this comment.
It is actually a trick to exit directly from mlnx-fw-upgrade.sh. Please add your comment as code comment.
BTW, syncd service to restart == restart sxdkernel driver?
| if [[ ${required_fw_version} == ${fw_version} ]]; then | ||
| echo "Mellanox firmware is up to date." | ||
| else | ||
| echo "Mellanox firmware required version is ${required_fw_version}. Upgrading..." |
Collaborator
There was a problem hiding this comment.
Downgrading is also possible here. Is it safe to downgrade? Maybe you can refine the message.
It is possible to do both upgrade and downgrade Change "Upgrading" to "Installing compatible version"
lguohan
approved these changes
Oct 18, 2016
qiluo-msft
approved these changes
Oct 18, 2016
stcheng
pushed a commit
that referenced
this pull request
Oct 18, 2016
* Automatic fw upgrade for mlnx platform Implement script for firmware upgrade to required version Add firmware binary and script to ops-syncd-mlnx container Add pciutils and usbutils to sonic-generic.bin * Update firmware installation message It is possible to do both upgrade and downgrade Change "Upgrading" to "Installing compatible version" Signed-off-by: marian-pritsak <marianp@mellanox.com>
stcheng
pushed a commit
that referenced
this pull request
Mar 22, 2017
* Automatic fw upgrade for mlnx platform Implement script for firmware upgrade to required version Add firmware binary and script to ops-syncd-mlnx container Add pciutils and usbutils to sonic-generic.bin * Update firmware installation message It is possible to do both upgrade and downgrade Change "Upgrading" to "Installing compatible version" Signed-off-by: marian-pritsak <marianp@mellanox.com>
Kalimuthu-Velappan
pushed a commit
to Kalimuthu-Velappan/sonic-buildimage
that referenced
this pull request
Sep 12, 2019
Signed-off-by: Sihui Han <sihan@microsoft.com>
vasant17
pushed a commit
to vasant17/sonic-buildimage
that referenced
this pull request
Jan 23, 2020
Signed-off-by: Praveen Chaudhary pchaudhary@linkedin.com
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
3 tasks
dflynn-Nokia
added a commit
to dflynn-Nokia/sonic-buildimage
that referenced
this pull request
Dec 4, 2020
This update brings in the following commits. 86c1108 Enable arm architecture to build in addition to amd64 (sonic-net#37) 4acb2c3 fix bugs and enhance Transformer (sonic-net#35) 49e5a22 ygot related enhancements and fixes (sonic-net#34) 51224de Fix ietf yang search path for cvl schema builds (sonic-net#32) 3c6cdb3 CVL Changes sonic-net#8: 'must' and 'when' expression evaluation (sonic-net#31) dabf231 CVL Changes sonic-net#7: 'leafref' evaluation (sonic-net#28) 6f9535f CVL Changes sonic-net#6: Customized Xpath Engine integration (sonic-net#27) 5e2466b DB-Layer fixes/enhancements (sonic-net#26) 9a27302 CVL Changes sonic-net#4: Implementation of new CVL APIs (sonic-net#22) dbf1093 Translib support for authorization, yang versioning and Delete flag (sonic-net#21) 80f369e CVL Changes sonic-net#5: YParser enhancement (sonic-net#23) 904ce18 CVL Changes sonic-net#3: Multi-db instance support (sonic-net#20) 9d24a34 CVL Changes sonic-net#2: YValidator infra changes for evaluating xpath expression (sonic-net#19) f3fc40f CVL Changes sonic-net#1: Initial CVL code reorganization and common infra changes (sonic-net#18) 4922601 Bulk and RPC API support in translib (sonic-net#16) 1d730df RFC7895 yang module library implementation (sonic-net#15)
3 tasks
lguohan
pushed a commit
that referenced
this pull request
Dec 8, 2020
This update brings in the following commits. 86c1108 Enable arm architecture to build in addition to amd64 (#37) 4acb2c3 fix bugs and enhance Transformer (#35) 49e5a22 ygot related enhancements and fixes (#34) 51224de Fix ietf yang search path for cvl schema builds (#32) 3c6cdb3 CVL Changes #8: 'must' and 'when' expression evaluation (#31) dabf231 CVL Changes #7: 'leafref' evaluation (#28) 6f9535f CVL Changes #6: Customized Xpath Engine integration (#27) 5e2466b DB-Layer fixes/enhancements (#26) 9a27302 CVL Changes #4: Implementation of new CVL APIs (#22) dbf1093 Translib support for authorization, yang versioning and Delete flag (#21) 80f369e CVL Changes #5: YParser enhancement (#23) 904ce18 CVL Changes #3: Multi-db instance support (#20) 9d24a34 CVL Changes #2: YValidator infra changes for evaluating xpath expression (#19) f3fc40f CVL Changes #1: Initial CVL code reorganization and common infra changes (#18) 4922601 Bulk and RPC API support in translib (#16) 1d730df RFC7895 yang module library implementation (#15)
xumia
referenced
this pull request
in xumia/sonic-buildimage-1
Feb 16, 2021
Signed-off-by: Shu0T1an ChenG <shuche@microsoft.com>
SuvarnaMeenakshi
pushed a commit
to SuvarnaMeenakshi/sonic-buildimage
that referenced
this pull request
Jun 16, 2021
SuvarnaMeenakshi
pushed a commit
to SuvarnaMeenakshi/sonic-buildimage
that referenced
this pull request
Mar 16, 2022
* Exclude non front panel interfaces from nexthop * Fix non front panel interface matching * Fix wrong operators
6 tasks
lguohan
pushed a commit
that referenced
this pull request
Mar 18, 2022
f00efef Longxiang Lyu Wed Mar 16 09:12:46 2022 +0800 Add a command line option to store logs into a separate file (#41) ff2e67d Longxiang Lyu Tue Mar 15 09:10:59 2022 +0800 Add default port cable type (#39) ebbb4d8 Jing Zhang Mon Mar 14 15:41:11 2022 -0700 Prevent switching MUX to "Unknown" (#36) c779b8f Longxiang Lyu Thu Mar 10 21:35:11 2022 +0800 [nonfunctional] Use LinkProberStateMachineBase (#38) b9fedd0 Longxiang Lyu Wed Mar 9 13:03:58 2022 +0800 [NONFUNCTIONAL] Add LinkProberStateMachineBase (#37) bedd42b Longxiang Lyu Wed Mar 9 10:03:00 2022 +0800 Add .clang-format file to format code (#28) 9fe4fc6 Guohan Lu Thu Mar 3 17:51:43 2022 -0800 [doc]: add lgtm badge in README.md c1249d9 Longxiang Lyu Wed Mar 2 18:05:18 2022 +0800 Enable lgtm (#33) b8514c6 Longxiang Lyu Wed Mar 2 13:34:39 2022 +0800 Collect port cable type to use corresponding state machine (#31) 9b59ef9 Longxiang Lyu Wed Mar 2 07:19:33 2022 +0800 Improve make clean (#32)
prgeor
pushed a commit
that referenced
this pull request
Sep 29, 2022
* [BFN] Canceling PSU platform API calls on SIGTERM Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> * [BFN] Fixed SONiC fwutil exec time (#31) Signed-off-by: Taras Keryk <tarasx.keryk@intel.com> Signed-off-by: Andriy Kokhan <andriyx.kokhan@intel.com> Signed-off-by: Taras Keryk <tarasx.keryk@intel.com> Co-authored-by: Taras Keryk <tarasx.keryk@intel.com>
zbud-msft
added a commit
to zbud-msft/sonic-buildimage
that referenced
this pull request
Oct 6, 2022
8 tasks
yxieca
pushed a commit
that referenced
this pull request
Feb 6, 2023
Why I did it Advance sonic-dhcp-relay submodule head on 202012 branch How I did it Added the following commits: a4b15d8 jcaiMR Thu Dec 29 14:18:28 2022 +0800 fix relay-reply dhcpv6 packet counter issue (#29) 677543f jcaiMR Sat Dec 17 00:24:32 2022 +0800 fix handleSwssNotification crash in dhcp6relay (#28) ed86546 jcaiMR Wed Dec 14 14:08:58 2022 +0800 Fix multiple vlan issue (#27) 5ec1f5b Vivek Thu Dec 8 09:44:15 2022 -0800 Made the Error log informative (#22) 063d41b jcaiMR Wed Nov 30 14:41:53 2022 +0800 disable cfg dynamic change (#25) d4a51f6 kellyyeh Tue Jan 31 18:09:08 2023 -0800 Add unittest infrastructure (#5) (#31) How to verify it Ran full dhcpv6 test suite on lab device
Gokulnath-Raja
pushed a commit
to Gokulnath-Raja/sonic-buildimage-work
that referenced
this pull request
May 22, 2023
…ic-net#31) Adding support for evaluating 'must' and 'when' expression based on customized xpath engine.
shanshri
pushed a commit
to shanshri/sonic-buildimage-sonic-net
that referenced
this pull request
Oct 24, 2023
speed up kernel compile. - DO_DOCS=False do not skip generate document package on 4.19, use DEB_BUILD_PROFILES=nodoc instead. - use arch_amd64_none_amd64 to build the amd64 kernel package, avoid generating cloud-amd64 package. As a result, jenkins pipeline linux-kernel-buster-build-pr job sonic-net#31 takes 1h 6min, compare to sonic-net#30 takes 1h 24min. Co-authored-by: taocy <taocy2@centecnetworks.com>
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
[code sync] Merge code from sonic-net/sonic-buildimage:202205 to 202205
mlok-nokia
pushed a commit
to mlok-nokia/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
…ic-utilities [submodule][202205] Update submodule sonic-utilities to the latest HEAD automatically * c4dcb32 - (HEAD -> 202205, origin/202205) Merge pull request sonic-net#31 from mssonicbld/sonicbld/202205-merge (3 days ago) [mssonicbld] * bb5123d - Merge branch '202205' of https://github.com/sonic-net/sonic-utilities into 202205 (3 days ago) [Sonic Automation] * ff8a064 - [202205][acl-loader] Identity ICMP v4/v6 based on IP_PROTOCOL for custom ACL table types (sonic-net#3003) (3 days ago) [Zhijian Li]
mssonicbld
added a commit
that referenced
this pull request
Feb 19, 2025
…#21792) #### Why I did it src/dhcpmon ``` * 8fface8 - (HEAD -> 202405, origin/202405) Merge pull request #33 from yaqiangz/202405_dhcpmon_bootp (2 minutes ago) [bingwang-ms] * 5c98fd5 - Fix counting bootp packets by mistake (#31) (10 hours ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Feb 20, 2025
…#21799) #### Why I did it src/dhcpmon ``` * 4ea0936 - (HEAD -> 202311, origin/202311) Merge pull request #32 from yaqiangz/202311_dhcpmon_bootp (9 hours ago) [Ying Xie] * 936cb42 - Fix counting bootp packets by mistake (#31) (20 hours ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Feb 22, 2025
…#21818) #### Why I did it src/dhcpmon ``` * 2519a88 - (HEAD -> 202411, origin/202411) Merge pull request #34 from yaqiangz/202411_dhcpmon_bootp (2 days ago) [Kumaresh Perumal] * 3e58f23 - Fix counting bootp packets by mistake (#31) (3 days ago) [Yaqiang Zhu] ``` #### How I did it #### How to verify it #### Description for the changelog
Gfrom2016
pushed a commit
to Gfrom2016/sonic-buildimage
that referenced
this pull request
Apr 5, 2025
…tomatically (sonic-net#827) #### Why I did it src/sonic-linux-kernel ``` * ad3a9e0 - (HEAD -> 202412, origin/HEAD, origin/202412) [code sync] Merge code from sonic-net/sonic-linux-kernel:202411 to 202412 (sonic-net#31) (23 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
Gfrom2016
pushed a commit
to Gfrom2016/sonic-buildimage
that referenced
this pull request
Apr 5, 2025
…omatically (sonic-net#844) #### Why I did it src/sonic-swss-common ``` * bdc743f - (HEAD -> 202412, origin/HEAD, origin/202412) [FC] remove FLEX_COUNTER_DELAY_STATUS_FIELD (sonic-net#982) (sonic-net#31) (21 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
9 tasks
9 tasks
yejianquan
pushed a commit
that referenced
this pull request
Jul 31, 2025
Why I did it Cherry-pick PR #22849 to update the Nokia PMON submodule Update Nokia sonic-platform submodule which includes the commits in branch 202405 and 202503. Include commits: 05abbf6 [IXR7220-D4] Add port leds functionality d4f4e4d Update Fan Drawer index in cpld and fix fan target speed 4800083 [mackinac] warnings in general build c5b3a14 [mackinac] adding prom programming spidev; incidental c++ changes without functional impact fb37c5a [mackinac] working drivers, pcon, sets devices 0c56adf [x3b]Change access permissions for syseeprom 30cbed3 Using PcieUtil utility to check PCIE status 2b41e41 [x1b] modprobe.d/cpuctl.conf f234d5a [x3b] wait for pcon driver sysfs ready 054d682 [x3b]Fix PSU status check issue (#31) f6cb50e [X1b] Add support for Nokia X1b platform (#30) 921f9dd Adds CI to build the debian (#29) 7728ef2 [x4][x1b] consolidating shared cpuctl.ko source code from working x3b version 9f73cf4 Fix the reboot-cause fro upgrading from MFG image 7e057f9 [x3b]Update PSU code to adapt the I2C driver modification c64aba4 Fixed Watchdog and Others reboot-cause 39215bf moving platform_init script output into journal/syslog 4755411 [x3b] combined write/read 3a13b63 Adding bridge code for x3b x1b x4 53a0696 [x3b]Update fan module and thermal algorithm 8052488 [x3b] adds spi bus 0aac79f [x3b]Fix and update fan and thermal modules 169e0d8 Fix reboot-cause for Kernel Panic when kudmp is enabled dd003e1 [IXR7220-D4] FW Upgrades Support e143b5f Revert "Reduce traffic loss when the IMM reboots ungracefully" f7eec2c Revert "Add dependency for IMM ungracefyl reboot service" b345006 [Chassis] Conditionalize stuffing QFPGA into reset based on kernel AER setting 4652166 [Chassis] Delete FP ports shutdown at LC ungraceful reset time Work item tracking Microsoft ADO (number only): How I did it Update Nokia sonic-platform submodule which includes the commits in branch 202405 and 202503. Include commits: 05abbf6 [IXR7220-D4] Add port leds functionality d4f4e4d Update Fan Drawer index in cpld and fix fan target speed 4800083 [mackinac] warnings in general build c5b3a14 [mackinac] adding prom programming spidev; incidental c++ changes without functional impact fb37c5a [mackinac] working drivers, pcon, sets devices 0c56adf [x3b]Change access permissions for syseeprom 30cbed3 Using PcieUtil utility to check PCIE status 2b41e41 [x1b] modprobe.d/cpuctl.conf f234d5a [x3b] wait for pcon driver sysfs ready 054d682 [x3b]Fix PSU status check issue (#31) f6cb50e [X1b] Add support for Nokia X1b platform (#30) 921f9dd Adds CI to build the debian (#29) 7728ef2 [x4][x1b] consolidating shared cpuctl.ko source code from working x3b version 9f73cf4 Fix the reboot-cause fro upgrading from MFG image 7e057f9 [x3b]Update PSU code to adapt the I2C driver modification c64aba4 Fixed Watchdog and Others reboot-cause 39215bf moving platform_init script output into journal/syslog 4755411 [x3b] combined write/read 3a13b63 Adding bridge code for x3b x1b x4 53a0696 [x3b]Update fan module and thermal algorithm 8052488 [x3b] adds spi bus 0aac79f [x3b]Fix and update fan and thermal modules 169e0d8 Fix reboot-cause for Kernel Panic when kudmp is enabled dd003e1 [IXR7220-D4] FW Upgrades Support e143b5f Revert "Reduce traffic loss when the IMM reboots ungracefully" f7eec2c Revert "Add dependency for IMM ungracefyl reboot service" b345006 [Chassis] Conditionalize stuffing QFPGA into reset based on kernel AER setting 4652166 [Chassis] Delete FP ports shutdown at LC ungraceful reset time Signed-off-by: mlok <marty.lok@nokia.com>
nate-nexthop
pushed a commit
to nate-nexthop/sonic-buildimage
that referenced
this pull request
Sep 17, 2025
vmittal-msft
pushed a commit
to vmittal-msft/sonic-buildimage
that referenced
this pull request
Oct 20, 2025
commit: 6b7fc50 [x3b]Fix PSU status check issue (sonic-net#31) 4a46d61 [x3b] wait for pcon driver sysfs ready Signed-off-by: mlok <marty.lok@nokia.com>
vmittal-msft
pushed a commit
to vmittal-msft/sonic-buildimage
that referenced
this pull request
Oct 20, 2025
…onic-net#1207) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md ** Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it Update sonic-platform submodule for Nokia-IXR7250-X3B Includes commits: 4a46d61 [x3b] wait for pcon driver sysfs ready 6b7fc50 [x3b]Fix PSU status check issue (sonic-net#31) ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Update sonic-platform submodule for Nokia-IXR7250-X3B Includes commit: 4a46d61 [x3b] wait for pcon driver sysfs ready 6b7fc50 [x3b]Fix PSU status check issue (sonic-net#31) #### How to verify it Show platform psustatus should output the correct info <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
mssonicbld
added a commit
that referenced
this pull request
Feb 15, 2026
…ly (#25511) #### Why I did it src/sonic-bmp ``` * c4eeaeb - (HEAD -> master, origin/master, origin/HEAD) Merge pull request #31 from rustiqly/add-copilot-instructions (7 hours ago) [Lihua Yuan] * 95dcd1e - Add .github/copilot-instructions.md for AI-assisted development (4 days ago) [Rustiqly] ``` #### How I did it #### How to verify it #### Description for the changelog
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…ly (sonic-net#25511) #### Why I did it src/sonic-bmp ``` * c4eeaeb - (HEAD -> master, origin/master, origin/HEAD) Merge pull request sonic-net#31 from rustiqly/add-copilot-instructions (7 hours ago) [Lihua Yuan] * 95dcd1e - Add .github/copilot-instructions.md for AI-assisted development (4 days ago) [Rustiqly] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: Feng Pan <fenpan@microsoft.com>
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
…ly (#25511) #### Why I did it src/sonic-bmp ``` * c4eeaeb - (HEAD -> master, origin/master, origin/HEAD) Merge pull request #31 from rustiqly/add-copilot-instructions (7 hours ago) [Lihua Yuan] * 95dcd1e - Add .github/copilot-instructions.md for AI-assisted development (4 days ago) [Rustiqly] ``` #### How I did it #### How to verify it #### Description for the changelog Signed-off-by: dprital <drorp@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement script for firmware upgrade to required version
Add firmware binary and script to ops-syncd-mlnx container
Add pciutils and usbutils to sonic-generic.bin
Signed-off-by: marian-pritsak marianp@mellanox.com