Skip to content

Update README.md#3

Closed
amybuck wants to merge 1 commit intosonic-net:masterfrom
amybuck:patch-3
Closed

Update README.md#3
amybuck wants to merge 1 commit intosonic-net:masterfrom
amybuck:patch-3

Conversation

@amybuck
Copy link

@amybuck amybuck commented Aug 3, 2016

Added space after 1.

@amybuck
Update README.md
28681fd 
Added space after 1.
@stcheng stcheng closed this Oct 12, 2016
@pollyhsu2git pollyhsu2git mentioned this pull request Nov 21, 2017
Closed
qiluo-msft added a commit that referenced this pull request Jan 31, 2018
@qiluo-msft
Upgrade linux-image version (#1294)
358949b 
* Upgrade linux-image version
* Add missing dependency of igb
* Fix mft build rule
* Add missing dependency of ixgbe
* [Broadcom]: Update OpenNSL modules to be compatible with kernel 3.16.0-5 (#3)
* [Nephos] Update SDK version to support new kernel module 3.16.0-5 (#4)
* [mellanox]: Update URL for SDK (#5)
Staphylo pushed a commit to Staphylo/sonic-buildimage that referenced this pull request Feb 15, 2018
@marian-pritsak @lguohan
[Mellanox]: Upgrade MFT package to 4.8.26 (sonic-net#3)
ae5f8d5 
This version is compatible with Linux kernel 4.9

Signed-off-by: marian-pritsak <[email protected]>
Staphylo pushed a commit to Staphylo/sonic-buildimage that referenced this pull request Mar 6, 2018
@marian-pritsak @lguohan
[Mellanox]: Upgrade MFT package to 4.8.26 (sonic-net#3)
d3c4600 
This version is compatible with Linux kernel 4.9

Signed-off-by: marian-pritsak <[email protected]>
Staphylo pushed a commit to Staphylo/sonic-buildimage that referenced this pull request Mar 20, 2018
@marian-pritsak @lguohan
[Mellanox]: Upgrade MFT package to 4.8.26 (sonic-net#3)
7cfba1d 
This version is compatible with Linux kernel 4.9

Signed-off-by: marian-pritsak <[email protected]>
@jleveque jleveque mentioned this pull request Apr 5, 2018
Merged
lguohan pushed a commit that referenced this pull request Apr 6, 2018
@jleveque @lguohan
[sonic-platform-common] Update submodule (#1563)
e6015d8 
- Includes the following commits:
    - [bcmshell.py] Match extra whitespace before prompt in regex (#3)
    - add support for qsfp28 eeprom (#2)
lguohan pushed a commit that referenced this pull request Apr 6, 2018
@jleveque @lguohan
[sonic-platform-common] Update submodule (#1563)
2c08426 
- Includes the following commits:
    - [bcmshell.py] Match extra whitespace before prompt in regex (#3)
    - add support for qsfp28 eeprom (#2)
@amitabhja amitabhja mentioned this pull request Apr 6, 2018
Closed
mykolaf referenced this pull request in mykolaf/sonic-buildimage Apr 10, 2018
@marian-pritsak @lguohan
[Mellanox]: Upgrade MFT package to 4.8.26 (#3)
e67169c 
This version is compatible with Linux kernel 4.9

Signed-off-by: marian-pritsak <[email protected]>
yurypm pushed a commit to yurypm/sonic-buildimage that referenced this pull request Apr 17, 2018
@marian-pritsak @lguohan
[Mellanox]: Upgrade MFT package to 4.8.26 (sonic-net#3)
06a57f6 
This version is compatible with Linux kernel 4.9

Signed-off-by: marian-pritsak <[email protected]>
yurypm pushed a commit to yurypm/sonic-buildimage that referenced this pull request Jun 4, 2018
@marian-pritsak @lguohan
[Mellanox]: Upgrade MFT package to 4.8.26 (sonic-net#3)
825df08 
This version is compatible with Linux kernel 4.9

Signed-off-by: marian-pritsak <[email protected]>
@taoyl-ms taoyl-ms mentioned this pull request Jun 19, 2018
Merged
Staphylo pushed a commit to Staphylo/sonic-buildimage that referenced this pull request Jul 13, 2018
@marian-pritsak @lguohan
[Mellanox]: Upgrade MFT package to 4.8.26 (sonic-net#3)
575d3aa 
This version is compatible with Linux kernel 4.9

Signed-off-by: marian-pritsak <[email protected]>
volodymyrsamotiy referenced this pull request in volodymyrsamotiy/sonic-buildimage Aug 9, 2018
@marian-pritsak @lguohan
[Mellanox]: Upgrade MFT package to 4.8.26 (#3)
c587580 
This version is compatible with Linux kernel 4.9

Signed-off-by: marian-pritsak <[email protected]>
lguohan pushed a commit that referenced this pull request Aug 12, 2018
@marian-pritsak @lguohan
[Mellanox]: Upgrade MFT package to 4.8.26 (#3)
9aebe09 
This version is compatible with Linux kernel 4.9

Signed-off-by: marian-pritsak <[email protected]>
@klhaung klhaung mentioned this pull request Aug 16, 2018
Closed
@tylerlinp tylerlinp mentioned this pull request Aug 28, 2018
Closed
lguohan pushed a commit that referenced this pull request Apr 29, 2019
@jleveque @lguohan
[dhcp_relay] Base DHCP Relay Docker container on Debian Stretch (#2832)
b186bb2 
* Base DHCP relay Docker image on Strech base Docker

* Change URL for isc-dhcp source repository

* Upgrade isc-dhcp source branch to 4.3.5-3.1

* Update patch #1 to apply to isc-dhcp 4.3.5-3.1

* Update patch #2 to apply to isc-dhcp 4.3.5-3.1

* Update patch #3 to apply to isc-dhcp 4.3.5-3.1

* Update patch #4 to apply to isc-dhcp 4.3.5-3.1

* Remove security patches, as they are now applied as part of 4.3.5-3.1 source

* Reorder patches to apply bug fix first, then features

* Extend makefile to build debug Docker image

* Update commit that series file applies against
MichelMoriniaux pushed a commit to criteo-forks/sonic-buildimage that referenced this pull request May 28, 2019
@jleveque @MichelMoriniaux
[dhcp_relay] Base DHCP Relay Docker container on Debian Stretch (soni…
b73af5e 
…c-net#2832)

* Base DHCP relay Docker image on Strech base Docker

* Change URL for isc-dhcp source repository

* Upgrade isc-dhcp source branch to 4.3.5-3.1

* Update patch sonic-net#1 to apply to isc-dhcp 4.3.5-3.1

* Update patch sonic-net#2 to apply to isc-dhcp 4.3.5-3.1

* Update patch sonic-net#3 to apply to isc-dhcp 4.3.5-3.1

* Update patch sonic-net#4 to apply to isc-dhcp 4.3.5-3.1

* Remove security patches, as they are now applied as part of 4.3.5-3.1 source

* Reorder patches to apply bug fix first, then features

* Extend makefile to build debug Docker image

* Update commit that series file applies against
@akokhan akokhan mentioned this pull request Aug 8, 2019
Closed
Kalimuthu-Velappan pushed a commit to Kalimuthu-Velappan/sonic-buildimage that referenced this pull request Sep 12, 2019
@marian-pritsak @lguohan
Integrate generate_dump utility (sonic-net#3)
033a58c
@kannankvs kannankvs mentioned this pull request Nov 21, 2019
Open
@stephenxs stephenxs mentioned this pull request Nov 30, 2019
Open
vasant17 pushed a commit to vasant17/sonic-buildimage that referenced this pull request Jan 23, 2020
@zhenggen-xu
[yang-model-tests]: YANG model test code and JSON input for testing. (s…
d6625ca 
…onic-net#3)

* [yang-model-tests]: YANG model test code and JSON input for testing.

* [yang-model-tests]: Edited YANG model test code with map for Error and Tests.
@prgeor prgeor mentioned this pull request Aug 2, 2023
Merged
11 tasks
ShenzhenFlines referenced this pull request in ShenzhenFlines/sonic-buildimage-new Aug 8, 2023
Merge pull request 'develop/evb_8t_rel' (clounix#3) from develop/evb_…
5aa2555 
…8t_rel into evb_8t_rel

Reviewed-on: http://172.168.120.89:3000/flks/sonic-buildimage-new/pulls/3
Reviewed-by: chengxiang <[email protected]>
Reviewed-by: wangjingwu <[email protected]>
shanshri pushed a commit to shanshri/sonic-buildimage-sonic-net that referenced this pull request Oct 24, 2023
@lguohan
[igb]: support broadcom 54616 phy for Intel igb driver (sonic-net#3)
3639697
shanshri pushed a commit to shanshri/sonic-buildimage-sonic-net that referenced this pull request Oct 24, 2023
@MellanoxBSP @lguohan
Update stretch for mellanox platform (sonic-net#10)
060e06f 
* build 4.9.0-3 debian kernel

* Mellanox system drivers backport to kernel 4.9

This series of patches introduces support for Mellanox systems.
Most of the patches is a backporting from the kernels 4.10 � 4.14
for Mellanox system drivers that have been applied upstream and
a few patches contain current Mellanox upstream work � patches
which are in review process for acceptances for kernels 4.16 � 4.17.
This series introduces Mellanox i2c controller, mux, platform,
hotplug, led, asic drivers, TI voltage controller driver and the
extension of Mellanox kernel config.

In series file all the patches are listed and all old patches, relevant
for old 3.16 kernel are commented out.

Signed-off-by: Vadim Pasternak <[email protected]>

* Mellanox system drivers backport to kernel 4.9

This series of patches introduces support for Mellanox systems.
Most of the patches is a backporting from the kernels 4.10 - 4.14
for Mellanox system drivers that have been applied upstream and
a few patches contain current Mellanox upstream work patches
which are in review process for acceptances for kernels 4.16 - 4.17.
This series introduces Mellanox i2c controller, mux, platform,
hotplug, led, asic drivers, TI voltage controller driver and the
extension of Mellanox kernel config.

The patchset includes the bellow commits. And additional we have a code
from two work in progress patchsets, which are supposed to be available in
4.17, in review in:
http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git
http://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git
This is to make Mellanox drivers architecture independent and also extend
the supported system types, since we have a number of new systems).

commit ae3923a284cc696311294022e9b1a49058f07387
Author: Bhumika Goyal <[email protected]>
Date:   Mon Aug 21 17:42:04 2017 +0530
    i2c: busses: make i2c_adapter_quirks const

commit 26b1083b4545ec08a7dcfe759323a2e142d60d75
Author: Wolfram Sang <[email protected]>
Date:   Mon Aug 14 10:23:26 2017 +0200
    i2c: mux: mlxcpld: move header file out of I2C realm

commit 1da87267006246137a96682404bc0716a10c85a7
Author: Wei Yongjun <[email protected]>
Date:   Thu Jan 12 14:29:04 2017 +0000
    i2c: mux: mlxcpld: remove unused including <linux/version.h>

commit 649ac63a9ae5e08b7123f2fa98c2bf42f033bdb9
Author: Peter Rosin <[email protected]>
Date:   Sat Dec 17 21:29:11 2016 +0100
    i2c: mux: mlxcpld: fix i2c mux selection caching

commit c02b7bf532f7e46f1f9a0e9c3c27ca3f6f134e8d
Author: Vadim Pasternak <[email protected]>
Date:   Thu Nov 10 21:26:23 2016 +0000
    i2c: mux: mellanox: add driver

commit dca897e28f364724e42f65cf0262fa367512498d
Author: Vadim Pasternak <[email protected]>
Date:   Thu Nov 3 19:17:19 2016 +0000
    leds: verify vendor and change license in mlxcpld driver

commit be4fdf99fa4dc95aa01144b207caf2cc9fa074d8
Author: Vadim Pasternak <[email protected]>
Date:   Thu Sep 8 07:25:53 2016 +0000
    leds: add driver for Mellanox systems LEDs

commit d70eaa386bf9ecc1e5b3002f64eb59172fcec4fd
Author: Vadim Pasternak <[email protected]>
Date:   Wed, Nov 1 13:10:42 2017 +0200
    mlxsw: i2c: Fix buffer increment counter for write transaction

commit 7ca36994a3479e6d9d81baba34a426c47691ea08
Author: Arkadi Sharshevsky <[email protected]>
Date:   Wed Jun 14 09:27:39 2017 +0200
    mlxsw: reg: Add MCIA register for cable info access

commit 36ca68bf9919299c95ff80e7cf3c217f4c250cbe
Author: Elad Raz <[email protected]>
Date:   Mon Jan 9 11:25:44 2017 +0100
    mlxsw: Fix mlxsw_i2c_write return value

commit d556e929164fdc6c94848374fc98c40852f97adb
Author: Vadim Pasternak <[email protected]>
Date:   Wed Nov 16 15:20:46 2016 +0100
    mlxsw: minimal: Add I2C support for Mellanox ASICs

commit 6882b0aee180f2797b8803bdf699aa45c2e5f2d6
Author: Vadim Pasternak <[email protected]>
Date:   Wed Nov 16 15:20:44 2016 +0100
    mlxsw: Introduce support for I2C bus

commit ba20de060094c64a981a4fec8fecc587d076383d
Author: Vadim Pasternak <[email protected]>
Date:   Wed Oct 18 07:26:55 2017 +0000
    platform/x86: move Mellanox hardware platform hotplug driver to platform/mellanox

commit 6faadbbb7f9da70ce484f98f72223c20125a1009
Author: Christoph Hellwig <[email protected]>
Date:   Thu Sep 14 11:59:30 2017 +0200
    dmi: Mark all struct dmi_system_id instances const

commit 9a38b67c9877a7371a250454bbbbf521d02fded5
Author: Vadim Pasternak <[email protected]>
Date:   Wed Dec 14 12:05:15 2016 +0000
    platform/x86: mlx-platform: mlxcpld-hotplug driver style fixes

commit 63d762b88cb5510f2bfdb5112ced18cde867ae61
Author: Dan Carpenter <[email protected]>
Date:   Sat Jan 7 09:33:34 2017 +0300
    platform/x86: mlx-platform: free first dev on error

commit afc4715901f0dce3206837a7051af05abf5a1e06
Author: Vadim Pasternak <[email protected]>
Date:   Thu Oct 27 19:55:54 2016 +0000
    platform/x86: mlx-platform: Add mlxcpld-hotplug driver registration

commit c3886c9d6076555697551da9b921cf6a6e9cc2b5
Author: kbuild test robot <[email protected]>
Date:   Fri Oct 28 01:26:50 2016 +0800
    platform/x86: mlx-platform: Fix semicolon.cocci warnings

commit 6613d18e90385db5cdbe32fe47567a3c11575b2d
Author: Vadim Pasternak <[email protected]>
Date:   Mon Oct 31 07:22:33 2016 +0000
    platform/x86: mlx-platform: Move module from arch/x86

commit 304887041d953b6692c0d4a9f8fafb252d32e9a0
Author: Vadim Pasternak <[email protected]>
Date:   Thu Oct 20 16:28:01 2016 +0000
    platform/x86: Introduce support for Mellanox hotplug driver

commit d4977c083aeb28cf72c1b019e3f9df13608126dd
Author: Vadim Pasternak <[email protected]>
Date:   Tue Aug 29 20:06:21 2017 +0000
    hwmon: (pmbus) Add support for Intel VID protocol VR13

commit 610526527a13e4c91e64ec3dfb4626c5043291c9
Author: Vadim Pasternak <[email protected]>
Date:   Wed Aug 30 22:02:14 2017 +0000
    hwmon: (pmbus) Add support for Texas Instruments tps53679 device

In series file all the patches are listed and all old patches, relevant
for old 3.16 kernel are commented out.

Signed-off-by: Vadim Pasternak <[email protected]>

* Makefile: uncomment line for applying kernel patches and config

This patch uncomments lines in Makefile related to applying patches and
configuration changes

Signed-off-by: Vadim Pasternak <[email protected]>

* exit immediately when shell commands fail

* config: mellanox kernel configuration

It adds explicit records for new configuration attributes which are not
set in kernel config.

Signed-off-by: Vadim Pasternak <[email protected]>

* Mellanox system drivers backport to kernel 4.9 (sonic-net#1)

* Mellanox system drivers backport to kernel 4.9

This series of patches introduces support for Mellanox systems.
Most of the patches is a backporting from the kernels 4.10 � 4.14
for Mellanox system drivers that have been applied upstream and
a few patches contain current Mellanox upstream work � patches
which are in review process for acceptances for kernels 4.16 � 4.17.
This series introduces Mellanox i2c controller, mux, platform,
hotplug, led, asic drivers, TI voltage controller driver and the
extension of Mellanox kernel config.

In series file all the patches are listed and all old patches, relevant
for old 3.16 kernel are commented out.

Signed-off-by: Vadim Pasternak <[email protected]>

* Mellanox system drivers backport to kernel 4.9

This series of patches introduces support for Mellanox systems.
Most of the patches is a backporting from the kernels 4.10 - 4.14
for Mellanox system drivers that have been applied upstream and
a few patches contain current Mellanox upstream work patches
which are in review process for acceptances for kernels 4.16 - 4.17.
This series introduces Mellanox i2c controller, mux, platform,
hotplug, led, asic drivers, TI voltage controller driver and the
extension of Mellanox kernel config.

The patchset includes the bellow commits. And additional we have a code
from two work in progress patchsets, which are supposed to be available in
4.17, in review in:
http://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git
http://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds.git
This is to make Mellanox drivers architecture independent and also extend
the supported system types, since we have a number of new systems).

commit ae3923a284cc696311294022e9b1a49058f07387
Author: Bhumika Goyal <[email protected]>
Date:   Mon Aug 21 17:42:04 2017 +0530
    i2c: busses: make i2c_adapter_quirks const

commit 26b1083b4545ec08a7dcfe759323a2e142d60d75
Author: Wolfram Sang <[email protected]>
Date:   Mon Aug 14 10:23:26 2017 +0200
    i2c: mux: mlxcpld: move header file out of I2C realm

commit 1da87267006246137a96682404bc0716a10c85a7
Author: Wei Yongjun <[email protected]>
Date:   Thu Jan 12 14:29:04 2017 +0000
    i2c: mux: mlxcpld: remove unused including <linux/version.h>

commit 649ac63a9ae5e08b7123f2fa98c2bf42f033bdb9
Author: Peter Rosin <[email protected]>
Date:   Sat Dec 17 21:29:11 2016 +0100
    i2c: mux: mlxcpld: fix i2c mux selection caching

commit c02b7bf532f7e46f1f9a0e9c3c27ca3f6f134e8d
Author: Vadim Pasternak <[email protected]>
Date:   Thu Nov 10 21:26:23 2016 +0000
    i2c: mux: mellanox: add driver

commit dca897e28f364724e42f65cf0262fa367512498d
Author: Vadim Pasternak <[email protected]>
Date:   Thu Nov 3 19:17:19 2016 +0000
    leds: verify vendor and change license in mlxcpld driver

commit be4fdf99fa4dc95aa01144b207caf2cc9fa074d8
Author: Vadim Pasternak <[email protected]>
Date:   Thu Sep 8 07:25:53 2016 +0000
    leds: add driver for Mellanox systems LEDs

commit d70eaa386bf9ecc1e5b3002f64eb59172fcec4fd
Author: Vadim Pasternak <[email protected]>
Date:   Wed, Nov 1 13:10:42 2017 +0200
    mlxsw: i2c: Fix buffer increment counter for write transaction

commit 7ca36994a3479e6d9d81baba34a426c47691ea08
Author: Arkadi Sharshevsky <[email protected]>
Date:   Wed Jun 14 09:27:39 2017 +0200
    mlxsw: reg: Add MCIA register for cable info access

commit 36ca68bf9919299c95ff80e7cf3c217f4c250cbe
Author: Elad Raz <[email protected]>
Date:   Mon Jan 9 11:25:44 2017 +0100
    mlxsw: Fix mlxsw_i2c_write return value

commit d556e929164fdc6c94848374fc98c40852f97adb
Author: Vadim Pasternak <[email protected]>
Date:   Wed Nov 16 15:20:46 2016 +0100
    mlxsw: minimal: Add I2C support for Mellanox ASICs

commit 6882b0aee180f2797b8803bdf699aa45c2e5f2d6
Author: Vadim Pasternak <[email protected]>
Date:   Wed Nov 16 15:20:44 2016 +0100
    mlxsw: Introduce support for I2C bus

commit ba20de060094c64a981a4fec8fecc587d076383d
Author: Vadim Pasternak <[email protected]>
Date:   Wed Oct 18 07:26:55 2017 +0000
    platform/x86: move Mellanox hardware platform hotplug driver to platform/mellanox

commit 6faadbbb7f9da70ce484f98f72223c20125a1009
Author: Christoph Hellwig <[email protected]>
Date:   Thu Sep 14 11:59:30 2017 +0200
    dmi: Mark all struct dmi_system_id instances const

commit 9a38b67c9877a7371a250454bbbbf521d02fded5
Author: Vadim Pasternak <[email protected]>
Date:   Wed Dec 14 12:05:15 2016 +0000
    platform/x86: mlx-platform: mlxcpld-hotplug driver style fixes

commit 63d762b88cb5510f2bfdb5112ced18cde867ae61
Author: Dan Carpenter <[email protected]>
Date:   Sat Jan 7 09:33:34 2017 +0300
    platform/x86: mlx-platform: free first dev on error

commit afc4715901f0dce3206837a7051af05abf5a1e06
Author: Vadim Pasternak <[email protected]>
Date:   Thu Oct 27 19:55:54 2016 +0000
    platform/x86: mlx-platform: Add mlxcpld-hotplug driver registration

commit c3886c9d6076555697551da9b921cf6a6e9cc2b5
Author: kbuild test robot <[email protected]>
Date:   Fri Oct 28 01:26:50 2016 +0800
    platform/x86: mlx-platform: Fix semicolon.cocci warnings

commit 6613d18e90385db5cdbe32fe47567a3c11575b2d
Author: Vadim Pasternak <[email protected]>
Date:   Mon Oct 31 07:22:33 2016 +0000
    platform/x86: mlx-platform: Move module from arch/x86

commit 304887041d953b6692c0d4a9f8fafb252d32e9a0
Author: Vadim Pasternak <[email protected]>
Date:   Thu Oct 20 16:28:01 2016 +0000
    platform/x86: Introduce support for Mellanox hotplug driver

commit d4977c083aeb28cf72c1b019e3f9df13608126dd
Author: Vadim Pasternak <[email protected]>
Date:   Tue Aug 29 20:06:21 2017 +0000
    hwmon: (pmbus) Add support for Intel VID protocol VR13

commit 610526527a13e4c91e64ec3dfb4626c5043291c9
Author: Vadim Pasternak <[email protected]>
Date:   Wed Aug 30 22:02:14 2017 +0000
    hwmon: (pmbus) Add support for Texas Instruments tps53679 device

In series file all the patches are listed and all old patches, relevant
for old 3.16 kernel are commented out.

Signed-off-by: Vadim Pasternak <[email protected]>

* Makefile: uncomment line for applying kernel patches and config

This patch uncomments lines in Makefile related to applying patches and
configuration changes

Signed-off-by: Vadim Pasternak <[email protected]>

* config: mellanox kernel configuration

It adds explicit records for new configuration attributes which are not
set in kernel config.

Signed-off-by: Vadim Pasternak <[email protected]>

* [igb]: support broadcom 54616 phy for Intel igb driver (sonic-net#3)

* platform/mellanox: mlxreg-hotplug driver add check for low aggregation register mask

It adds verification for low aggregation register mask offset. Only
non-zero offset is considered as valid.

Signed-off-by: Vadim Pasternak <[email protected]>

* path: rename: platform-mellanox-mlxreg-hotplug-driver-add-check-fo.patch

It renames platform-mellanox-mlxreg-hotplug-driver-add-check-fo.patch
from 0011 to 0012, since 0011 is already exist.

Signed-off-by: Vadim Pasternak <[email protected]>

* Update kernel with the latest upstream pacthes.

Signed-off-by: Vadim Pasternak <[email protected]>
@arlakshm arlakshm mentioned this pull request Nov 22, 2023
Closed
lixiaoyuner pushed a commit to lixiaoyuner/sonic-buildimage that referenced this pull request Feb 6, 2024
@judyjoseph
Merge pull request sonic-net#3 from judyjoseph/ndkBuild
47a8caf 
Update the platform makefile to get ndk platform deb
@anamehra anamehra mentioned this pull request Aug 1, 2024
Closed
lguohan pushed a commit that referenced this pull request Dec 4, 2024
@dgsudharsan
[202405][FRR] Fixing FRR to make route node lock (#20990)
fef2d0d 
To fix a statistical issue. The original fix was done in FRRouting/frr#17297. However to accommodate 8.5.4 the patch in the PR was added.

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra -A 127.0.0.1 -s 90000000 -M dplane_fpm_nl -M snmp'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
[Current thread is 1 (Thread 0x7fccd6faf7c0 (LWP 36))]
(gdb) bt
#0  0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007fccd7302fb2 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#2  0x00007fccd72ed472 in abort () from /lib/x86_64-linux-gnu/libc.so.6
#3  0x00007fccd75bb3a9 in _zlog_assert_failed (xref=xref@entry=0x7fccd7652380 <_xref.16>, extra=extra@entry=0x0) at ../lib/zlog.c:678
#4  0x00007fccd759b2fe in route_node_delete (node=<optimized out>) at ../lib/table.c:352
#5  0x00007fccd759b445 in route_unlock_node (node=0x0) at ../lib/table.h:258
#6  route_next (node=<optimized out>) at ../lib/table.c:436
#7  route_next (node=node@entry=0x56029d89e560) at ../lib/table.c:410
#8  0x000056029b6b6b7a in if_lookup_by_name_per_ns (ns=ns@entry=0x56029d873d90, ifname=ifname@entry=0x7fccc0029340 "PortChannel1020")
    at ../zebra/interface.c:312
#9  0x000056029b6b8b36 in zebra_if_dplane_ifp_handling (ctx=0x7fccc0029310) at ../zebra/interface.c:1867
#10 zebra_if_dplane_result (ctx=0x7fccc0029310) at ../zebra/interface.c:2221
#11 0x000056029b7137a9 in rib_process_dplane_results (thread=<optimized out>) at ../zebra/zebra_rib.c:4810
#12 0x00007fccd75a0e0d in thread_call (thread=thread@entry=0x7ffe8e553cc0) at ../lib/thread.c:1990
#13 0x00007fccd7559368 in frr_run (master=0x56029d65a040) at ../lib/libfrr.c:1198
#14 0x000056029b6ac317 in main (argc=9, argv=0x7ffe8e5540d8) at ../zebra/main.c:478
lguohan pushed a commit that referenced this pull request Dec 10, 2024
@dgsudharsan
[FRR]Fixing zebra to use internal rbtree per NS tree of ifps (#21095)
c715dff 
Adding the below fix from FRR FRRouting/frr#17297

This is to fix the following crash which is a statistical issue

[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra -A 127.0.0.1 -s 90000000 -M dplane_fpm_nl -M snmp'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
[Current thread is 1 (Thread 0x7fccd6faf7c0 (LWP 36))]
(gdb) bt
#0  0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007fccd7302fb2 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#2  0x00007fccd72ed472 in abort () from /lib/x86_64-linux-gnu/libc.so.6
#3  0x00007fccd75bb3a9 in _zlog_assert_failed (xref=xref@entry=0x7fccd7652380 <_xref.16>, extra=extra@entry=0x0) at ../lib/zlog.c:678
#4  0x00007fccd759b2fe in route_node_delete (node=<optimized out>) at ../lib/table.c:352
#5  0x00007fccd759b445 in route_unlock_node (node=0x0) at ../lib/table.h:258
#6  route_next (node=<optimized out>) at ../lib/table.c:436
#7  route_next (node=node@entry=0x56029d89e560) at ../lib/table.c:410
#8  0x000056029b6b6b7a in if_lookup_by_name_per_ns (ns=ns@entry=0x56029d873d90, ifname=ifname@entry=0x7fccc0029340 "PortChannel1020")
    at ../zebra/interface.c:312
#9  0x000056029b6b8b36 in zebra_if_dplane_ifp_handling (ctx=0x7fccc0029310) at ../zebra/interface.c:1867
#10 zebra_if_dplane_result (ctx=0x7fccc0029310) at ../zebra/interface.c:2221
#11 0x000056029b7137a9 in rib_process_dplane_results (thread=<optimized out>) at ../zebra/zebra_rib.c:4810
#12 0x00007fccd75a0e0d in thread_call (thread=thread@entry=0x7ffe8e553cc0) at ../lib/thread.c:1990
#13 0x00007fccd7559368 in frr_run (master=0x56029d65a040) at ../lib/libfrr.c:1198
#14 0x000056029b6ac317 in main (argc=9, argv=0x7ffe8e5540d8) at ../zebra/main.c:478
@anamehra anamehra mentioned this pull request Dec 14, 2024
Closed
mssonicbld added a commit to mssonicbld/sonic-buildimage that referenced this pull request Jan 13, 2025
@mssonicbld
[FRR]Fixing zebra to use internal rbtree per NS tree of ifps
bd71c1f 
<!--
     Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

     ** Make sure all your commits include a signature generated with `git commit -s` **

     If this is a bug fix, make sure your description includes "fixes #xxxx", or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it

Adding the below fix from FRR FRRouting/frr#17297

This is to fix the following crash which is a statistical issue

```
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra -A 127.0.0.1 -s 90000000 -M dplane_fpm_nl -M snmp'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
[Current thread is 1 (Thread 0x7fccd6faf7c0 (LWP 36))]
(gdb) bt
#0  0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
sonic-net#1  0x00007fccd7302fb2 in raise () from /lib/x86_64-linux-gnu/libc.so.6
sonic-net#2  0x00007fccd72ed472 in abort () from /lib/x86_64-linux-gnu/libc.so.6
sonic-net#3  0x00007fccd75bb3a9 in _zlog_assert_failed (xref=xref@entry=0x7fccd7652380 <_xref.16>, extra=extra@entry=0x0) at ../lib/zlog.c:678
sonic-net#4  0x00007fccd759b2fe in route_node_delete (node=<optimized out>) at ../lib/table.c:352
sonic-net#5  0x00007fccd759b445 in route_unlock_node (node=0x0) at ../lib/table.h:258
sonic-net#6  route_next (node=<optimized out>) at ../lib/table.c:436
sonic-net#7  route_next (node=node@entry=0x56029d89e560) at ../lib/table.c:410
sonic-net#8  0x000056029b6b6b7a in if_lookup_by_name_per_ns (ns=ns@entry=0x56029d873d90, ifname=ifname@entry=0x7fccc0029340 "PortChannel1020")
    at ../zebra/interface.c:312
sonic-net#9  0x000056029b6b8b36 in zebra_if_dplane_ifp_handling (ctx=0x7fccc0029310) at ../zebra/interface.c:1867
sonic-net#10 zebra_if_dplane_result (ctx=0x7fccc0029310) at ../zebra/interface.c:2221
sonic-net#11 0x000056029b7137a9 in rib_process_dplane_results (thread=<optimized out>) at ../zebra/zebra_rib.c:4810
sonic-net#12 0x00007fccd75a0e0d in thread_call (thread=thread@entry=0x7ffe8e553cc0) at ../lib/thread.c:1990
sonic-net#13 0x00007fccd7559368 in frr_run (master=0x56029d65a040) at ../lib/libfrr.c:1198
sonic-net#14 0x000056029b6ac317 in main (argc=9, argv=0x7ffe8e5540d8) at ../zebra/main.c:478
```

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it
Added patch.

#### How to verify it
Running BGP tests.

<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211
- [ ] 202305

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
mssonicbld added a commit that referenced this pull request Jan 15, 2025
@mssonicbld
[FRR]Fixing zebra to use internal rbtree per NS tree of ifps (#21405)
3ea3c23 
<!--
 Please make sure you've read and understood our contributing guidelines:
 https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

 failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` **

 If this is a bug fix, make sure your description includes "fixes #xxxx", or
 "closes #xxxx" or "resolves #xxxx"

 Please provide the following information:
-->

#### Why I did it

Adding the below fix from FRR FRRouting/frr#17297

This is to fix the following crash which is a statistical issue

```
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra -A 127.0.0.1 -s 90000000 -M dplane_fpm_nl -M snmp'.
Program terminated with signal SIGABRT, Aborted.
#0 0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
[Current thread is 1 (Thread 0x7fccd6faf7c0 (LWP 36))]
(gdb) bt
#0 0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#1 0x00007fccd7302fb2 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#2 0x00007fccd72ed472 in abort () from /lib/x86_64-linux-gnu/libc.so.6
#3 0x00007fccd75bb3a9 in _zlog_assert_failed (xref=xref@entry=0x7fccd7652380 <_xref.16>, extra=extra@entry=0x0) at ../lib/zlog.c:678
#4 0x00007fccd759b2fe in route_node_delete (node=<optimized out>) at ../lib/table.c:352
#5 0x00007fccd759b445 in route_unlock_node (node=0x0) at ../lib/table.h:258
#6 route_next (node=<optimized out>) at ../lib/table.c:436
#7 route_next (node=node@entry=0x56029d89e560) at ../lib/table.c:410
#8 0x000056029b6b6b7a in if_lookup_by_name_per_ns (ns=ns@entry=0x56029d873d90, ifname=ifname@entry=0x7fccc0029340 "PortChannel1020")
 at ../zebra/interface.c:312
#9 0x000056029b6b8b36 in zebra_if_dplane_ifp_handling (ctx=0x7fccc0029310) at ../zebra/interface.c:1867
#10 zebra_if_dplane_result (ctx=0x7fccc0029310) at ../zebra/interface.c:2221
#11 0x000056029b7137a9 in rib_process_dplane_results (thread=<optimized out>) at ../zebra/zebra_rib.c:4810
#12 0x00007fccd75a0e0d in thread_call (thread=thread@entry=0x7ffe8e553cc0) at ../lib/thread.c:1990
#13 0x00007fccd7559368 in frr_run (master=0x56029d65a040) at ../lib/libfrr.c:1198
#14 0x000056029b6ac317 in main (argc=9, argv=0x7ffe8e5540d8) at ../zebra/main.c:478
```

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it
Added patch.

#### How to verify it
Running BGP tests.

<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211
- [ ] 202305

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
@rajneeshaec rajneeshaec mentioned this pull request Jan 25, 2025
Open
@zyboy2000 zyboy2000 mentioned this pull request Apr 17, 2025
Open
@vinaymh12 vinaymh12 mentioned this pull request Jun 22, 2025
Closed
@dsriram-hcl dsriram-hcl mentioned this pull request Jul 2, 2025
Open
@bhouse-nexthop bhouse-nexthop mentioned this pull request Jul 8, 2025
Merged
@eddieruan-alibaba eddieruan-alibaba mentioned this pull request Sep 22, 2025
Open
@vivekrnv vivekrnv mentioned this pull request Sep 24, 2025
Closed
croos12 referenced this pull request in croos12/sonic-buildimage Sep 29, 2025
@mssonicbld
[FRR]Fixing zebra to use internal rbtree per NS tree of ifps
bcd9ebf 
<!--
     Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

     ** Make sure all your commits include a signature generated with `git commit -s` **

     If this is a bug fix, make sure your description includes "fixes #xxxx", or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it

Adding the below fix from FRR FRRouting/frr#17297

This is to fix the following crash which is a statistical issue

```
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `/usr/lib/frr/zebra -A 127.0.0.1 -s 90000000 -M dplane_fpm_nl -M snmp'.
Program terminated with signal SIGABRT, Aborted.
#0  0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
[Current thread is 1 (Thread 0x7fccd6faf7c0 (LWP 36))]
(gdb) bt
#0  0x00007fccd7351e2c in ?? () from /lib/x86_64-linux-gnu/libc.so.6
#1  0x00007fccd7302fb2 in raise () from /lib/x86_64-linux-gnu/libc.so.6
#2  0x00007fccd72ed472 in abort () from /lib/x86_64-linux-gnu/libc.so.6
#3  0x00007fccd75bb3a9 in _zlog_assert_failed (xref=xref@entry=0x7fccd7652380 <_xref.16>, extra=extra@entry=0x0) at ../lib/zlog.c:678
#4  0x00007fccd759b2fe in route_node_delete (node=<optimized out>) at ../lib/table.c:352
#5  0x00007fccd759b445 in route_unlock_node (node=0x0) at ../lib/table.h:258
#6  route_next (node=<optimized out>) at ../lib/table.c:436
#7  route_next (node=node@entry=0x56029d89e560) at ../lib/table.c:410
#8  0x000056029b6b6b7a in if_lookup_by_name_per_ns (ns=ns@entry=0x56029d873d90, ifname=ifname@entry=0x7fccc0029340 "PortChannel1020")
    at ../zebra/interface.c:312
#9  0x000056029b6b8b36 in zebra_if_dplane_ifp_handling (ctx=0x7fccc0029310) at ../zebra/interface.c:1867
#10 zebra_if_dplane_result (ctx=0x7fccc0029310) at ../zebra/interface.c:2221
#11 0x000056029b7137a9 in rib_process_dplane_results (thread=<optimized out>) at ../zebra/zebra_rib.c:4810
#12 0x00007fccd75a0e0d in thread_call (thread=thread@entry=0x7ffe8e553cc0) at ../lib/thread.c:1990
#13 0x00007fccd7559368 in frr_run (master=0x56029d65a040) at ../lib/libfrr.c:1198
sonic-net#14 0x000056029b6ac317 in main (argc=9, argv=0x7ffe8e5540d8) at ../zebra/main.c:478
```

##### Work item tracking
- Microsoft ADO **(number only)**:

#### How I did it
Added patch.

#### How to verify it
Running BGP tests.

<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211
- [ ] 202305

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
 Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
@bhouse-nexthop bhouse-nexthop mentioned this pull request Nov 14, 2025
Open
10 tasks
@zyboy2000 zyboy2000 mentioned this pull request Dec 4, 2025
Open
rustiqly added a commit to rustiqly/sonic-buildimage that referenced this pull request Mar 4, 2026
@rustiqly
Address Copilot review: fix 17 bugs in build analysis scripts
da18f0d 
- Use free -m with division instead of free -g to avoid rounding (#1)
- Add = and ?= to Makefile dependency regex patterns (sonic-net#2, sonic-net#7)
- CPU calculation now uses /proc/stat delta (two reads) (sonic-net#3, sonic-net#14)
- Fix misleading 'critical path estimate' comment (sonic-net#4)
- Fix parallelism timeline comment (60s not 10s) (sonic-net#5)
- Include after-relationship packages in fan stats (sonic-net#6)
- Guard disk I/O division by zero when INTERVAL<=1 (sonic-net#8)
- Remove unused elapsed_line variable (sonic-net#9)
- Remove redundant LIBSWSSCOMMON_DBG check (sonic-net#10)
- Remove active_make_jobs from CSV header comment (sonic-net#11)
- Wire up _RDEPENDS parsing to build reverse deps (sonic-net#12)
- Remove unnecessary 'if v' filter on rdeps JSON (sonic-net#13)
- Remove unused REPORT_FORMAT parameter (sonic-net#15)
- Add cycle detection to critical path algorithm (sonic-net#16)
- Add execute permission check for companion scripts (sonic-net#17)

Signed-off-by: Rustiqly <[email protected]>
lihuay pushed a commit that referenced this pull request Mar 5, 2026
@rustiqly
[build] Add build timing report and dependency analysis tools (#25643)
31bdc3f 
* [build] Add build timing report and dependency analysis tools

Add three scripts for build performance instrumentation:

- scripts/build-timing-report.sh: Parse per-package timing from build
  logs (HEADER/FOOTER timestamps), generate sorted duration table,
  phase breakdown, parallelism timeline, and CSV export.

- scripts/build-dep-graph.py: Parse rules/*.mk dependency graph,
  compute critical path, fan-out/fan-in bottleneck analysis, and
  generate DOT/JSON output for visualization.

- scripts/build-resource-monitor.sh: Sample CPU, memory, disk I/O,
  and Docker container count during builds for resource utilization
  analysis.

Add "make build-report" target to slave.mk that runs the timing
report and dependency analysis after a build completes.

Example output from a VS build on 24-core/30GB machine:
- 210 packages built in 53m wall time (173m CPU)
- Max concurrency: 5 (with SONIC_CONFIG_BUILD_JOBS=4)
- Critical path: 14 packages deep (libnl -> libswsscommon -> utilities)
- Top bottleneck: LIBSWSSCOMMON with 48 downstream dependents

Signed-off-by: Rustiqly <[email protected]>

* Address Copilot review: fix 17 bugs in build analysis scripts

- Use free -m with division instead of free -g to avoid rounding (#1)
- Add = and ?= to Makefile dependency regex patterns (#2, #7)
- CPU calculation now uses /proc/stat delta (two reads) (#3, #14)
- Fix misleading 'critical path estimate' comment (#4)
- Fix parallelism timeline comment (60s not 10s) (#5)
- Include after-relationship packages in fan stats (#6)
- Guard disk I/O division by zero when INTERVAL<=1 (#8)
- Remove unused elapsed_line variable (#9)
- Remove redundant LIBSWSSCOMMON_DBG check (#10)
- Remove active_make_jobs from CSV header comment (#11)
- Wire up _RDEPENDS parsing to build reverse deps (#12)
- Remove unnecessary 'if v' filter on rdeps JSON (#13)
- Remove unused REPORT_FORMAT parameter (#15)
- Add cycle detection to critical path algorithm (#16)
- Add execute permission check for companion scripts (#17)

Signed-off-by: Rustiqly <[email protected]>

---------

Signed-off-by: Rustiqly <[email protected]>
Co-authored-by: Rustiqly <[email protected]>
rustiqly added a commit to rustiqly/sonic-buildimage that referenced this pull request Mar 5, 2026
@rustiqly
Address Copilot review: fix 17 bugs in build analysis scripts
6b9ff9d 
- Use free -m with division instead of free -g to avoid rounding (#1)
- Add = and ?= to Makefile dependency regex patterns (sonic-net#2, sonic-net#7)
- CPU calculation now uses /proc/stat delta (two reads) (sonic-net#3, sonic-net#14)
- Fix misleading 'critical path estimate' comment (sonic-net#4)
- Fix parallelism timeline comment (60s not 10s) (sonic-net#5)
- Include after-relationship packages in fan stats (sonic-net#6)
- Guard disk I/O division by zero when INTERVAL<=1 (sonic-net#8)
- Remove unused elapsed_line variable (sonic-net#9)
- Remove redundant LIBSWSSCOMMON_DBG check (sonic-net#10)
- Remove active_make_jobs from CSV header comment (sonic-net#11)
- Wire up _RDEPENDS parsing to build reverse deps (sonic-net#12)
- Remove unnecessary 'if v' filter on rdeps JSON (sonic-net#13)
- Remove unused REPORT_FORMAT parameter (sonic-net#15)
- Add cycle detection to critical path algorithm (sonic-net#16)
- Add execute permission check for companion scripts (sonic-net#17)

Signed-off-by: Rustiqly <[email protected]>
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Mar 6, 2026
@rustiqly @FengPan-Frank
[build] Add build timing report and dependency analysis tools (sonic-…
3432d5a 
…net#25643)

* [build] Add build timing report and dependency analysis tools

Add three scripts for build performance instrumentation:

- scripts/build-timing-report.sh: Parse per-package timing from build
  logs (HEADER/FOOTER timestamps), generate sorted duration table,
  phase breakdown, parallelism timeline, and CSV export.

- scripts/build-dep-graph.py: Parse rules/*.mk dependency graph,
  compute critical path, fan-out/fan-in bottleneck analysis, and
  generate DOT/JSON output for visualization.

- scripts/build-resource-monitor.sh: Sample CPU, memory, disk I/O,
  and Docker container count during builds for resource utilization
  analysis.

Add "make build-report" target to slave.mk that runs the timing
report and dependency analysis after a build completes.

Example output from a VS build on 24-core/30GB machine:
- 210 packages built in 53m wall time (173m CPU)
- Max concurrency: 5 (with SONIC_CONFIG_BUILD_JOBS=4)
- Critical path: 14 packages deep (libnl -> libswsscommon -> utilities)
- Top bottleneck: LIBSWSSCOMMON with 48 downstream dependents

Signed-off-by: Rustiqly <[email protected]>

* Address Copilot review: fix 17 bugs in build analysis scripts

- Use free -m with division instead of free -g to avoid rounding (sonic-net#1)
- Add = and ?= to Makefile dependency regex patterns (sonic-net#2, sonic-net#7)
- CPU calculation now uses /proc/stat delta (two reads) (sonic-net#3, sonic-net#14)
- Fix misleading 'critical path estimate' comment (sonic-net#4)
- Fix parallelism timeline comment (60s not 10s) (sonic-net#5)
- Include after-relationship packages in fan stats (sonic-net#6)
- Guard disk I/O division by zero when INTERVAL<=1 (sonic-net#8)
- Remove unused elapsed_line variable (sonic-net#9)
- Remove redundant LIBSWSSCOMMON_DBG check (sonic-net#10)
- Remove active_make_jobs from CSV header comment (sonic-net#11)
- Wire up _RDEPENDS parsing to build reverse deps (sonic-net#12)
- Remove unnecessary 'if v' filter on rdeps JSON (sonic-net#13)
- Remove unused REPORT_FORMAT parameter (sonic-net#15)
- Add cycle detection to critical path algorithm (sonic-net#16)
- Add execute permission check for companion scripts (sonic-net#17)

Signed-off-by: Rustiqly <[email protected]>

---------

Signed-off-by: Rustiqly <[email protected]>
Co-authored-by: Rustiqly <[email protected]>
Signed-off-by: Feng Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@amybuck @stcheng