[libteam] Upgrade libteam to 1.28-1 and reorganize patches#2956
Merged
pavel-shirshov merged 1 commit intosonic-net:masterfrom Jun 4, 2019
asterfusion:dev/libteam1.28
Merged
[libteam] Upgrade libteam to 1.28-1 and reorganize patches#2956pavel-shirshov merged 1 commit intosonic-net:masterfrom asterfusion:dev/libteam1.28
pavel-shirshov merged 1 commit intosonic-net:masterfrom
asterfusion:dev/libteam1.28
Conversation
pavel-shirshov
suggested changes
May 30, 2019
Contributor
pavel-shirshov
left a comment
There was a problem hiding this comment.
Thanks for the patch!
- Please add following PR in your patch: 3f4de49
- I think this is part of current libteam master now: 0006-teamd-do-not-process-lacpdu-before-the-port-ifinfo-i.patch
- Please reorder patches to make 0004-Add-warm_reboot-mode.patch as the last one.
- Please keep the NETLINK_RCVBUF as 983040. 196608 is not enough for the device with 32 team interfaces
stcheng
suggested changes
Jun 1, 2019
Contributor
stcheng
left a comment
There was a problem hiding this comment.
is 1.28-1 stable enough?
could you maintain the patches' original owner's names? otherwise it's losing tracks of who's the author of the patches.
Contributor
Author
OK. Thanks for reviewing. I will improve that as you suggest. |
Contributor
|
@lorchid thanks! |
pavel-shirshov
approved these changes
Jun 4, 2019
Contributor
|
Can you please resolve the conflict and also remove "0014-Send-LACP-PDU-immediately-if-our-state-changed.patch" file? |
Contributor
|
For future references |
Signed-off-by: yorke <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yorke [email protected]
- What I did
Upgrade libteam to 1.28-1 and reorganize patches.
- How I did it
Modify Makefile and patch serires.
Note: NETLINK_RCVBUF is 196608 now (prev patch set it to 983040) and it works fine for testing. (Refering to libteam: double NETLINK_RCVBUF to fix -ENOMEM error)
- How to verify it
Build a SONiC image and run the lacp test in the sonic-mgmt repo. Ensure the test succeeds.
- Description for the changelog
modified: rules/libteam.mk
modified: src/libteam/Makefile
new file: src/libteam/patch/series
deleted: src/libteam/series
deleted: src/libteam/0001-libteam-Add-team_get_port_enabled-function.patch
deleted: src/libteam/0010-teamd-lacp-update-port-state-according-to-partners-sy.patch
deleted: src/libteam/0011-libteam-resynchronize-ifinfo-after-lost-RTNLGRP_LINK-.patch
renamed: src/libteam/0002-libteam-Temporarily-remove-redundant-debug-mes.patch -> src/libteam/patch/0001-Temporarily-remove-redundant-debug-messages.patch
renamed: src/libteam/0003-teamd-lacp-runner-will-send-lacp-update-right-after-.patch -> src/libteam/patch/0002-Lacp-runner-will-send-lacp-update-right-after-it-rec.patch
renamed: src/libteam/0004-libteam-Add-lacp-fallback-support-for-single-member-.patch -> src/libteam/patch/0003-Add-fallback-support-for-single-member-port-LAG.patch
renamed: src/libteam/0005-libteam-Add-warm_reboot-mode.patch -> src/libteam/patch/0004-Add-warm_reboot-mode.patch
renamed: src/libteam/0007-Skip-setting-the-same-hwaddr-to-lag-port-to-avoid-di.patch -> src/libteam/patch/0005-Skip-setting-the-same-hwaddr-to-lag-port-to-avoid-di.patch
renamed: src/libteam/0012-teamd-do-not-process-lacpdu-before-the-port-ifinfo-i.patch -> src/libteam/patch/0006-teamd-do-not-process-lacpdu-before-the-port-ifinfo-i.patch
renamed: src/libteam/0013-teamd-lacp-port-admin-down-recv-not-processing.patch -> src/libteam/patch/0007-Administratively-shutdown-port-channel-has-member-po.patch
- A picture of a cute animal (not mandatory but encouraged)