Skip to content

[build] Avoid using jsonpath_ng v1.8.0 in sonic slave image. #26141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liushilongbuaa merged 1 commit into from
Mar 13, 2026
+6 −2
Merged

[build] Avoid using jsonpath_ng v1.8.0 in sonic slave image. #26141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sonic-slave-bookworm/Dockerfile.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,7 +561,9 @@ RUN patch -p1 -i /disable-non-manylinux.patch /usr/local/lib/python3.11/dist-pac
RUN pip3 install fastentrypoints mock

# For DASH BMv2
RUN pip3 install jsonpath_ng
# Exclude jsonpath_ng 1.8.0 because it causes DASH pipeline failures
# In version 1.8.0, dict is flattened to a list, which causes type error in DASH.
RUN pip3 install jsonpath_ng!=1.8.0
RUN pip3 install pyyaml-include

# For building sonic_ycabled
Expand Down
4 changes: 3 additions & 1 deletion sonic-slave-trixie/Dockerfile.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,9 @@ RUN eatmydata apt-get install -y golang-go \
RUN pip3 install fastentrypoints mock

# For DASH BMv2
RUN pip3 install jsonpath_ng pyyaml-include
# Exclude jsonpath_ng 1.8.0 because it causes DASH pipeline failures
# In version 1.8.0, dict is flattened to a list, which causes type error in DASH.
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new explanatory comments could be clearer/grammatically improved (e.g., “dict is flattened to a list” / “type error”). Consider rephrasing to “a dict” and “TypeError” to match the actual exception and make the rationale easier to understand.

Suggested change
# In version 1.8.0, dict is flattened to a list, which causes type error in DASH.
# In version 1.8.0, a dict is flattened to a list, which causes a TypeError in DASH.

Copilot uses AI. Check for mistakes.
RUN pip3 install jsonpath_ng!=1.8.0 pyyaml-include

# For building sonic_ycabled
# Note: Match version in trixie
Expand Down
Loading