[build] Avoid using jsonpath_ng v1.8.0 in sonic slave image. #26141
Merged
liushilongbuaa merged 1 commit intosonic-net:masterfrom Mar 13, 2026
Merged
[build] Avoid using jsonpath_ng v1.8.0 in sonic slave image. #26141liushilongbuaa merged 1 commit intosonic-net:masterfrom
liushilongbuaa merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Yijing Yan <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SONiC build slave Docker images to avoid pulling a known-bad jsonpath_ng release that breaks DASH pipeline generation during the build (e.g., when producing libsai).
Changes:
- Exclude
jsonpath_ngversion1.8.0frompip3 installin the bookworm slave image. - Exclude
jsonpath_ngversion1.8.0frompip3 installin the trixie slave image. - Add inline comments explaining the rationale for the exclusion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| sonic-slave-bookworm/Dockerfile.j2 | Changes pip3 install jsonpath_ng to jsonpath_ng!=1.8.0 and documents the reason. |
| sonic-slave-trixie/Dockerfile.j2 | Changes pip3 install jsonpath_ng to jsonpath_ng!=1.8.0 (with pyyaml-include) and documents the reason. |
| # For DASH BMv2 | ||
| RUN pip3 install jsonpath_ng pyyaml-include | ||
| # Exclude jsonpath_ng 1.8.0 because it causes DASH pipeline failures | ||
| # In version 1.8.0, dict is flattened to a list, which causes type error in DASH. |
There was a problem hiding this comment.
The new explanatory comments could be clearer/grammatically improved (e.g., “dict is flattened to a list” / “type error”). Consider rephrasing to “a dict” and “TypeError” to match the actual exception and make the rationale easier to understand.
Suggested change
| # In version 1.8.0, dict is flattened to a list, which causes type error in DASH. | |
| # In version 1.8.0, a dict is flattened to a list, which causes a TypeError in DASH. |
Contributor
|
/azpw ms_conflict |
1 similar comment
Contributor
|
/azpw ms_conflict |
liushilongbuaa
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
When the version of jsonpath_ng is 1.8.0, the build fails on
target/debs/bookworm/libsai_1.0.0_amd64.debIn the version 1.8.0, dict is flattened to a list, which causes the above TypeError
With this change, jsonpath_ng is pinned to exclude 1.8.0 release
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)