[Mellanox] feed module info to hw-management by jianyuewu · Pull Request #24957 · sonic-net/sonic-buildimage

jianyuewu · 2025-12-31T06:50:14Z

Dependency

For 202511 branch, there is still one dependency:

Cherry-pick from master merge conflict will be automatically resolved after merging this PR: [Mellanox] Fix issue: sfp.get_temperature_info cannot detect SFP replacement #24688

HW-MGMT version 7.0050.2930 has been merged into the 202511 branch, so it is no longer an external dependency.

Why I did it

At 40°C ambient temperature with current FW+SW, some modules have >7.6% probability of reaching 75°C, which triggers false temperature warnings.
This PR implements vendor-specific temperature threshold support to eliminate false warnings while maintaining accurate temperature telemetry for monitoring purposes.

How I did it

Implemented new API for vendor-specific temperature offset adjustments:

New API:
- Add get_vendor_info() API with caching support.
Smart Module Detection:
- Cache vendor information (Manufacturer + Part Number) for each module.
- Skip redundant vendor info updates when the same module is replugged.

How to verify it

Plug in optical module -> Verify vendor info sent to HW-MGMT.
Unplug and replug same module -> Verify no redundant vendor info update.
Replace with different module -> Verify new vendor info sent.

Which release branch to backport (provide reason below if selected)

202412
202511

Tested branch (Please provide the tested image version)

202412

A picture of a cute animal (not mandatory but encouraged)

    /\_/\  
   ( o.o ) 
    > ^ <
   /|   |\
  (_|   |_)
   Cool Cat~

On first detection or module replacement, if the serial number (SN) has changed, call vendor_data_set_module() with the manufacturer (MFG) and part number (PN) to send the vendor info to hw-management. Sample output like: NOTICE pmon#thermalctld: Module 0 vendor info updated \ - manufacturer: NVIDIA part_number: MCP4Y10-N001 Signed-off-by: Jianyue Wu <jianyuew@nvidia.com>

mssonicbld · 2025-12-31T06:50:22Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-12-31T06:50:35Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-04T05:34:06Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-01-04T05:34:17Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-06T08:34:28Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-01-06T08:34:40Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-06T14:11:59Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-01-06T14:12:10Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-08T07:27:46Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-01-08T07:27:59Z

Azure Pipelines successfully started running 1 pipeline(s).

jianyuewu · 2026-01-09T01:07:25Z

++ cat /tmp/tmp.RaKi3fI9Wm
WARNING: Image format was not specified for './sonic-installer.img' and probing guessed raw.
         Automatically detecting the format is dangerous for raw images, write operations on block 0 will be restricted.
         Specify the 'raw' format explicitly to remove the restrictions.
kvm: -serial telnet:127.0.0.1:9000,server: info: QEMU waiting for connection on: disconnected:telnet:127.0.0.1:9000,server=on
[W][17:04:19.190765] pw.conf      | [          conf.c: 1182 try_load_conf()] can't load config client.conf: No such file or directory
[E][17:04:19.190780] pw.conf      | [          conf.c: 1215 pw_conf_load_conf_for_context()] can't load config client.conf: No such file or directory
+ on_exit
+ rm -f /tmp/tmp.RaKi3fI9Wm
[  FAIL LOG END  ] [ target/sonic-vs.img.gz ]
make: *** [slave.mk:1450: target/sonic-vs.img.gz] Error 1
make[1]: *** [Makefile.work:621: target/sonic-vs.img.gz] Error 2
make[1]: Leaving directory '/data/vss/_work/1/s'
make: *** [Makefile:51: target/sonic-vs.img.gz] Error 2

##[error]Bash exited with code '2'.
Finishing: Build sonic image

Seems failure is not related with this change, in vm client.conf: No such file or directory

mssonicbld · 2026-01-09T03:43:55Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-01-09T03:44:07Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2026-01-12T01:25:38Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2026-01-12T01:25:51Z

Azure Pipelines successfully started running 1 pipeline(s).

jianyuewu · 2026-01-12T01:26:59Z

@r12f @prgeor Could you help review this PR for Innolight feature? Thank you~ BTW, 202511 branch also depends on #24688.

r12f · 2026-02-01T20:26:49Z

hi @jianyuewu , do you mind to help pick this to 202412?

jianyuewu · 2026-02-02T01:16:45Z

@r12f , it is already in 202412: Azure/sonic-buildimage-msft@732a61d 😊

- Why I did it At 40°C ambient temperature with current FW+SW, some modules have >7.6% probability of reaching 75°C, which triggers false temperature warnings. This PR implements vendor-specific temperature threshold support to eliminate false warnings while maintaining accurate temperature telemetry for monitoring purposes. - How I did it Implemented new API for vendor-specific temperature offset adjustments: New API: Add get_vendor_info() API with caching support. Smart Module Detection: Cache vendor information (Manufacturer + Part Number) for each module. Skip redundant vendor info updates when the same module is replugged. - How to verify it Plug in optical module -> Verify vendor info sent to Nvidia API Unplug and replug same module -> Verify no redundant vendor info update. Replace with different module -> Verify new vendor info sent. Signed-off-by: Feng Pan <fenpan@microsoft.com>

vmittal-msft · 2026-03-09T18:08:34Z

@jianyuewu @liat-grozovik there is cherry-pick conflict for 202511. please raise a PR for 202511

- Why I did it At 40°C ambient temperature with current FW+SW, some modules have >7.6% probability of reaching 75°C, which triggers false temperature warnings. This PR implements vendor-specific temperature threshold support to eliminate false warnings while maintaining accurate temperature telemetry for monitoring purposes. - How I did it Implemented new API for vendor-specific temperature offset adjustments: New API: Add get_vendor_info() API with caching support. Smart Module Detection: Cache vendor information (Manufacturer + Part Number) for each module. Skip redundant vendor info updates when the same module is replugged. - How to verify it Plug in optical module -> Verify vendor info sent to Nvidia API Unplug and replug same module -> Verify no redundant vendor info update. Replace with different module -> Verify new vendor info sent. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com>

PriyanshTratiya · 2026-03-16T22:04:42Z

Hi @jianyuewu @liat-grozovik can you help this manual cherry-pick PR: #26212 in our effort to get it in 202511? From your description the dependency PR has been merged: #24688 so this PR should be good to go, there was a conflict which was fixed manually hence needing your review, thanks!

jianyuewu · 2026-03-17T02:14:07Z

Hi @jianyuewu @liat-grozovik can you help this manual cherry-pick PR: #26212 in our effort to get it in 202511? From your description the dependency PR has been merged: #24688 so this PR should be good to go, there was a conflict which was fixed manually hence needing your review, thanks!

@PriyanshTratiya It is very good, thanks indeed👍Review done😊

jianyuewu · 2026-03-17T02:18:23Z

Ah, so sorry, I missed previous comments about cherry-pick PR to 202511. Thanks indeed for the help👍

- Why I did it At 40°C ambient temperature with current FW+SW, some modules have >7.6% probability of reaching 75°C, which triggers false temperature warnings. This PR implements vendor-specific temperature threshold support to eliminate false warnings while maintaining accurate temperature telemetry for monitoring purposes. - How I did it Implemented new API for vendor-specific temperature offset adjustments: New API: Add get_vendor_info() API with caching support. Smart Module Detection: Cache vendor information (Manufacturer + Part Number) for each module. Skip redundant vendor info updates when the same module is replugged. - How to verify it Plug in optical module -> Verify vendor info sent to Nvidia API Unplug and replug same module -> Verify no redundant vendor info update. Replace with different module -> Verify new vendor info sent. Signed-off-by: Priyansh Tratiya <ptratiya@microsoft.com> Co-authored-by: Jianyue Wu <jianyuew@nvidia.com>

- Why I did it At 40°C ambient temperature with current FW+SW, some modules have >7.6% probability of reaching 75°C, which triggers false temperature warnings. This PR implements vendor-specific temperature threshold support to eliminate false warnings while maintaining accurate temperature telemetry for monitoring purposes. - How I did it Implemented new API for vendor-specific temperature offset adjustments: New API: Add get_vendor_info() API with caching support. Smart Module Detection: Cache vendor information (Manufacturer + Part Number) for each module. Skip redundant vendor info updates when the same module is replugged. - How to verify it Plug in optical module -> Verify vendor info sent to Nvidia API Unplug and replug same module -> Verify no redundant vendor info update. Replace with different module -> Verify new vendor info sent. Signed-off-by: dprital <drorp@nvidia.com>

jianyuewu requested a review from lguohan as a code owner December 31, 2025 06:50

jianyuewu marked this pull request as draft December 31, 2025 06:52

keboliu added the Request for 202511 Branch label Dec 31, 2025

mssonicbld added the Cherry Pick Conflict_202511 label Dec 31, 2025

keboliu requested a review from Junchao-Mellanox December 31, 2025 06:54

Junchao-Mellanox approved these changes Dec 31, 2025

View reviewed changes

Merge branch 'master' into master_innolight_thermal_algo

378f228

Merge branch 'master' into master_innolight_thermal_algo

a3915f1

Merge branch 'master' into master_innolight_thermal_algo

3cacdeb

Merge branch 'master' into master_innolight_thermal_algo

89dc471

Merge branch 'master' into master_innolight_thermal_algo

f389054

Merge branch 'master' into master_innolight_thermal_algo

761171c

Merge branch 'master' into master_innolight_thermal_algo

9e86abe

liat-grozovik approved these changes Jan 13, 2026

View reviewed changes

liat-grozovik added the Request for msft-202412 Branch label Jan 13, 2026

mssonicbld added the Cherry Pick Conflict_msft-202412 label Jan 13, 2026

liat-grozovik merged commit 20b3670 into sonic-net:master Jan 13, 2026
13 checks passed

vmittal-msft added the Approved for 202511 Branch label Jan 15, 2026

r12f added Approved for msft-202412 Branch Included in msft-202412 Branch and removed Cherry Pick Conflict_msft-202412 labels Feb 27, 2026

mssonicbld added the Cherry Pick Conflict_msft-202412 label Feb 27, 2026

jianyuewu deleted the master_innolight_thermal_algo branch March 17, 2026 02:14

r12f added Included in 202511 Branch Approved for 202511 Branch and removed Request for 202511 Branch Approved for 202511 Branch Cherry Pick Conflict_202511 labels Mar 18, 2026

mssonicbld added the Cherry Pick Conflict_202511 label Mar 18, 2026

Conversation

jianyuewu commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

mssonicbld commented Dec 31, 2025

Uh oh!

azure-pipelines bot commented Dec 31, 2025

Uh oh!

mssonicbld commented Jan 4, 2026

Uh oh!

azure-pipelines bot commented Jan 4, 2026

Uh oh!

mssonicbld commented Jan 6, 2026

Uh oh!

azure-pipelines bot commented Jan 6, 2026

Uh oh!

mssonicbld commented Jan 6, 2026

Uh oh!

azure-pipelines bot commented Jan 6, 2026

Uh oh!

mssonicbld commented Jan 8, 2026

Uh oh!

azure-pipelines bot commented Jan 8, 2026

Uh oh!

jianyuewu commented Jan 9, 2026

Uh oh!

mssonicbld commented Jan 9, 2026

Uh oh!

azure-pipelines bot commented Jan 9, 2026

Uh oh!

mssonicbld commented Jan 12, 2026

Uh oh!

azure-pipelines bot commented Jan 12, 2026

Uh oh!

jianyuewu commented Jan 12, 2026

Uh oh!

Uh oh!

r12f commented Feb 1, 2026

Uh oh!

jianyuewu commented Feb 2, 2026

Uh oh!

vmittal-msft commented Mar 9, 2026

Uh oh!

PriyanshTratiya commented Mar 16, 2026

Uh oh!

jianyuewu commented Mar 17, 2026

Uh oh!

jianyuewu commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jianyuewu commented Dec 31, 2025 •

edited

Loading

jianyuewu commented Mar 17, 2026 •

edited

Loading