[Mellanox] Fix issue: sfp.get_temperature_info cannot detect SFP replacement#24688
Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom Dec 15, 2025
Merged
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…acement Signed-off-by: Junchao-Mellanox <[email protected]>
Junchao-Mellanox
force-pushed
the
master-get-serial
branch
from
a5809de to
1381a19
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jianyuewu
approved these changes
Dec 3, 2025
keboliu
approved these changes
Dec 3, 2025
liat-grozovik
approved these changes
Dec 15, 2025
Collaborator
9 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#1895 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
hdwhdw
pushed a commit
to hdwhdw/sonic-buildimage
that referenced
this pull request
Dec 18, 2025
…acement (sonic-net#24688) - Why I did it CMIS module cached module serial in memory, it causes an issue that sfp.get_temperature_info cannot detect SFP replacement. The PR is a fix for the issue. - How I did it Implement a private sfp._get_serial which reads module serial from EEPROM instead of memory. - How to verify it Manual test passed Unit test passed Signed-off-by: Junchao-Mellanox <[email protected]> Signed-off-by: Dawei Huang <[email protected]>
xwjiang-ms
pushed a commit
to xwjiang-ms/sonic-buildimage
that referenced
this pull request
Dec 22, 2025
…acement (sonic-net#24688) - Why I did it CMIS module cached module serial in memory, it causes an issue that sfp.get_temperature_info cannot detect SFP replacement. The PR is a fix for the issue. - How I did it Implement a private sfp._get_serial which reads module serial from EEPROM instead of memory. - How to verify it Manual test passed Unit test passed Signed-off-by: Junchao-Mellanox <[email protected]> Signed-off-by: xiaweijiang <[email protected]>
Merged
9 tasks
2 tasks
jasonbridges
pushed a commit
to jasonbridges/sonic-buildimage
that referenced
this pull request
Jan 22, 2026
…acement (sonic-net#24688) - Why I did it CMIS module cached module serial in memory, it causes an issue that sfp.get_temperature_info cannot detect SFP replacement. The PR is a fix for the issue. - How I did it Implement a private sfp._get_serial which reads module serial from EEPROM instead of memory. - How to verify it Manual test passed Unit test passed Signed-off-by: Junchao-Mellanox <[email protected]>
Collaborator
|
Hi @vmittal-msft, it seems the cherry-pick to 202511 hasn't started yet. Would you please help to check? |
vmittal-msft
added
Approved for 202511 Branch
and removed
Approved for 202511 Branch
labels
9 tasks
Collaborator
|
Cherry-pick PR to 202511: #25289 |
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Mar 6, 2026
…acement (sonic-net#24688) - Why I did it CMIS module cached module serial in memory, it causes an issue that sfp.get_temperature_info cannot detect SFP replacement. The PR is a fix for the issue. - How I did it Implement a private sfp._get_serial which reads module serial from EEPROM instead of memory. - How to verify it Manual test passed Unit test passed Signed-off-by: Junchao-Mellanox <[email protected]> Signed-off-by: Feng Pan <[email protected]>
8 tasks
dprital
pushed a commit
that referenced
this pull request
Mar 19, 2026
…acement (#24688) - Why I did it CMIS module cached module serial in memory, it causes an issue that sfp.get_temperature_info cannot detect SFP replacement. The PR is a fix for the issue. - How I did it Implement a private sfp._get_serial which reads module serial from EEPROM instead of memory. - How to verify it Manual test passed Unit test passed Signed-off-by: Junchao-Mellanox <[email protected]> Signed-off-by: dprital <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
CMIS module cached module serial in memory, it causes an issue that
sfp.get_temperature_infocannot detect SFP replacement. The PR is a fix for the issue.Work item tracking
How I did it
Implement a private
sfp._get_serialwhich reads module serial from EEPROM instead of memory.How to verify it
Manual test passed
Unit test passed
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)