Skip to content

Download and enable grpcurl in ptf docker. #24587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yxieca merged 3 commits into from
Dec 5, 2025
Merged

Download and enable grpcurl in ptf docker. #24587

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8356e6
Download grpcurl in ptf docker.
ryanzhu706 Nov 20, 2025
82a22b3
Update dockers/docker-ptf/Dockerfile.j2
ryanzhu706 Nov 20, 2025
46f6637
Merge branch 'master' into grpcurl_in_ptf
yxieca Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion dockers/docker-ptf/Dockerfile.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,23 @@ RUN apt-get update \
iptables \
wireshark-common \
freeradius \
quilt
quilt \
{% if CONFIGURED_ARCH == "armhf" %}
&& GRPCURL_ARCH=linux_armv6 \
{% elif CONFIGURED_ARCH == "arm64" %}
&& GRPCURL_ARCH=linux_arm64 \
{% else %}
&& GRPCURL_ARCH=linux_x86_64 \
{% endif %}
&& GRPCURL_VERSION=1.9.1 && \
curl -L "https://github.com/fullstorydev/grpcurl/releases/download/v${GRPCURL_VERSION}/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz" \
-o /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \
cd /tmp && \
tar xvf grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \
mv grpcurl /usr/local/bin/grpcurl && \
chmod +x /usr/local/bin/grpcurl && \
rm -f /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \
Comment on lines +110 to +115
Copy link

Copilot AI Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The grpcurl download lacks checksum verification, which poses a security risk. Consider adding SHA256 checksum verification after downloading to ensure the integrity and authenticity of the downloaded binary. This prevents potential security vulnerabilities from compromised or tampered packages.

Suggested change
-o /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \
cd /tmp && \
tar xvf grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \
mv grpcurl /usr/local/bin/grpcurl && \
chmod +x /usr/local/bin/grpcurl && \
rm -f /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \
-o /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \
curl -L "https://github.com/fullstorydev/grpcurl/releases/download/v${GRPCURL_VERSION}/checksums.txt" \
-o /tmp/grpcurl_${GRPCURL_VERSION}_checksums.txt && \
cd /tmp && \
grep "grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz" grpcurl_${GRPCURL_VERSION}_checksums.txt > grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.sha256 && \
sha256sum -c grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.sha256 && \
tar xvf grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \
mv grpcurl /usr/local/bin/grpcurl && \
chmod +x /usr/local/bin/grpcurl && \
rm -f /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \
rm -f /tmp/grpcurl_${GRPCURL_VERSION}_checksums.txt && \
rm -f /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.sha256 && \

Copilot uses AI. Check for mistakes.
rm -rf /var/lib/apt/lists/*

{% if PTF_ENV_PY_VER == "py3" %}
RUN update-alternatives --install /usr/bin/python python /usr/bin/python3 1 \
Expand Down
Loading