Download and enable grpcurl in ptf docker.#24587
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR adds the grpcurl tool (version 1.9.1) to the PTF (Packet Test Framework) Docker image. The tool is downloaded as a pre-compiled binary from GitHub releases and installed to /usr/local/bin/grpcurl. This enables gRPC testing capabilities within the PTF environment.
Key changes:
- Downloads and installs grpcurl 1.9.1 binary from GitHub releases
- Integrates the installation into the existing apt-get RUN command chain
- Cleans up temporary files after installation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| -o /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \ | ||
| cd /tmp && \ | ||
| tar xvf grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \ | ||
| mv grpcurl /usr/local/bin/grpcurl && \ | ||
| chmod +x /usr/local/bin/grpcurl && \ | ||
| rm -f /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \ |
There was a problem hiding this comment.
The grpcurl download lacks checksum verification, which poses a security risk. Consider adding SHA256 checksum verification after downloading to ensure the integrity and authenticity of the downloaded binary. This prevents potential security vulnerabilities from compromised or tampered packages.
| -o /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \ | |
| cd /tmp && \ | |
| tar xvf grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \ | |
| mv grpcurl /usr/local/bin/grpcurl && \ | |
| chmod +x /usr/local/bin/grpcurl && \ | |
| rm -f /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \ | |
| -o /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \ | |
| curl -L "https://github.com/fullstorydev/grpcurl/releases/download/v${GRPCURL_VERSION}/checksums.txt" \ | |
| -o /tmp/grpcurl_${GRPCURL_VERSION}_checksums.txt && \ | |
| cd /tmp && \ | |
| grep "grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz" grpcurl_${GRPCURL_VERSION}_checksums.txt > grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.sha256 && \ | |
| sha256sum -c grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.sha256 && \ | |
| tar xvf grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \ | |
| mv grpcurl /usr/local/bin/grpcurl && \ | |
| chmod +x /usr/local/bin/grpcurl && \ | |
| rm -f /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.tar.gz && \ | |
| rm -f /tmp/grpcurl_${GRPCURL_VERSION}_checksums.txt && \ | |
| rm -f /tmp/grpcurl_${GRPCURL_VERSION}_${GRPCURL_ARCH}.sha256 && \ |
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 24587 in repo sonic-net/sonic-buildimage |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Added grpcurl binary to PTF Docker containers to enable gRPC testing capabilities for SONiC test framework. This supports upcoming gNOI (gRPC Network Operations Interface) testing infrastructure that requires a lightweight gRPC client tool. Background: SONiC is moving towards gRPC-based management interfaces (gNMI, gNOI, gNSI) Current test framework lacks unified gRPC testing capabilities grpcurl provides a simple, dependency-free solution for gRPC operations Eliminates need for protocol buffer compilation in test environments Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Ying Xie <yxieca@users.noreply.github.com>
Added grpcurl binary to PTF Docker containers to enable gRPC testing capabilities for SONiC test framework. This supports upcoming gNOI (gRPC Network Operations Interface) testing infrastructure that requires a lightweight gRPC client tool. Background: SONiC is moving towards gRPC-based management interfaces (gNMI, gNOI, gNSI) Current test framework lacks unified gRPC testing capabilities grpcurl provides a simple, dependency-free solution for gRPC operations Eliminates need for protocol buffer compilation in test environments Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Ying Xie <yxieca@users.noreply.github.com> Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
Added grpcurl binary to PTF Docker containers to enable gRPC testing capabilities for SONiC test framework. This supports upcoming gNOI (gRPC Network Operations Interface) testing infrastructure that requires a lightweight gRPC client tool. Background: SONiC is moving towards gRPC-based management interfaces (gNMI, gNOI, gNSI) Current test framework lacks unified gRPC testing capabilities grpcurl provides a simple, dependency-free solution for gRPC operations Eliminates need for protocol buffer compilation in test environments Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Ying Xie <yxieca@users.noreply.github.com> Signed-off-by: xiaweijiang <xiaweijiang@microsoft.com>
Added grpcurl binary to PTF Docker containers to enable gRPC testing capabilities for SONiC test framework. This supports upcoming gNOI (gRPC Network Operations Interface) testing infrastructure that requires a lightweight gRPC client tool. Background: SONiC is moving towards gRPC-based management interfaces (gNMI, gNOI, gNSI) Current test framework lacks unified gRPC testing capabilities grpcurl provides a simple, dependency-free solution for gRPC operations Eliminates need for protocol buffer compilation in test environments Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Ying Xie <yxieca@users.noreply.github.com>
Added grpcurl binary to PTF Docker containers to enable gRPC testing capabilities for SONiC test framework. This supports upcoming gNOI (gRPC Network Operations Interface) testing infrastructure that requires a lightweight gRPC client tool. Background: SONiC is moving towards gRPC-based management interfaces (gNMI, gNOI, gNSI) Current test framework lacks unified gRPC testing capabilities grpcurl provides a simple, dependency-free solution for gRPC operations Eliminates need for protocol buffer compilation in test environments Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Ying Xie <yxieca@users.noreply.github.com> Signed-off-by: Feng Pan <fenpan@microsoft.com>
Why I did it
Added grpcurl binary to PTF Docker containers to enable gRPC testing capabilities for SONiC test framework. This supports upcoming gNOI (gRPC Network Operations Interface) testing infrastructure that requires a lightweight gRPC client tool.
Background:
Work item tracking
How I did it
Download and enable grpcurl in ptf docker
Why I did it
Added grpcurl binary to PTF Docker containers to enable gRPC testing capabilities for SONiC test framework. This supports upcoming gNOI (gRPC Network Operations Interface) testing infrastructure that requires a lightweight gRPC client tool.
Background:
How I did it
/usr/local/bin/grpcurlTechnical Details:
How to verify it
Description for the changelog
Add grpcurl v1.9.1 to PTF Docker container for gRPC testing support
Dependencies/Related Work
Additional Notes
How to verify it
Download and enable grpcurl in ptf docker
Why I did it
Added grpcurl binary to PTF Docker containers to enable gRPC testing capabilities for SONiC test framework. This supports upcoming gNOI (gRPC Network Operations Interface) testing infrastructure that requires a lightweight gRPC client tool.
Background:
How I did it
/usr/local/bin/grpcurlTechnical Details:
How to verify it
Description for the changelog
Add grpcurl v1.9.1 to PTF Docker container for gRPC testing support
Dependencies/Related Work
Additional Notes
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)