Skip to content

Adding HW SKU files for arista_7280r4(k)_32qf_32df#24206

Merged
rlhui merged 16 commits intosonic-net:masterfrom
arista-nwolfe:master-citrine-hwsku-files
Dec 5, 2025
Merged

Adding HW SKU files for arista_7280r4(k)_32qf_32df#24206
rlhui merged 16 commits intosonic-net:masterfrom
arista-nwolfe:master-citrine-hwsku-files

Conversation

@arista-nwolfe
Copy link
Contributor

Creating and populating the /device/ directory for our arista_7280r4(k)_32qf_32df SKU.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arista-nwolfe arista-nwolfe requested a review from lguohan as a code owner October 6, 2025 17:16
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1. Fixed Scd PCI addrs
2. Fixed PHY library name
3. Fixed FEC encoding to match SAI convension
4. Fixed Ethernet-Rec0 lane number
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kenneth-arista
Copy link
Collaborator

@rlhui @arlakshm @tjchadaga

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -0,0 +1,4 @@
start_chassis_db=1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need chassis_db.conf for single asic device?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not all the changes have gone in for running single-asic without chassis_db yet (E.G. sonic-net/sonic-swss#3847)
So for now we're still running with chassis_db.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is merged. Can you remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried removing the chassisdb.conf file but I get OA crashes

ERR swss#orchagent: :- getDbInfo: Failed to find CHASSIS_APP_DB database in : key
INFO swss#supervisord: orchagent terminate called after throwing an instance of 'std::out_of_range'
INFO swss#supervisord: orchagent   what():  Failed to find CHASSIS_APP_DB database in : key

Can we work on removing the dependency on chassis_app_db after this PR goes through?
We've done all our testing on UT2 with CHASSIS_APP_DB until now, it's fairly last minute to try to pull it out as a change in this PR.

Copy link
Contributor Author

@arista-nwolfe arista-nwolfe Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the problem is that even though sonic-net/sonic-swss#3847 merged the sonic-swss bump up hasn't occurred in master so the changes aren't present in the latest image.
But I'd still prefer to incorporate this in a subsequent PR after we've done more exhaustive testing without CHASSIS_APP_DB.
If we try to stall this change for that it may miss the 202511 cut off

SYNCD_SHM_SIZE=1gb
dmasize=64M
usemsi=1
disaggregated_chassis=1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this disaggregated_chassis=1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not need this. For single asic we will check on the chassis_db.conf file existence

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above, we've been testing this with chassis_app_db until now, can we make this change in a subsequent PR once we've shaken out all the issues with running without chassis_app_db?

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rlhui rlhui merged commit cf7dbe0 into sonic-net:master Dec 5, 2025
22 checks passed
kewei-arista pushed a commit to kewei-arista/sonic-buildimage that referenced this pull request Dec 8, 2025
* Adding HW SKU files for arista_7280r4(k)_32qf_32df

* Adding new brcm soc properties to the permitted list

* Added various fixes on Citrine platform

1. Fixed Scd PCI addrs
2. Fixed PHY library name
3. Fixed FEC encoding to match SAI convension
4. Fixed Ethernet-Rec0 lane number

* Updating SKU files to fix some mistakes with the mappings

* Fix typo on phy12_config.json

* Set PSU LED as uncontrollable

* Fix scd pci addrs

* Update gearbox firmware filename

* Fixing port_config.ini alias and generate_port_lists

* Renaming SKUs to include -64O

Arista-7280R4-32QF-32DF -> Arista-7280R4-32QF-32DF-64O
Arista-7280R4K-32QF-32DF -> Arista-7280R4K-32QF-32DF-64O

* Add and update L1 tuning files

* Add workaround for running Q3D-A1 on SAI13

CS00012432596

* Ignore nvme sensors returning IO errors

* Update PSU fan speed controllable attribute
hdwhdw pushed a commit to hdwhdw/sonic-buildimage that referenced this pull request Dec 18, 2025
* Adding HW SKU files for arista_7280r4(k)_32qf_32df

* Adding new brcm soc properties to the permitted list

* Added various fixes on Citrine platform

1. Fixed Scd PCI addrs
2. Fixed PHY library name
3. Fixed FEC encoding to match SAI convension
4. Fixed Ethernet-Rec0 lane number

* Updating SKU files to fix some mistakes with the mappings

* Fix typo on phy12_config.json

* Set PSU LED as uncontrollable

* Fix scd pci addrs

* Update gearbox firmware filename

* Fixing port_config.ini alias and generate_port_lists

* Renaming SKUs to include -64O

Arista-7280R4-32QF-32DF -> Arista-7280R4-32QF-32DF-64O
Arista-7280R4K-32QF-32DF -> Arista-7280R4K-32QF-32DF-64O

* Add and update L1 tuning files

* Add workaround for running Q3D-A1 on SAI13

CS00012432596

* Ignore nvme sensors returning IO errors

* Update PSU fan speed controllable attribute

Signed-off-by: Dawei Huang <daweihuang@microsoft.com>
xwjiang-ms pushed a commit to xwjiang-ms/sonic-buildimage that referenced this pull request Dec 22, 2025
* Adding HW SKU files for arista_7280r4(k)_32qf_32df

* Adding new brcm soc properties to the permitted list

* Added various fixes on Citrine platform

1. Fixed Scd PCI addrs
2. Fixed PHY library name
3. Fixed FEC encoding to match SAI convension
4. Fixed Ethernet-Rec0 lane number

* Updating SKU files to fix some mistakes with the mappings

* Fix typo on phy12_config.json

* Set PSU LED as uncontrollable

* Fix scd pci addrs

* Update gearbox firmware filename

* Fixing port_config.ini alias and generate_port_lists

* Renaming SKUs to include -64O

Arista-7280R4-32QF-32DF -> Arista-7280R4-32QF-32DF-64O
Arista-7280R4K-32QF-32DF -> Arista-7280R4K-32QF-32DF-64O

* Add and update L1 tuning files

* Add workaround for running Q3D-A1 on SAI13

CS00012432596

* Ignore nvme sensors returning IO errors

* Update PSU fan speed controllable attribute

Signed-off-by: xiaweijiang <xiaweijiang@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202511: #25133

jasonbridges pushed a commit to jasonbridges/sonic-buildimage that referenced this pull request Jan 22, 2026
* Adding HW SKU files for arista_7280r4(k)_32qf_32df

* Adding new brcm soc properties to the permitted list

* Added various fixes on Citrine platform

1. Fixed Scd PCI addrs
2. Fixed PHY library name
3. Fixed FEC encoding to match SAI convension
4. Fixed Ethernet-Rec0 lane number

* Updating SKU files to fix some mistakes with the mappings

* Fix typo on phy12_config.json

* Set PSU LED as uncontrollable

* Fix scd pci addrs

* Update gearbox firmware filename

* Fixing port_config.ini alias and generate_port_lists

* Renaming SKUs to include -64O

Arista-7280R4-32QF-32DF -> Arista-7280R4-32QF-32DF-64O
Arista-7280R4K-32QF-32DF -> Arista-7280R4K-32QF-32DF-64O

* Add and update L1 tuning files

* Add workaround for running Q3D-A1 on SAI13

CS00012432596

* Ignore nvme sensors returning IO errors

* Update PSU fan speed controllable attribute
@mssonicbld
Copy link
Collaborator

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!!
#25133

5 similar comments
@mssonicbld
Copy link
Collaborator

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!!
#25133

@mssonicbld
Copy link
Collaborator

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!!
#25133

@mssonicbld
Copy link
Collaborator

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!!
#25133

@mssonicbld
Copy link
Collaborator

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!!
#25133

@mssonicbld
Copy link
Collaborator

@arista-nwolfe cherry pick PR didn't pass PR checker. Please check!!!
#25133

FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Mar 6, 2026
* Adding HW SKU files for arista_7280r4(k)_32qf_32df

* Adding new brcm soc properties to the permitted list

* Added various fixes on Citrine platform

1. Fixed Scd PCI addrs
2. Fixed PHY library name
3. Fixed FEC encoding to match SAI convension
4. Fixed Ethernet-Rec0 lane number

* Updating SKU files to fix some mistakes with the mappings

* Fix typo on phy12_config.json

* Set PSU LED as uncontrollable

* Fix scd pci addrs

* Update gearbox firmware filename

* Fixing port_config.ini alias and generate_port_lists

* Renaming SKUs to include -64O

Arista-7280R4-32QF-32DF -> Arista-7280R4-32QF-32DF-64O
Arista-7280R4K-32QF-32DF -> Arista-7280R4K-32QF-32DF-64O

* Add and update L1 tuning files

* Add workaround for running Q3D-A1 on SAI13

CS00012432596

* Ignore nvme sensors returning IO errors

* Update PSU fan speed controllable attribute

Signed-off-by: Feng Pan <fenpan@microsoft.com>
rlhui pushed a commit that referenced this pull request Mar 8, 2026
sonic-net/sonic-swss#3926 introduces the ability to indicate whether a gearbox phy supports macsec or not.
This allows the macsecorch to send the macsec SAI calls to the switching asic (syncd) instead of the gearbox phy (gbsyncd).

arista_7280r4(k)_32qf_32df is a platform that has this same behavior (GB doesn't support macsec).

The parent PR for this SKU is #24206

Signed-off-by: Nathan Wolfe <nwolfe@arista.com>
Co-authored-by: Arvindsrinivasan Lakshmi Narasimhan <55814491+arlakshm@users.noreply.github.com>
mssonicbld added a commit to mssonicbld/sonic-buildimage that referenced this pull request Mar 8, 2026
This change depends on sonic-net/sonic-swss#3926 merging first.
sonic-net/sonic-swss#3926 introduces the ability to indicate whether a gearbox phy supports macsec or not.
This allows the macsecorch to send the macsec SAI calls to the switching asic (syncd) instead of the gearbox phy (gbsyncd).

`arista_7280r4(k)_32qf_32df` is a platform that has this same behavior (GB doesn't support macsec).

The parent PR for this SKU is sonic-net#24206

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 202205
- [ ] 202211
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [x] 202511

Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
jackson-micas pushed a commit to jackson-micas/sonic-buildimage that referenced this pull request Mar 10, 2026
sonic-net/sonic-swss#3926 introduces the ability to indicate whether a gearbox phy supports macsec or not.
This allows the macsecorch to send the macsec SAI calls to the switching asic (syncd) instead of the gearbox phy (gbsyncd).

arista_7280r4(k)_32qf_32df is a platform that has this same behavior (GB doesn't support macsec).

The parent PR for this SKU is sonic-net#24206

Signed-off-by: Nathan Wolfe <nwolfe@arista.com>
Co-authored-by: Arvindsrinivasan Lakshmi Narasimhan <55814491+arlakshm@users.noreply.github.com>
Signed-off-by: jackson <jackson@micasnetworks.com>
mssonicbld added a commit that referenced this pull request Mar 12, 2026
…#25960)

This change depends on sonic-net/sonic-swss#3926 merging first.
sonic-net/sonic-swss#3926 introduces the ability to indicate whether a gearbox phy supports macsec or not.
This allows the macsecorch to send the macsec SAI calls to the switching asic (syncd) instead of the gearbox phy (gbsyncd).

`arista_7280r4(k)_32qf_32df` is a platform that has this same behavior (GB doesn't support macsec).

The parent PR for this SKU is #24206

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 202205
- [ ] 202211
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [x] 202511

Signed-off-by: Sonic Build Admin <sonicbld@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants