Skip to content

Support for single ASIC VOQ Fixed-Systems#24163

Merged
rlhui merged 5 commits intosonic-net:masterfrom
nexthop-ai:voq_fs_mode
Nov 21, 2025
Merged

Support for single ASIC VOQ Fixed-Systems#24163
rlhui merged 5 commits intosonic-net:masterfrom
nexthop-ai:voq_fs_mode

Conversation

@lakshmi-nexthop
Copy link
Contributor

Why I did it

Fixed system VOQs do not have chassis app DB

Work item tracking
  • Microsoft ADO (number only):

How I did it

  • updated a function that checks for chassis to include if the voq is a fixed system
  • swss.sh cleanup function is updated to check for chassis app db first

How to verify it

  • bring up the FS in voq mode

Tested branch (Please provide the tested image version)

master

Description for the changelog

Support for single ASIC FS

PR#3847 under sonic-swss

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lakshmi-nexthop lakshmi-nexthop marked this pull request as ready for review October 1, 2025 01:47
@abdosi abdosi changed the title Support for single ASIC FS Support for single ASIC VOQ Fixed-Systems Oct 1, 2025
abdosi
abdosi previously approved these changes Oct 1, 2025
@abdosi abdosi requested review from arlakshm and mlok-nokia October 1, 2025 17:22
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rlhui rlhui merged commit bb0612a into sonic-net:master Nov 21, 2025
21 checks passed
@saiarcot895
Copy link
Contributor

@lakshmi-nexthop This is causing sonic-utilities tests to break, see https://dev.azure.com/mssonic/build/_build/results?buildId=985195&view=results

@lakshmi-nexthop
Copy link
Contributor Author

lakshmi-nexthop commented Nov 24, 2025

@lakshmi-nexthop This is causing sonic-utilities tests to break, see https://dev.azure.com/mssonic/build/_build/results?buildId=985195&view=results

Ack. I am looking into how to fix this issue.

@saiarcot895 Sent PR to fix the tests. sonic-net/sonic-utilities#4134

saiarcot895 added a commit to saiarcot895/sonic-buildimage that referenced this pull request Nov 24, 2025
ashutosh-agrawal pushed a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request Nov 30, 2025
Fixed system single asic VOQs do not have chassis app DB

How I did it
updated a function that checks for chassis to include if the voq is a fixed system
swss.sh cleanup function is updated to check for chassis app db first
hdwhdw pushed a commit to hdwhdw/sonic-buildimage that referenced this pull request Dec 2, 2025
Fixed system single asic VOQs do not have chassis app DB

How I did it
updated a function that checks for chassis to include if the voq is a fixed system
swss.sh cleanup function is updated to check for chassis app db first
NavdhaJindal pushed a commit to NavdhaJindal/sonic-buildimage that referenced this pull request Dec 2, 2025
Fixed system single asic VOQs do not have chassis app DB

How I did it
updated a function that checks for chassis to include if the voq is a fixed system
swss.sh cleanup function is updated to check for chassis app db first

Signed-off-by: Navdha Jindal <navdhajindal@microsoft.com>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202511: #24701

FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Dec 4, 2025
Fixed system single asic VOQs do not have chassis app DB

How I did it
updated a function that checks for chassis to include if the voq is a fixed system
swss.sh cleanup function is updated to check for chassis app db first

Signed-off-by: Feng Pan <fenpan@microsoft.com>
@mssonicbld
Copy link
Collaborator

@lakshmi-nexthop cherry pick PR didn't pass PR checker. Please check!!!
#24701

xwjiang-ms pushed a commit to xwjiang-ms/sonic-buildimage that referenced this pull request Dec 22, 2025
Fixed system single asic VOQs do not have chassis app DB

How I did it
updated a function that checks for chassis to include if the voq is a fixed system
swss.sh cleanup function is updated to check for chassis app db first

Signed-off-by: xiaweijiang <xiaweijiang@microsoft.com>
mssonicbld added a commit to mssonicbld/sonic-utilities that referenced this pull request Jan 6, 2026
…port

#### What I did
Currently bgp v4 and v6 chassis tests rely on switch type to be voq. But with recent single asic voq fixed system feature, this assumption has been changed.
So updated these tests to use is_voq_chassis() function instead of switch_type

Please see below PR for context:
sonic-net/sonic-buildimage#24163

#### How I did it
Mocked is_voq_chassis() function

#### How to verify it
Run UT

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [X] 202511
mssonicbld added a commit to sonic-net/sonic-utilities that referenced this pull request Jan 6, 2026
…port (#4178)

#### What I did
Currently bgp v4 and v6 chassis tests rely on switch type to be voq. But with recent single asic voq fixed system feature, this assumption has been changed.
So updated these tests to use is_voq_chassis() function instead of switch_type

Please see below PR for context:
sonic-net/sonic-buildimage#24163

#### How I did it
Mocked is_voq_chassis() function

#### How to verify it
Run UT

### Back port request
- [ ] 202205
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
- [X] 202511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

9 participants