frr bgp conf template handling switch_type == voq#24158
Merged
rlhui merged 1 commit intosonic-net:masterfrom Nov 21, 2025
Merged
frr bgp conf template handling switch_type == voq#24158rlhui merged 1 commit intosonic-net:masterfrom
rlhui merged 1 commit intosonic-net:masterfrom
Conversation
saravanan-nexthop
requested review from
StormLiangMS and
lguohan
as code owners
|
|
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
saravanan-nexthop
force-pushed
the
saravanan.voqbgpconf
branch
from
b5d3065 to
7d8c7e6
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tjchadaga
reviewed
Oct 22, 2025
when switch_type is voq, it could either be a single asic or multi-asic or even a voq_chassis bgpd.main.conf.j2 needs to handle the single asic case differently than the multi-asic or voq_chassis. A new filter file_exists is now used within j2 files to look for chasssisdb.conf and determine if its a voq_chassis Incase of unit test, the test just runs with a json file only. Hence using a chassisdb_conf_present in it to represent the chassis case When assigning the loopback0 address, handle the single asic voq case.
saravanan-nexthop
force-pushed
the
saravanan.voqbgpconf
branch
from
7d8c7e6 to
d025650
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tjchadaga
approved these changes
Nov 12, 2025
Contributor
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azpw ms_conflict |
arlakshm
approved these changes
Nov 14, 2025
Contributor
|
/azpw ms_conflict |
Contributor
|
/azpw ms_conflict |
1 similar comment
Contributor
|
/azpw ms_conflict |
ashutosh-agrawal
pushed a commit
to AnantKishorSharma/sonic-buildimage
that referenced
this pull request
Nov 30, 2025
when switch_type is voq, it could either be a single asic or multi-asic or even a voq_chassis bgpd.main.conf.j2 needs to handle the single asic case differently than the multi-asic or voq_chassis. A new filter file_exists is now used within j2 files to look for chasssisdb.conf and determine if its a voq_chassis Incase of unit test, the test just runs with a json file only. Hence using a chassisdb_conf_present in it to represent the chassis case When assigning the loopback0 address, handle the single asic voq case.
hdwhdw
pushed a commit
to hdwhdw/sonic-buildimage
that referenced
this pull request
Dec 2, 2025
when switch_type is voq, it could either be a single asic or multi-asic or even a voq_chassis bgpd.main.conf.j2 needs to handle the single asic case differently than the multi-asic or voq_chassis. A new filter file_exists is now used within j2 files to look for chasssisdb.conf and determine if its a voq_chassis Incase of unit test, the test just runs with a json file only. Hence using a chassisdb_conf_present in it to represent the chassis case When assigning the loopback0 address, handle the single asic voq case.
NavdhaJindal
pushed a commit
to NavdhaJindal/sonic-buildimage
that referenced
this pull request
Dec 2, 2025
when switch_type is voq, it could either be a single asic or multi-asic or even a voq_chassis bgpd.main.conf.j2 needs to handle the single asic case differently than the multi-asic or voq_chassis. A new filter file_exists is now used within j2 files to look for chasssisdb.conf and determine if its a voq_chassis Incase of unit test, the test just runs with a json file only. Hence using a chassisdb_conf_present in it to represent the chassis case When assigning the loopback0 address, handle the single asic voq case. Signed-off-by: Navdha Jindal <navdhajindal@microsoft.com>
9 tasks
Collaborator
|
Cherry-pick PR to 202511: #24703 |
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Dec 4, 2025
when switch_type is voq, it could either be a single asic or multi-asic or even a voq_chassis bgpd.main.conf.j2 needs to handle the single asic case differently than the multi-asic or voq_chassis. A new filter file_exists is now used within j2 files to look for chasssisdb.conf and determine if its a voq_chassis Incase of unit test, the test just runs with a json file only. Hence using a chassisdb_conf_present in it to represent the chassis case When assigning the loopback0 address, handle the single asic voq case. Signed-off-by: Feng Pan <fenpan@microsoft.com>
Collaborator
|
@saravanan-nexthop cherry pick PR didn't pass PR checker. Please check!!! |
4 similar comments
Collaborator
|
@saravanan-nexthop cherry pick PR didn't pass PR checker. Please check!!! |
Collaborator
|
@saravanan-nexthop cherry pick PR didn't pass PR checker. Please check!!! |
Collaborator
|
@saravanan-nexthop cherry pick PR didn't pass PR checker. Please check!!! |
Collaborator
|
@saravanan-nexthop cherry pick PR didn't pass PR checker. Please check!!! |
xwjiang-ms
pushed a commit
to xwjiang-ms/sonic-buildimage
that referenced
this pull request
Dec 22, 2025
when switch_type is voq, it could either be a single asic or multi-asic or even a voq_chassis bgpd.main.conf.j2 needs to handle the single asic case differently than the multi-asic or voq_chassis. A new filter file_exists is now used within j2 files to look for chasssisdb.conf and determine if its a voq_chassis Incase of unit test, the test just runs with a json file only. Hence using a chassisdb_conf_present in it to represent the chassis case When assigning the loopback0 address, handle the single asic voq case. Signed-off-by: xiaweijiang <xiaweijiang@microsoft.com>
mssonicbld
added
Included in 202511 Branch
and removed
Created PR to 202511 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bgpd.main.conf.j2 needs to handle the single asic case differently than the multi-asic or voq_chassis.
Looks like DEVICE_METADATA doesn't have any chassisdb specific field.
Hence we are using file_exists check for /usr/share/sonic/platform/chassisdb.conf to confirm voq_chassis.
The unit tests in bgpcfg/tests for chassis cannot pass the file_exists
check. Hence use the chassisdb_conf_present flag in DEVICE_METADATA for that
2. When assigning the loopback0 address, handle the single asic voq case.
Why I did it
bgpd.main.conf.j2 needs to handle the single asic voq case differently than the multi-asic or voq_chassis.
Work item tracking
How I did it
Modifying bgpd.main.conf.j2 and peer-group.conf.j2. Also modified the related test files
How to verify it
Verified sonic-mgmt bgp tests are passing on single asic voq sku
Also verified the sonic-bgpcfgd/tests' unit tests pass
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)