Skip to content

[YANG] Change VXLAN tunnel YANG model to support 2 tunnels + string validation#23984

Merged
yejianquan merged 9 commits intosonic-net:masterfrom
developfast:dev/yang/vxlan-max-elems-validation
Sep 13, 2025
Merged

[YANG] Change VXLAN tunnel YANG model to support 2 tunnels + string validation#23984
yejianquan merged 9 commits intosonic-net:masterfrom
developfast:dev/yang/vxlan-max-elems-validation

Conversation

@developfast
Copy link
Copy Markdown
Contributor

Why I did it

Change VXLAN tunnel YANG model to support 2 tunnels + string validation. This is to allow for newer validation in production.

Work item tracking
  • Microsoft ADO (number only): 33013419

How I did it

Modify vxlan tunnel list model and add unit tests

How to verify it

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

Description for the changelog

Change VXLAN tunnel YANG model to support 2 tunnels + string validation

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@developfast developfast requested a review from wen587 September 12, 2025 03:26
@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wen587
Copy link
Copy Markdown
Contributor

wen587 commented Sep 12, 2025

There are other tests which check length and fail. It should pass now:

"VXLAN_TUNNEL_NAME_INVALID_LENGTH_TEST": {
"desc": "Tunnel Name string length exceeding 16 is invalid",
"eStr" : "Invalid interface name length, it must not exceed 16 characters."
},
"VXLAN_TUNNEL_NAME_INVALID_TEST": {
"desc": "Tunnel Name string length 0 is invalid",
"eStr" : "Invalid interface name length, it must not exceed 16 characters."
},
"VXLAN_TUNNEL_NAME_VALID_DST_IPV4_TEST": {
"desc": "Valid IPv4 Destination Address",
"eStr" : "Invalid interface name length, it must not exceed 16 characters."
},

@wen587 wen587 requested a review from ganglyu September 12, 2025 03:33
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@developfast developfast requested a review from wen587 September 12, 2025 04:00
kperumalbfn
kperumalbfn previously approved these changes Sep 12, 2025
@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Copy Markdown
Contributor

@kperumalbfn kperumalbfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan
Copy link
Copy Markdown
Contributor

@yejianquan yejianquan merged commit ec22803 into sonic-net:master Sep 13, 2025
19 of 20 checks passed
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202411: #23999

@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202505: #24000

FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Dec 4, 2025
…alidation (sonic-net#23984)

Why I did it
Change VXLAN tunnel YANG model to support 2 tunnels + string validation. This is to allow for newer validation in production.

Work item tracking
Microsoft ADO (number only): 33013419
How I did it
Modify vxlan tunnel list model and add unit tests

Tested branch (Please provide the tested image version)

Description for the changelog
Change VXLAN tunnel YANG model to support 2 tunnels + string validation

signed-off-by: [email protected]
Signed-off-by: Feng Pan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants