Add sonic-telemetry-sidecar container#23936
Merged
qiluo-msft merged 22 commits intosonic-net:masterfrom Sep 25, 2025
Merged
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
force-pushed
the
sidecar_container
branch
from
5063bfa to
1b2e9b2
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
force-pushed
the
sidecar_container
branch
from
1b2e9b2 to
6b2bdb8
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
force-pushed
the
sidecar_container
branch
from
6b2bdb8 to
9031478
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
force-pushed
the
sidecar_container
branch
from
9031478 to
2cb43df
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
force-pushed
the
sidecar_container
branch
from
2cb43df to
42b6c11
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
force-pushed
the
sidecar_container
branch
from
42b6c11 to
1e1d408
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
force-pushed
the
sidecar_container
branch
from
1e1d408 to
d94ea36
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
force-pushed
the
sidecar_container
branch
from
d94ea36 to
1541439
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Sep 24, 2025
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#1686 |
Contributor
|
Manual pick to 202412 for fixing build issues: Azure/sonic-buildimage-msft#1698 |
r12f
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
FengPan-Frank
added a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Dec 4, 2025
Why I did it Create sidecar container which will stub systemd script, so that telemetry container rollout-ed via k8s could be managed by systemd script with naming change, as well as container checker logic. Work item tracking Microsoft ADO (number only): How I did it Added systemd_stub service, which check sha256 for stub file regularly and overwrite Stub into /usr/local/bin/telemetry.sh, so that systemd cmd could keep compatible, but the implementation changes into kubectl Stub into monit container_checker, since container name will be changed when it's rollout-ed via k8s, but it will has label "raw_container_name=telemetry", thus update is in get_current_running_from_dockers Added env IS_V1_ENABLED to control telemetry.sh operation, IS_V1_ENABLED as true will recover system's original telemetry.sh which used as rollback case IS_V1_ENABLED as false will used to stub k8s supported telemetry.sh and move on upgrade. Signed-off-by: Feng Pan <[email protected]>
qiluo-msft
pushed a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Jan 26, 2026
Why I did it Create sidecar container which will stub systemd script, so that telemetry container rollout-ed via k8s could be managed by systemd script with naming change, as well as container checker logic. Work item tracking Microsoft ADO (number only): How I did it Added systemd_stub service, which check sha256 for stub file regularly and overwrite Stub into /usr/local/bin/telemetry.sh, so that systemd cmd could keep compatible, but the implementation changes into kubectl Stub into monit container_checker, since container name will be changed when it's rollout-ed via k8s, but it will has label "raw_container_name=telemetry", thus update is in get_current_running_from_dockers Added env IS_V1_ENABLED to control telemetry.sh operation, IS_V1_ENABLED as true will recover system's original telemetry.sh which used as rollback case IS_V1_ENABLED as false will used to stub k8s supported telemetry.sh and move on upgrade.
qiluo-msft
pushed a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Jan 26, 2026
Why I did it Create sidecar container which will stub systemd script, so that telemetry container rollout-ed via k8s could be managed by systemd script with naming change, as well as container checker logic. Work item tracking Microsoft ADO (number only): How I did it Added systemd_stub service, which check sha256 for stub file regularly and overwrite Stub into /usr/local/bin/telemetry.sh, so that systemd cmd could keep compatible, but the implementation changes into kubectl Stub into monit container_checker, since container name will be changed when it's rollout-ed via k8s, but it will has label "raw_container_name=telemetry", thus update is in get_current_running_from_dockers Added env IS_V1_ENABLED to control telemetry.sh operation, IS_V1_ENABLED as true will recover system's original telemetry.sh which used as rollback case IS_V1_ENABLED as false will used to stub k8s supported telemetry.sh and move on upgrade.
qiluo-msft
pushed a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Jan 26, 2026
Why I did it Create sidecar container which will stub systemd script, so that telemetry container rollout-ed via k8s could be managed by systemd script with naming change, as well as container checker logic. Work item tracking Microsoft ADO (number only): How I did it Added systemd_stub service, which check sha256 for stub file regularly and overwrite Stub into /usr/local/bin/telemetry.sh, so that systemd cmd could keep compatible, but the implementation changes into kubectl Stub into monit container_checker, since container name will be changed when it's rollout-ed via k8s, but it will has label "raw_container_name=telemetry", thus update is in get_current_running_from_dockers Added env IS_V1_ENABLED to control telemetry.sh operation, IS_V1_ENABLED as true will recover system's original telemetry.sh which used as rollback case IS_V1_ENABLED as false will used to stub k8s supported telemetry.sh and move on upgrade.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Create sidecar container which will stub systemd script, so that telemetry container rollout-ed via k8s could be managed by systemd script with naming change, as well as container checker logic.
Work item tracking
How I did it
IS_V1_ENABLED as true will recover system's original telemetry.sh which used as rollback case
IS_V1_ENABLED as false will used to stub k8s supported telemetry.sh and move on upgrade.
How to verify it
tested on kubesonic env as well.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)