Skip to content

[action] [PR:23936] Add sonic-telemetry-sidecar container#1686

Closed
mssonicbld wants to merge 1 commit intoAzure:202412from
mssonicbld:cherry/msft-202412/23936
Closed

[action] [PR:23936] Add sonic-telemetry-sidecar container#1686
mssonicbld wants to merge 1 commit intoAzure:202412from
mssonicbld:cherry/msft-202412/23936

Conversation

@mssonicbld
Copy link
Collaborator

Why I did it

Create sidecar container which will stub systemd script, so that telemetry container rollout-ed via k8s could be managed by systemd script with naming change, as well as container checker logic.

Work item tracking
  • Microsoft ADO (number only):

How I did it

  1. Added systemd_stub service, which check sha256 for stub file regularly and overwrite
  2. Stub into /usr/local/bin/telemetry.sh, so that systemd cmd could keep compatible, but the implementation changes into kubectl
  3. Stub into monit container_checker, since container name will be changed when it's rollout-ed via k8s, but it will has label "raw_container_name=telemetry", thus update is in get_current_running_from_dockers
  4. Added env IS_V1_ENABLED to control telemetry.sh operation,
    IS_V1_ENABLED as true will recover system's original telemetry.sh which used as rollback case
    IS_V1_ENABLED as false will used to stub k8s supported telemetry.sh and move on upgrade.

How to verify it

image

tested on kubesonic env as well.
image

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants