Introducing a new platform for asic clounix#23365
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom Aug 5, 2025
Merged
Introducing a new platform for asic clounix#23365qiluo-msft merged 1 commit intosonic-net:masterfrom
qiluo-msft merged 1 commit intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
longwu-clounix
force-pushed
the
Support-new-asic-platform-clounix
branch
from
f6fb9d0 to
dd97d7a
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
longwu-clounix
force-pushed
the
Support-new-asic-platform-clounix
branch
from
dd97d7a to
ec7c069
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@lguohan Hi, could you review this PR? Much appreciated : ) |
Contributor
Author
@lguohan @qiluo-msft Please take a look at this PR : ), thank you very much! |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new platform for the ASIC Clounix architecture to the SONiC project. It adds comprehensive platform support including drivers, utilities, Docker containers, and build configurations for Clounix-based networking hardware.
- Adds platform drivers and kernel modules for I2C multiplexers and hardware monitoring
- Implements Docker containers for syncd, saiserver, and PTF testing with Clounix SAI integration
- Introduces utilities for port configuration, SFP detection, and transceiver management
Reviewed Changes
Copilot reviewed 88 out of 143 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| platform/clounix/sonic-platform-modules-pegatron/common/modules/i2c-mux-pca9641.c | I2C multiplexer driver implementation for PCA9641 bus master selector |
| platform/clounix/clx-utils/clounix-utils/scripts/sfpdet | Python utility for SFP detection and port configuration (2000+ lines) |
| platform/clounix/sai.mk | SAI library configuration and package definitions |
| platform/clounix/rules.mk | Platform build rules and dependencies |
| platform/clounix/docker-syncd-clounix/Dockerfile.j2 | Docker configuration for Clounix syncd container |
Comments suppressed due to low confidence (2)
platform/clounix/sonic-platform-modules-pegatron/common/modules/clounix_sysfs_main.c:318
- [nitpick] Debug message uses unclear abbreviation '(ar)select'. Consider using a more descriptive debug message like 'Arbitration select started' for better maintainability.
static int add_new_link(struct kernfs_node *root, char *src, char *node)
platform/clounix/clx-utils/clounix-utils/scripts/sfpdet:350
- [nitpick] Using magic number comparison. Consider using a boolean return or named constant instead of comparing with literal 1.
or len(phy_port_value[phy_port_value]) == 0:
platform/clounix/sonic-platform-modules-pegatron/common/modules/i2c-mux-pca9641.c
Outdated
Show resolved
Hide resolved
platform/clounix/sonic-platform-modules-pegatron/common/modules/i2c-mux-pca9641.c
Outdated
Show resolved
Hide resolved
Collaborator
|
Semgrep identified some real issues, please fix below warnings: |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
longwu-clounix
force-pushed
the
Support-new-asic-platform-clounix
branch
from
de2583d to
29ad0d6
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Clounix is a switch chip manufacturer. This commit aims to support its ASIC in the sonic system. Signed-off-by: Zhou,Junde <[email protected]> Signed-off-by: Long Wu <[email protected]>
longwu-clounix
force-pushed
the
Support-new-asic-platform-clounix
branch
from
29ad0d6 to
a060342
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
This commit aims to support new asic of Clounix, so the specific product code, clounix private code is not needed, delete it. |
Contributor
Author
|
@zhangyanzhao could please review this PR? Much appreciated. |
Contributor
Author
|
Hi @lguohan , @qiluo-msft, |
qiluo-msft
pushed a commit
to qiluo-msft/sonic-buildimage
that referenced
this pull request
Aug 6, 2025
Why I did it Introducing a new platform for asic clounix How to verify it Test on clounix hardware. [build] Fix url for newly onboarded clounix platform. (sonic-net#23609) Why I did it Old URL don't work.
9 tasks
ccroy-arista
pushed a commit
to ccroy-arista/sonic-buildimage
that referenced
this pull request
Aug 14, 2025
Why I did it Introducing a new platform for asic clounix How to verify it Test on clounix hardware. [build] Fix url for newly onboarded clounix platform. (sonic-net#23609) Why I did it Old URL don't work.
longwu-clounix
added a commit
to clounix-sw/sonic-swss
that referenced
this pull request
Oct 13, 2025
What I did Add support for platform based on Clounix asic. The Clounix asic platform code has been merged into sonic-buildimage repo. Please see details in PR: sonic-net/sonic-buildimage#23365 How I did it Add support for platform based on Clounix asic. How to verify it Verified on physical DUT. Signed-off-by: Long Wu <[email protected]> Signed-off-by: Qinghua Song <[email protected]>
longwu-clounix
added a commit
to clounix-sw/sonic-swss
that referenced
this pull request
Oct 16, 2025
What I did Add support for platform based on Clounix asic. The Clounix asic platform code has been merged into sonic-buildimage repo. Please see details in PR: sonic-net/sonic-buildimage#23365 How I did it Add support for platform based on Clounix asic. How to verify it Verified on physical DUT. Signed-off-by: Long Wu <[email protected]> Signed-off-by: Qinghua Song <[email protected]>
longwu-clounix
added a commit
to clounix-sw/sonic-swss
that referenced
this pull request
Oct 30, 2025
What I did Add support for platform based on Clounix asic. The Clounix asic platform code has been merged into sonic-buildimage repo. Please see details in PR: sonic-net/sonic-buildimage#23365 How I did it Add support for platform based on Clounix asic. How to verify it Verified on physical DUT. Signed-off-by: Long Wu <[email protected]> Signed-off-by: Qinghua Song <[email protected]>
longwu-clounix
added a commit
to clounix-sw/sonic-swss
that referenced
this pull request
Nov 4, 2025
What I did Add support for platform based on Clounix asic. The Clounix asic platform code has been merged into sonic-buildimage repo. Please see details in PR: sonic-net/sonic-buildimage#23365 How I did it Add support for platform based on Clounix asic. How to verify it Verified on physical DUT. Signed-off-by: Long Wu <[email protected]> Signed-off-by: Qinghua Song <[email protected]>
longwu-clounix
added a commit
to clounix-sw/sonic-swss
that referenced
this pull request
Nov 11, 2025
What I did Add support for platform based on Clounix asic. The Clounix asic platform code has been merged into sonic-buildimage repo. Please see details in PR: sonic-net/sonic-buildimage#23365 How I did it Add support for platform based on Clounix asic. How to verify it Verified on physical DUT. Signed-off-by: Long Wu <[email protected]> Signed-off-by: Qinghua Song <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Introducing a new platform for asic clounix
How to verify it
Test on clounix hardware.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)