[PDDF] Multiple FPGAs w/ I2C IP blocks by lotus-nexthop · Pull Request #22748 · sonic-net/sonic-buildimage

lotus-nexthop · 2025-05-28T23:29:42Z

Why I did it

PDDF currently supports only a single PCIE controlled FPGA in the system.
This change adds the ability to support multiple PCIE controlled FPGAs.
[PDDF] HLD Add multifpgapci module SONiC#2006
Enhancement: PDDF Support multiple PCIe FPGAs #22838

Work item tracking

Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

mssonicbld · 2025-05-28T23:29:49Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-05-28T23:30:01Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-05-29T05:24:16Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-05-29T05:24:28Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-05-29T05:32:52Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-05-29T05:33:03Z

Azure Pipelines successfully started running 1 pipeline(s).

adyeung · 2025-06-04T15:23:46Z

@FuzailBrcm @Praveen-Brcm pls help review

FuzailBrcm · 2025-06-17T06:46:05Z

@geans-pin @leeprecy
Please review

FuzailBrcm · 2025-07-15T09:29:55Z

platform/pddf/platform-api-pddf-base/sonic_platform_pddf_base/pddfapi.py

        if attr['device_type'] == 'SYSSTAT':
            return self.sysstatus_parse(dev, ops)

+        if attr['device_type'] == 'MULTIFPGAPCIESYSTEM':


MULTIFPGAPCIESYSTEM is parallel to "SYSTEM" object in the JSON file. Since 'create_pddf_devices' is already calling multifpgapcisystem_parse(), there is no need to call it from here. multifpgapcisystem_parse() will never be invoked from dev_parse().

Is there any update with regard to this comment?
Is it taken care of?

Thank you for the catch here! I've removed multifpgapcisystem_parse() from pddfapi.py as I agree that this won't be invoked and that it is redundant with multifpgapcisystem_parse() in pddfparse.py.

Thanks for taking care

linux-foundation-easycla · 2025-07-31T23:29:51Z

The committers listed above are authorized under a signed CLA.

✅ login: lotus-nexthop (5f2d070, 051148b)
✅ login: louis-nexthop (711da88, ecfef9d, 51c0f92, 4031d7e)
✅ login: michaelc-nexthop (8a2d788)

mssonicbld · 2025-07-31T23:29:54Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-07-31T23:30:06Z

Azure Pipelines successfully started running 1 pipeline(s).

mssonicbld · 2025-07-31T23:33:55Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-07-31T23:34:06Z

Azure Pipelines successfully started running 1 pipeline(s).

louis-nexthop · 2025-08-04T19:13:25Z

/azpw ms_conflict

mssonicbld · 2025-08-05T17:38:02Z

/azp run Azure.sonic-buildimage

azure-pipelines · 2025-08-05T17:38:18Z

Azure Pipelines successfully started running 1 pipeline(s).

* IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR #22748) * [PDDF] Add multi PCIE FPGA controlled fans * handle negative divisor * parse multifpgapciesystem appropriately * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR #22748) * [PDDF] Remove attr_bdf for MultiFPGA FAN * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR #22748) * no-op commit to retrigger workflow --------- Co-authored-by: Michael Chan <michaelc@nexthop.ai> Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR #22748) * [PDDF] Add multi PCIE FPGA controlled XCVR * parse multifpgapciesystem appropriately * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR #22748) * [PDDF] Remove attr_bdf for MultiFPGA XCVR * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR #22748) * Trigger Build * no-op commit to retrigger workflow --------- Co-authored-by: Michael Chan <michaelc@nexthop.ai> Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR #22748) * [PDDF] Add multi PCIE FPGA controlled LED * parse multifpgapciesystem appropriately * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR #22748) * [PDDF] Remove attr_bdf for MultiFPGA LED * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR #22748) * no-op commit to retrigger workflow --------- Co-authored-by: Michael Chan <michaelc@nexthop.ai> Co-authored-by: Louis Maliyam <louis@nexthop.ai>

…-net#22748)

* Add initial Nexthop platform folders * IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR #22748) * Add various sensors * fix sensors json, delete stale test * add more sensors * do aligned writes in fpga util * parse multifpgapciesystem appropriately * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR #22748) * [PDDF] Remove attr_bdf in NH-4010's pddf-device.json * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR #22748) * Bring back device_parent null for multifpgapciesystem * Rename devname of each multifpgapcie device * Trigger Build * no-op commit to retrigger workflow --------- Co-authored-by: Roy Wen <roy@nexthop.ai> Co-authored-by: Michael Chan <michaelc@nexthop.ai> Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR #22748) * [PDDF] Add multi PCIE FPGA controlled PSU * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR #22748) * [PDDF] Remove attr_bdf for MultiFPGA PSU * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR #22748) * no-op commit to retrigger workflow * IGNORE THIS COMMIT: Parse multifpgapciesystem appropriately (PR #22748) --------- Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* [PDDF] Multiple FPGAs w/ I2C IP blocks * [PDDF] Remove PDDF_DATA_ATTR_VAL * [PDDF] Remove empty line in pddf_client_defs.h * [PDDF] MULTIFPGAPCIE to use client device table * [PDDF] Parse multifpgapciesystem appropriately * [PDDF] Remove multifpgapcisystem_parse() in pddfapi.py * no-op commit to retrigger workflow --------- Co-authored-by: Louis Maliyam <louis@nexthop.ai> Co-authored-by: Michael Chan <michaelc@nexthop.ai>

* IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748) * [PDDF] Add multi PCIE FPGA controlled fans * handle negative divisor * parse multifpgapciesystem appropriately * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR sonic-net#22748) * [PDDF] Remove attr_bdf for MultiFPGA FAN * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR sonic-net#22748) * no-op commit to retrigger workflow --------- Co-authored-by: Michael Chan <michaelc@nexthop.ai> Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748) * [PDDF] Add multi PCIE FPGA controlled XCVR * parse multifpgapciesystem appropriately * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR sonic-net#22748) * [PDDF] Remove attr_bdf for MultiFPGA XCVR * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR sonic-net#22748) * Trigger Build * no-op commit to retrigger workflow --------- Co-authored-by: Michael Chan <michaelc@nexthop.ai> Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748) * [PDDF] Add multi PCIE FPGA controlled LED * parse multifpgapciesystem appropriately * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR sonic-net#22748) * [PDDF] Remove attr_bdf for MultiFPGA LED * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR sonic-net#22748) * no-op commit to retrigger workflow --------- Co-authored-by: Michael Chan <michaelc@nexthop.ai> Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* Add initial Nexthop platform folders * IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748) * Add various sensors * fix sensors json, delete stale test * add more sensors * do aligned writes in fpga util * parse multifpgapciesystem appropriately * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR sonic-net#22748) * [PDDF] Remove attr_bdf in NH-4010's pddf-device.json * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR sonic-net#22748) * Bring back device_parent null for multifpgapciesystem * Rename devname of each multifpgapcie device * Trigger Build * no-op commit to retrigger workflow --------- Co-authored-by: Roy Wen <roy@nexthop.ai> Co-authored-by: Michael Chan <michaelc@nexthop.ai> Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748) * [PDDF] Add multi PCIE FPGA controlled PSU * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR sonic-net#22748) * [PDDF] Remove attr_bdf for MultiFPGA PSU * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR sonic-net#22748) * no-op commit to retrigger workflow * IGNORE THIS COMMIT: Parse multifpgapciesystem appropriately (PR sonic-net#22748) --------- Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR #22748) * [PDDF] Add multi PCIE fpga controlled i2c mux * cleanup * remove goto, fix assignment * parse multifpgapciesystem appropriately * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR #22748) * [PDDF] Remove attr_bdf for MultiFPGA CPLDMUX * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR #22748) * Fix typo PDDF_XCVR -> PDDF_CPLDMUX * no-op commit to retrigger workflow --------- Co-authored-by: Michael Chan <michaelc@nexthop.ai> Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* [PDDF] Multiple FPGAs w/ I2C IP blocks * [PDDF] Remove PDDF_DATA_ATTR_VAL * [PDDF] Remove empty line in pddf_client_defs.h * [PDDF] MULTIFPGAPCIE to use client device table * [PDDF] Parse multifpgapciesystem appropriately * [PDDF] Remove multifpgapcisystem_parse() in pddfapi.py * no-op commit to retrigger workflow --------- Co-authored-by: Louis Maliyam <louis@nexthop.ai> Co-authored-by: Michael Chan <michaelc@nexthop.ai>

* IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748) * [PDDF] Add multi PCIE FPGA controlled fans * handle negative divisor * parse multifpgapciesystem appropriately * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR sonic-net#22748) * [PDDF] Remove attr_bdf for MultiFPGA FAN * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR sonic-net#22748) * no-op commit to retrigger workflow --------- Co-authored-by: Michael Chan <michaelc@nexthop.ai> Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748) * [PDDF] Add multi PCIE FPGA controlled XCVR * parse multifpgapciesystem appropriately * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR sonic-net#22748) * [PDDF] Remove attr_bdf for MultiFPGA XCVR * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR sonic-net#22748) * Trigger Build * no-op commit to retrigger workflow --------- Co-authored-by: Michael Chan <michaelc@nexthop.ai> Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748) * [PDDF] Add multi PCIE FPGA controlled LED * parse multifpgapciesystem appropriately * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR sonic-net#22748) * [PDDF] Remove attr_bdf for MultiFPGA LED * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR sonic-net#22748) * no-op commit to retrigger workflow --------- Co-authored-by: Michael Chan <michaelc@nexthop.ai> Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* Add initial Nexthop platform folders * IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748) * Add various sensors * fix sensors json, delete stale test * add more sensors * do aligned writes in fpga util * parse multifpgapciesystem appropriately * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR sonic-net#22748) * [PDDF] Remove attr_bdf in NH-4010's pddf-device.json * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR sonic-net#22748) * Bring back device_parent null for multifpgapciesystem * Rename devname of each multifpgapcie device * Trigger Build * no-op commit to retrigger workflow --------- Co-authored-by: Roy Wen <roy@nexthop.ai> Co-authored-by: Michael Chan <michaelc@nexthop.ai> Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748) * [PDDF] Add multi PCIE FPGA controlled PSU * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR sonic-net#22748) * [PDDF] Remove attr_bdf for MultiFPGA PSU * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR sonic-net#22748) * no-op commit to retrigger workflow * IGNORE THIS COMMIT: Parse multifpgapciesystem appropriately (PR sonic-net#22748) --------- Co-authored-by: Louis Maliyam <louis@nexthop.ai>

* IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748) * [PDDF] Add multi PCIE fpga controlled i2c mux * cleanup * remove goto, fix assignment * parse multifpgapciesystem appropriately * IGNORE THIS COMMIT: Remove PDDF_DATA_ATTR_VAL and use client device table (PR sonic-net#22748) * [PDDF] Remove attr_bdf for MultiFPGA CPLDMUX * IGNORE THIS COMMIT: Remove multifpgapcisystem_parse() in pddfapi.py (PR sonic-net#22748) * Fix typo PDDF_XCVR -> PDDF_CPLDMUX * no-op commit to retrigger workflow --------- Co-authored-by: Michael Chan <michaelc@nexthop.ai> Co-authored-by: Louis Maliyam <louis@nexthop.ai>

lotus-nexthop force-pushed the fpga-i2c branch from c0e8edf to a53b5fd Compare May 29, 2025 05:24

[PDDF] Multiple FPGAs w/ I2C IP blocks

051148b

lotus-nexthop force-pushed the fpga-i2c branch from a53b5fd to 051148b Compare May 29, 2025 05:32

lotus-nexthop added a commit to nate-nexthop/sonic-buildimage that referenced this pull request May 29, 2025

IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748)

5446bb8

lotus-nexthop added a commit to nate-nexthop/sonic-buildimage that referenced this pull request May 29, 2025

IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748)

bf47c28

lotus-nexthop added a commit to nate-nexthop/sonic-buildimage that referenced this pull request May 29, 2025

IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748)

20a5a17

lotus-nexthop added a commit to nate-nexthop/sonic-buildimage that referenced this pull request May 29, 2025

IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748)

d34271e

lotus-nexthop added a commit to nate-nexthop/sonic-buildimage that referenced this pull request May 29, 2025

IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748)

a8a3806

lotus-nexthop mentioned this pull request May 29, 2025

PDDF: Add MultiFPGA support to PDDF subsystem #22671

Closed

11 tasks

lotus-nexthop added a commit to lotus-nexthop/sonic-buildimage that referenced this pull request May 29, 2025

IGNORE THIS COMMIT: Multiple FPGAs w/ I2C IP block (PR sonic-net#22748)

882146c

lotus-nexthop mentioned this pull request Jun 4, 2025

[PDDF] HLD Add multifpgapci module sonic-net/SONiC#2006

Merged

lotus-nexthop marked this pull request as ready for review June 4, 2025 01:28

lotus-nexthop requested a review from lguohan as a code owner June 4, 2025 01:28

FuzailBrcm reviewed Jul 15, 2025

View reviewed changes

[PDDF] Remove PDDF_DATA_ATTR_VAL

711da88

[PDDF] Remove empty line in pddf_client_defs.h

51c0f92

FuzailBrcm approved these changes Aug 1, 2025

View reviewed changes

geans-pin approved these changes Aug 2, 2025

View reviewed changes

leeprecy approved these changes Aug 3, 2025

View reviewed changes

Praveen-Brcm approved these changes Aug 4, 2025

View reviewed changes

no-op commit to retrigger workflow

5f2d070

Praveen-Brcm merged commit 12f7737 into sonic-net:master Aug 5, 2025
12 checks passed

louis-nexthop added a commit to nate-nexthop/sonic-buildimage that referenced this pull request Aug 5, 2025

IGNORE THIS COMMIT: Parse multifpgapciesystem appropriately (PR sonic…

4e30c6f

…-net#22748)

jon-nokia mentioned this pull request Aug 7, 2025

Fix sonic-ctrmgrd-rs installation for INCLUDE_KUBERNETES condition #23598

Merged

9 tasks

Conversation

lotus-nexthop commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

mssonicbld commented May 28, 2025

Uh oh!

azure-pipelines bot commented May 28, 2025

Uh oh!

mssonicbld commented May 29, 2025

Uh oh!

azure-pipelines bot commented May 29, 2025

Uh oh!

mssonicbld commented May 29, 2025

Uh oh!

azure-pipelines bot commented May 29, 2025

Uh oh!

adyeung commented Jun 4, 2025

Uh oh!

FuzailBrcm commented Jun 17, 2025

Uh oh!

FuzailBrcm Jul 15, 2025

Choose a reason for hiding this comment

Uh oh!

FuzailBrcm Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

louis-nexthop Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

FuzailBrcm Aug 1, 2025

Choose a reason for hiding this comment

Uh oh!

linux-foundation-easycla bot commented Jul 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssonicbld commented Jul 31, 2025

Uh oh!

azure-pipelines bot commented Jul 31, 2025

Uh oh!

mssonicbld commented Jul 31, 2025

Uh oh!

azure-pipelines bot commented Jul 31, 2025

Uh oh!

louis-nexthop commented Aug 4, 2025

Uh oh!

mssonicbld commented Aug 5, 2025

Uh oh!

azure-pipelines bot commented Aug 5, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

lotus-nexthop commented May 28, 2025 •

edited

Loading

linux-foundation-easycla bot commented Jul 31, 2025 •

edited

Loading