Skip to content

[TACACS] Fix memory leak when authenticating using tacacs#22600

Merged
qiluo-msft merged 4 commits intosonic-net:masterfrom
DavidZagury:master_tacacs_mem
May 25, 2025
Merged

[TACACS] Fix memory leak when authenticating using tacacs#22600
qiluo-msft merged 4 commits intosonic-net:masterfrom
DavidZagury:master_tacacs_mem

Conversation

@DavidZagury
Copy link
Contributor

Why I did it

A small memory leak was found when running TACACS

Work item tracking
  • Microsoft ADO (number only):

How I did it

A patch was created for the libnss-tacplus repository that will fix the memory leak.

How to verify it

Configure TACACS
Use the python script that reproduce the consumption and monitor its memory consumption.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This reverts commit 2ea206d.
This reverts commit ef8e4d6.
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DavidZagury
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft qiluo-msft changed the title [TACACS]|Fix memory leak when authenticating using tacacs [TACACS] Fix memory leak when authenticating using tacacs May 23, 2025
@liat-grozovik
Copy link
Collaborator

@qiluo-msft can you go a head and merge it? need to decide if to take to all the branches listed or not. please update the label accordingly.

@qiluo-msft qiluo-msft merged commit e3ea97f into sonic-net:master May 25, 2025
19 checks passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#1170

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202505: #23044

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202505: #23145

@bingwang-ms
Copy link
Contributor

@yejianquan for 202505 cherry-pick
@kperumalbfn for 202411 cherry-pick

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #23150

@qiluo-msft
Copy link
Collaborator

@DavidZagury Could you raise a PR for 202311?

@DavidZagury
Copy link
Contributor Author

Cherry-pick PR to 202411: #23150

@qiluo-msft 202311 PR: #23226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.