[TACACS]|Fix memory leak when authenticating using tacacs#72
Closed
DavidZagury wants to merge 4 commits intomasterfrom
Closed
[TACACS]|Fix memory leak when authenticating using tacacs#72DavidZagury wants to merge 4 commits intomasterfrom
DavidZagury wants to merge 4 commits intomasterfrom
Conversation
Yarden-Z
approved these changes
May 12, 2025
qiluo-msft
reviewed
May 12, 2025
src/tacacs/nss/patch/0013-Partial-memleak-fix-due-to-unfreed-strdup.patch
Show resolved
Hide resolved
DavidZagury
force-pushed
the
master_tacacs_mem
branch
from
ffacfb9 to
f6e87ac
Compare
qiluo-msft
reviewed
May 14, 2025
| + } | ||
| + | ||
| } | ||
| - fclose(conf); |
qiluo-msft
reviewed
May 14, 2025
| + } | ||
| + token = strsep(&buf, delim); | ||
| } | ||
| - fclose(conf); |
|
Why are we adjusting the old patch in order to fix this issue? I'd suggest going back to the original suggestion by Deddy to have a clean overview of this specific fix. |
Owner
Author
@Yarden-Z Qi requested it. |
DavidZagury
pushed a commit
that referenced
this pull request
Jul 2, 2025
…ically (sonic-net#23157) #### Why I did it src/sonic-dash-ha ``` * b8ca7c1 - (HEAD -> master, origin/master, origin/HEAD) Change field_values deserializer to support serde(default) (#71) (4 hours ago) [yue-fred-gao] * 1b6f04f - Test utils to test hamgrd in local workspace (#72) (4 hours ago) [yue-fred-gao] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Sep 10, 2025
…ly (sonic-net#23898) #### Why I did it src/sonic-stp ``` * e3626a4 - (HEAD -> master, origin/master, origin/HEAD) [MSTP] Fixing buffer OOB Read/Write issues (#72) (20 hours ago) [Shivashankar C R] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Sep 28, 2025
…ly (sonic-net#24123) #### Why I did it src/dhcprelay ``` * 5b078ef - (HEAD -> master, origin/master, origin/HEAD) Move DHCPv6 Relay code to dhcp6relay folder (#72) (7 minutes ago) [Shivashankar C R] ``` #### How I did it #### How to verify it #### Description for the changelog
DavidZagury
pushed a commit
that referenced
this pull request
Mar 15, 2026
…ly (sonic-net#25665) #### Why I did it src/sonic-ztp ``` * 17930d7 - (HEAD -> 202511, origin/202511) Skip ZTP service during warm boot (#72) (4 hours ago) [mssonicbld] ``` #### How I did it #### How to verify it #### Description for the changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
A small memory leak was found when running TACACS
Work item tracking
How I did it
A patch was created for the libnss-tacplus repository that will fix the memory leak.
How to verify it
Configure TACACS
Use the python script that reproduce the consumption and monitor its memory consumption.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)