Skip to content

[Mellanox] enable 'create_only_config_db_buffers' to optimize counters polling for Mellanox-SN4700-V64#22225

Merged
liat-grozovik merged 1 commit intosonic-net:masterfrom
ayurkiv-nvda:master_v64_bulc_counter
May 19, 2025
Merged

[Mellanox] enable 'create_only_config_db_buffers' to optimize counters polling for Mellanox-SN4700-V64#22225
liat-grozovik merged 1 commit intosonic-net:masterfrom
ayurkiv-nvda:master_v64_bulc_counter

Conversation

@ayurkiv-nvda
Copy link
Contributor

@ayurkiv-nvda ayurkiv-nvda commented Apr 3, 2025

Why I did it

Need to optimize counters polling for Mellanox-SN4700-V64

Work item tracking
  • Microsoft ADO (number only):

How I did it

Set "create_only_config_db_buffers" in config_db to "true"

How to verify it

run config reload and check initialization sequence

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

…s polling for Mellanox-SN4700-V64

Signed-off-by: Andriy Yurkiv <ayurkiv@nvidia.com>
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@lolyu lolyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bingwang-ms
Copy link
Contributor

Hi @ayurkiv-nvda , there is another file change in PR #22224
device/mellanox/x86_64-mlnx_msn4700-r0/Mellanox-SN4700-V64/supporting_bulk_counter_groups
Is that intentional or a missing?

@stephenxs
Copy link
Collaborator

Hi @ayurkiv-nvda , there is another file change in PR #22224

device/mellanox/x86_64-mlnx_msn4700-r0/Mellanox-SN4700-V64/supporting_bulk_counter_groups

Is that intentional or a missing?

@bingwang-ms we have optimized counter initialization on 202412 and above. So, we don't need it anymore.

@ayurkiv-nvda
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bingwang-ms
Copy link
Contributor

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liat-grozovik liat-grozovik merged commit d4f2b7b into sonic-net:master May 19, 2025
19 checks passed
@prabhataravind
Copy link
Contributor

@ayurkiv-nvda could you confirm this does not cause the regression in #16202? Does "show queue counters" still show q7 counters with this change? @bingwang-ms for viz.

@volodymyrsamotiy
Copy link
Collaborator

volodymyrsamotiy commented Jun 2, 2025

Discussed with @bingwang-ms, configuration will be added separately by internal script. @ayurkiv-nvda, please revert this change

ayurkiv-nvda added a commit to ayurkiv-nvda/sonic-buildimage that referenced this pull request Jul 1, 2025
… counters polling for Mellanox-SN4700-V64 (sonic-net#22225)"

This reverts commit d4f2b7b.
qiluo-msft pushed a commit that referenced this pull request Jul 7, 2025
… counters polling for Mellanox-SN4700-V64 (#22225)" (#22833)

This reverts commit d4f2b7b.

Why I did it
Revert PR #22225 because MSFT will integrate config separately by some internal logic

How I did it
remove config file

How to verify it
run config reload and check initialization sequence
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants