Skip to content

[202411][Mellanox] Support new field supporting_bulk_counter_groups in DEVICE__METADATA|localhost for Mellanox-SN4700-V64 #22224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ayurkiv-nvda wants to merge 1 commit into from
Closed

[202411][Mellanox] Support new field supporting_bulk_counter_groups in DEVICE__METADATA|localhost for Mellanox-SN4700-V64 #22224

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions ...ce/mellanox/x86_64-mlnx_msn4700-r0/Mellanox-SN4700-V64/create_only_config_db_buffers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"DEVICE_METADATA": {
"localhost": {
"create_only_config_db_buffers": "true"
}
}
}
1 change: 1 addition & 0 deletions device/mellanox/x86_64-mlnx_msn4700-r0/Mellanox-SN4700-V64/supporting_bulk_counter_groups
View file
Open in desktop
Copy link
Copy Markdown
Contributor

@bingwang-ms bingwang-ms Apr 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the behavior if only supporting_bulk_counter_groups is present while create_only_config_db_buffers.json is missing?

Copy link
Copy Markdown
Collaborator

@stephenxs stephenxs Apr 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bingwang-ms
In that case the bulk won't work correctly because

  1. We only use configured queues. All those queues support bulk counter polling
  2. Without create_only_config_db_buffers, flex counter will bulk-poll all queue counters, some of which do not support bulk polling.
  3. It can fail if we try to bulk-poll objects with mixed supporting and unsupporting objects. There is a logic to dynamically determine whether bulk is supported on an object and remove the objects that do not support bulk poll during initialization. This guarantees that all objects polled in bulk mode at run time support bulk polling, like the scenario where create_only_config_db_buffers is not provided.
  4. However, by providing supporting_bulk_counter_groups, the logic in 3 is disabled. There will be runtime error.

In master, create_only_config_db_buffers is not a must but still recommended because it is faster

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
QUEUE_WATERMARK_STAT_COUNTER,PG_WATERMARK_STAT_COUNTER,PFC_WD
Loading