Adding default QoS configurations for Arista-7050CX3-32S-C28S4. #22117
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| {%- set default_cable = '300m' %} | ||
|
|
||
| {%- macro generate_port_lists(PORT_ALL) %} | ||
| {# Generate list of ports #} | ||
| {%- for port_idx in range(0,32) %} | ||
| {%- if PORT_ALL.append("Ethernet%d" % (port_idx * 4)) %}{%- endif %} | ||
|
Contributor
There was a problem hiding this comment. Do we have the same port name mappings for 10G, like port_idx * 4? Please check.
Contributor
There was a problem hiding this comment. Good catch, we use the whole port, so it worked out to be the same port names.
Contributor
Author
There was a problem hiding this comment. yes, I have confirmed that before. Since these 10G ports uses only 1 lane from the physical port, so the port number still jumps by 4. Here is the port config ini:
|
||
| {%- endfor %} | ||
| {%- endmacro %} | ||
|
|
||
| {%- set ingress_lossless_pool_size = '32689152' %} | ||
| {%- set egress_lossless_pool_size = '32340992' %} | ||
| {%- if (DEVICE_METADATA is defined) and ('localhost' in DEVICE_METADATA) and ('subtype' in DEVICE_METADATA['localhost']) and (DEVICE_METADATA['localhost']['subtype'] == 'DualToR') %} | ||
| {%- set ingress_lossless_pool_size = '32441856' %} | ||
| {%- set egress_lossless_pool_size = '32441856' %} | ||
| {%- endif %} | ||
|
|
||
| {%- macro generate_buffer_pool_and_profiles() %} | ||
| "BUFFER_POOL": { | ||
| "ingress_lossless_pool": { | ||
| "size": "{{ingress_lossless_pool_size }}", | ||
| "type": "ingress", | ||
| "mode": "dynamic", | ||
| "xoff": "2058240" | ||
| }, | ||
| "egress_lossy_pool": { | ||
| "size": "24192256", | ||
| "type": "egress", | ||
| "mode": "dynamic" | ||
| }, | ||
| "egress_lossless_pool": { | ||
| "size": "{{egress_lossless_pool_size }}", | ||
| "type": "egress", | ||
| "mode": "static" | ||
| } | ||
|
Contributor
There was a problem hiding this comment. In this config, egress_lossless has less buffer compared to ingress lossless. So, there could be egress drop before PFC gets generated. For now, we could go with buffer configs in device/arista/x86_64-arista_7050cx3_32s/Arista-7050CX3-32S-D48C8/BALANCED/buffers_defaults_t0.j2
Contributor
There was a problem hiding this comment. Agreed, default should be files under balanced folder.
Contributor
Author
There was a problem hiding this comment. Hi Ying, the default is already in balance folder. But the problem is even that is not working right.
Contributor
Author
There was a problem hiding this comment. We need to switch from C32 to D48C8. |
||
| }, | ||
| "BUFFER_PROFILE": { | ||
| "ingress_lossy_profile": { | ||
| "pool":"ingress_lossless_pool", | ||
| "size":"0", | ||
| "static_th":"{{ingress_lossless_pool_size }}" | ||
| }, | ||
| "egress_lossless_profile": { | ||
| "pool":"egress_lossless_pool", | ||
| "size":"0", | ||
| "static_th":"{{egress_lossless_pool_size }}" | ||
| }, | ||
| "egress_lossy_profile": { | ||
| "pool":"egress_lossy_pool", | ||
| "size":"1792", | ||
| "dynamic_th":"3" | ||
| } | ||
| }, | ||
| {%- endmacro %} | ||
|
|
||
| {% import 'buffers_extra_queues.j2' as defs with context %} | ||
|
|
||
| {%- macro generate_queue_buffers_with_extra_lossless_queues(port_names, port_names_require_extra_buffer) %} | ||
| {{ defs.generate_queue_buffers_with_extra_lossless_queues(port_names, port_names_require_extra_buffer) }} | ||
| {%- endmacro %} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| {%- set default_cable = '300m' %} | ||
|
|
||
| {%- macro generate_port_lists(PORT_ALL) %} | ||
| {# Generate list of ports #} | ||
| {%- for port_idx in range(0,32) %} | ||
| {%- if PORT_ALL.append("Ethernet%d" % (port_idx * 4)) %}{%- endif %} | ||
| {%- endfor %} | ||
| {%- endmacro %} | ||
|
|
||
| {%- macro generate_buffer_pool_and_profiles() %} | ||
| "BUFFER_POOL": { | ||
| "ingress_lossless_pool": { | ||
| "size": "32712448", | ||
| "type": "ingress", | ||
| "mode": "dynamic", | ||
| "xoff": "1622016" | ||
| }, | ||
| "egress_lossy_pool": { | ||
| "size": "24709632", | ||
| "type": "egress", | ||
| "mode": "dynamic" | ||
| }, | ||
| "egress_lossless_pool": { | ||
| "size": "32599040", | ||
| "type": "egress", | ||
| "mode": "static" | ||
| } | ||
| }, | ||
| "BUFFER_PROFILE": { | ||
| "ingress_lossy_profile": { | ||
| "pool":"ingress_lossless_pool", | ||
| "size":"0", | ||
| "static_th":"32712448" | ||
| }, | ||
| "egress_lossless_profile": { | ||
| "pool":"egress_lossless_pool", | ||
| "size":"0", | ||
| "static_th":"32599040" | ||
| }, | ||
| "egress_lossy_profile": { | ||
| "pool":"egress_lossy_pool", | ||
| "size":"1792", | ||
| "dynamic_th":"3" | ||
| } | ||
| }, | ||
| {%- endmacro %} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # PG lossless profiles. | ||
| # speed cable size xon xoff threshold xon_offset | ||
r12f marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| 10000 5m 4608 4608 160000 0 4608 | ||
| 50000 5m 4608 4608 160000 0 4608 | ||
| 100000 5m 4608 4608 160000 0 4608 | ||
| 10000 40m 4608 4608 160000 0 4608 | ||
| 50000 40m 4608 4608 160000 0 4608 | ||
| 100000 40m 4608 4608 160000 0 4608 | ||
| 10000 300m 4608 4608 160000 0 4608 | ||
| 50000 300m 4608 4608 160000 0 4608 | ||
| 100000 300m 4608 4608 160000 0 4608 | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please copy buffers.json.j2 for this new SKU
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like they are exactly the same:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you mean another file?