Adding default QoS configurations for Arista-7050CX3-32S-C28S4.#22117
Adding default QoS configurations for Arista-7050CX3-32S-C28S4.#22117kperumalbfn merged 2 commits intosonic-net:masterfrom
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
device/arista/x86_64-arista_7050cx3_32s/Arista-7050CX3-32S-C28S4/BALANCED/pg_profile_lookup.ini
Show resolved
Hide resolved
| @@ -0,0 +1,52 @@ | |||
| {%- set default_cable = '300m' %} | |||
There was a problem hiding this comment.
please copy buffers.json.j2 for this new SKU
There was a problem hiding this comment.
looks like they are exactly the same:
There was a problem hiding this comment.
do you mean another file?
| {%- macro generate_port_lists(PORT_ALL) %} | ||
| {# Generate list of ports #} | ||
| {%- for port_idx in range(0,32) %} | ||
| {%- if PORT_ALL.append("Ethernet%d" % (port_idx * 4)) %}{%- endif %} |
There was a problem hiding this comment.
Do we have the same port name mappings for 10G, like port_idx * 4? Please check.
There was a problem hiding this comment.
Good catch, we use the whole port, so it worked out to be the same port names.
There was a problem hiding this comment.
yes, I have confirmed that before. Since these 10G ports uses only 1 lane from the physical port, so the port number still jumps by 4.
Here is the port config ini:
| "size": "32599040", | ||
| "type": "egress", | ||
| "mode": "static" | ||
| } |
There was a problem hiding this comment.
In this config, egress_lossless has less buffer compared to ingress lossless. So, there could be egress drop before PFC gets generated.
For now, we could go with buffer configs in device/arista/x86_64-arista_7050cx3_32s/Arista-7050CX3-32S-D48C8/BALANCED/buffers_defaults_t0.j2
There was a problem hiding this comment.
Agreed, default should be files under balanced folder.
There was a problem hiding this comment.
Hi Ying, the default is already in balance folder. But the problem is even that is not working right.
There was a problem hiding this comment.
We need to switch from C32 to D48C8.
|
@kperumalbfn , all comments are addressed now. do you mind to help take another look? |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Cherry-pick PR to 202405: #22141 |
|
Cherry-pick PR to 202411: #22744 |
6 participants
Why I did it
The default QoS configuration for Arista-7050CX3-32S-C28S4 is not added. This change is fixing the issues.
Work item tracking
How I did it
Added the default QoS configurations for Arista-7050CX3-32S-C28S4.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)