Fix buffer configs for TH5 C224 SKU#21624
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Feb 8, 2025
Merged
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kperumalbfn
approved these changes
Feb 5, 2025
Collaborator
|
@r12f @kperumalbfn can either of you retrigger the pipeline checks? |
Contributor
Restarted the tests |
r12f
approved these changes
Feb 7, 2025
Contributor
|
CI is passed. @kperumalbfn do you mind to help with the checkin? |
Contributor
|
hi @rick-arista there is conflict with auto cherrypick, could you file separate PR? |
Contributor
Author
|
Hi @StormLiangMS , looks like 202411 is missing this backport first, #21155 Or was the intention here to backport this to msft-202412? |
Contributor
|
@rick-arista #21155 will be merged to 202411 as well. Once we merge that, we can add this PR to 202411. |
11 tasks
Collaborator
|
Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#607 |
mssonicbld
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
kperumalbfn
added
Approved for 202411 Branch
and removed
Cherry Pick Conflict_202411
labels
11 tasks
Collaborator
|
Cherry-pick PR to 202411: #21810 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The values in this config were found to be incorrect when testing. With fewer interfaces than the C256, the reserved buffer space is smaller and therefore the shared limit in this config must be smaller.
The BUFFER_QUEUE macro was also not present, causing the defaults to be used which referenced lossless profiles.
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)