Skip to content

Add buffer configs for TH5 C224 and C256 SKUs#21155

Merged
StormLiangMS merged 8 commits intosonic-net:masterfrom
kperumalbfn:kperumal/TH5_100G
Jan 23, 2025
Merged

Add buffer configs for TH5 C224 and C256 SKUs#21155
StormLiangMS merged 8 commits intosonic-net:masterfrom
kperumalbfn:kperumal/TH5_100G

Conversation

@kperumalbfn
Copy link
Contributor

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

THRESHOLD_MODE: LOSSY
TM_SCHEDULER_CONFIG:
NUM_MC_Q: NUM_MC_Q_2
...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The BCM file seems to be missing all the queue configurations, this might cause problems. even CPU queue is not here, not sure if this is expected.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

service pool is also missing, is this expected? (ideally, this can be done by buffer SAI APIs, but in the 256x200G HWSKU, it didn't really work well.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for pure lossy config using SDK defaults. Will need to check if explicit service pool configs are required.

LIBSAIBCM_XGS_VERSION = 11.2.17.2
LIBSAIBCM_DNX_VERSION = 11.2.13.1-1
LIBSAIBCM_XGS_BRANCH_NAME = SAI_11.2.16.2
LIBSAIBCM_XGS_BRANCH_NAME = SAI_11_2_16_2_CS00012372635
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this be the final branch name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is a temporary branch. Once we get the final fix from BCM, this will be moved to main branch

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Pull request contains merge conflicts.

"{{ port }}|9": {
"scheduler": "scheduler.1"
}
{%- endmacro -%}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi Kumaresh, is the WRED config also in here?

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kperumalbfn kperumalbfn marked this pull request as ready for review January 22, 2025 01:10
@kperumalbfn kperumalbfn requested a review from lguohan as a code owner January 22, 2025 01:10
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang
Copy link
Contributor

@Gfrom2016 for viz.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@r12f r12f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since BCM file is provided for Broadcom and I assume broadcom has the unit test, although service pool is missing, it might be ok. signed off and we can follow up seprately.

@StormLiangMS StormLiangMS merged commit 3e59c91 into sonic-net:master Jan 23, 2025
15 checks passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#547

@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #21706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants