Skip to content

[Smartswitch] Add SonicDpu to the type in DEVICE_METADATA yang model #21520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiluo-msft merged 2 commits into from
Jan 28, 2025
Merged

[Smartswitch] Add SonicDpu to the type in DEVICE_METADATA yang model #21520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
753ddbd
Added dpu to type of device yang model
gpunathilell Jan 23, 2025
ff2aaf2
Added tests for the yang changes
gpunathilell Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sonic-yang-models/tests/yang_model_tests/tests/device_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,9 @@
"DEVICE_METADATA_TYPE_BMC_MGMT_TOR_PATTERN": {
"desc": "DEVICE_METADATA value as BmcMgmtToRRouter for Type field"
},
"DEVICE_METADATA_TYPE_SONIC_DPU_PATTERN": {
"desc": "DEVICE_METADATA value as SonicDpu for Type field"
},
"DEVICE_METADATA_TYPE_SONIC_HOST_PATTERN": {
"desc": "DEVICE_METADATA value as SonicHost for Type field"
},
Expand Down
10 changes: 10 additions & 0 deletions src/sonic-yang-models/tests/yang_model_tests/tests_config/device_metadata.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,16 @@
}
}
},
"DEVICE_METADATA_TYPE_SONIC_DPU_PATTERN": {
"sonic-device_metadata:sonic-device_metadata": {
"sonic-device_metadata:DEVICE_METADATA": {
"sonic-device_metadata:localhost": {
"bgp_asn": "65002",
"type": "SonicDpu"
}
}
}
},
"DEVICE_METADATA_TYPE_SONIC_HOST_PATTERN": {
"sonic-device_metadata:sonic-device_metadata": {
"sonic-device_metadata:DEVICE_METADATA": {
Expand Down
2 changes: 1 addition & 1 deletion src/sonic-yang-models/yang-models/sonic-device_metadata.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ module sonic-device_metadata {
leaf type {
type string {
length 1..255;
pattern "ToRRouter|LeafRouter|SpineChassisFrontendRouter|ChassisBackendRouter|ASIC|MgmtToRRouter|SpineRouter|BackEndToRRouter|BackEndLeafRouter|EPMS|MgmtTsToR|BmcMgmtToRRouter|SonicHost|not-provisioned";
pattern "ToRRouter|LeafRouter|SpineChassisFrontendRouter|ChassisBackendRouter|ASIC|MgmtToRRouter|SpineRouter|BackEndToRRouter|BackEndLeafRouter|EPMS|MgmtTsToR|BmcMgmtToRRouter|SonicHost|SonicDpu|not-provisioned";
Copy link
Copy Markdown
Contributor

@ganglyu ganglyu Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/sonic-net/sonic-mgmt/blob/master/ansible/vars/topo_dpu.yml#L15

We use SonicHost for DPU, why do we need SonicDpu?

}
}

Expand Down