[Smartswitch] Add SonicDpu to the type in DEVICE_METADATA yang model#21520
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Jan 28, 2025
Merged
[Smartswitch] Add SonicDpu to the type in DEVICE_METADATA yang model#21520qiluo-msft merged 2 commits intosonic-net:masterfrom
SonicDpu to the type in DEVICE_METADATA yang model#21520qiluo-msft merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wen587
approved these changes
Jan 24, 2025
ganglyu
reviewed
Jan 24, 2025
| type string { | ||
| length 1..255; | ||
| pattern "ToRRouter|LeafRouter|SpineChassisFrontendRouter|ChassisBackendRouter|ASIC|MgmtToRRouter|SpineRouter|BackEndToRRouter|BackEndLeafRouter|EPMS|MgmtTsToR|BmcMgmtToRRouter|SonicHost|not-provisioned"; | ||
| pattern "ToRRouter|LeafRouter|SpineChassisFrontendRouter|ChassisBackendRouter|ASIC|MgmtToRRouter|SpineRouter|BackEndToRRouter|BackEndLeafRouter|EPMS|MgmtTsToR|BmcMgmtToRRouter|SonicHost|SonicDpu|not-provisioned"; |
Contributor
There was a problem hiding this comment.
https://github.com/sonic-net/sonic-mgmt/blob/master/ansible/vars/topo_dpu.yml#L15
We use SonicHost for DPU, why do we need SonicDpu?
prsunny
approved these changes
Jan 28, 2025
Contributor
|
Hi @gpunathilell , I notice in recent HLD, the type was changed from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
This change is done because the DPUs are initalized with the
SonicDputype from sonic-config-enginesonic-buildimage/src/sonic-config-engine/config_samples.py
Line 148 in 9b9da85
This is added to the yang models in order to yang validation doesn't fail
Fixes: #21111
Work item tracking
How I did it
Added
SonicDputype in src/sonic-yang-models/tests/yang_model_tests/tests/device_metadata.jsonHow to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)