Skip to content

[sonic-frr-mgmt-framework]: refactor the way of load srv6 locator opcode … #20954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kperumalbfn merged 1 commit into from
Nov 29, 2024
Merged

[sonic-frr-mgmt-framework]: refactor the way of load srv6 locator opcode … #20954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/sonic-frr-mgmt-framework/frrcfgd/frrcfgd.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2078,7 +2078,7 @@ class BGPConfigDaemon:
('icmo_ttl', 'ttl {}', handle_ip_sla_common),
('icmp_tos', 'tos {}', handle_ip_sla_common),
]
srv6_locator_key_map = [(['opcode_prefix', 'opcode_act', 'opcode_vrf'], '{no:no-prefix}opcode {} {} vrf {}', hdl_srv6_locator)]
srv6_locator_key_map = [(['opcode_prefix', 'opcode_act', 'opcode_data'], '{no:no-prefix}opcode {} {} {}', hdl_srv6_locator)]
Copy link
Copy Markdown
Contributor

@kperumalbfn kperumalbfn Nov 28, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LARLSN Does this change support all the other Endpoint behaviors? Could you please add details to the description about the usage for DT/X. How about uSID endpoint behaviors?

Copy link
Copy Markdown
Contributor Author

@LARLSN LARLSN Nov 29, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added details in description. And current load way in frrcfgd can not recognize uSID config field in json file, so a locator for uSID will still be loaded as an ordinary locator.



tbl_to_key_map = {'BGP_GLOBALS': global_key_map,
Expand Down