[sonic-frr-mgmt-framework]: refactor the way of load srv6 locator opcode …#20954
Merged
kperumalbfn merged 1 commit intosonic-net:masterfrom Nov 29, 2024
Merged
[sonic-frr-mgmt-framework]: refactor the way of load srv6 locator opcode …#20954kperumalbfn merged 1 commit intosonic-net:masterfrom
kperumalbfn merged 1 commit intosonic-net:masterfrom
Conversation
…ode config Signed-off-by: linsongnan <linsongnan.lsn@alibaba-inc.com>
|
|
9 tasks
Contributor
|
/azpw ms_conflict -f |
kperumalbfn
reviewed
Nov 28, 2024
| ('icmp_tos', 'tos {}', handle_ip_sla_common), | ||
| ] | ||
| srv6_locator_key_map = [(['opcode_prefix', 'opcode_act', 'opcode_vrf'], '{no:no-prefix}opcode {} {} vrf {}', hdl_srv6_locator)] | ||
| srv6_locator_key_map = [(['opcode_prefix', 'opcode_act', 'opcode_data'], '{no:no-prefix}opcode {} {} {}', hdl_srv6_locator)] |
Contributor
There was a problem hiding this comment.
@LARLSN Does this change support all the other Endpoint behaviors? Could you please add details to the description about the usage for DT/X. How about uSID endpoint behaviors?
Contributor
Author
There was a problem hiding this comment.
I've added details in description. And current load way in frrcfgd can not recognize uSID config field in json file, so a locator for uSID will still be loaded as an ordinary locator.
kperumalbfn
approved these changes
Nov 29, 2024
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
…ode config (sonic-net#20954) [sonic-frr-mgmt-framework]: refactor the way of load srv6 locator opcode config Signed-off-by: linsongnan <linsongnan.lsn@alibaba-inc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr refactor the way of load srv6 locator opcode in frrcfgd to support other opcode action
Why I did it
Previous way of load srv6 locator config do not support end/endx opcode action.
The current configuration example of config_db json file is as follows：
Work item tracking
How I did it
How to verify it
it may impact config reload of srv6 locator
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)